aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fix errors count calculation when removing multiple table rows. Caused by ↵stuconnolly2010-05-031-9/+13
| | | | [MCPConnection affectedRows] returning -1. Fixes issue #654.
* Review trigger fetching and storage:rowanbeentje2010-05-019-202/+289
| | | | | | | - Trigger queries are no longer made for MySQL < 5.0.2 - Trigger loading has been deferred until the trigger tab is active, reducing queries when switching tables and thus increasing overall responsiveness - Export triggers in MySQL dumps even if the Table Content switch is unchecked
* Perform additional index bounds checking before attempting to remove a table ↵stuconnolly2010-04-301-1/+5
| | | | field. Fixes exception http://spbug.com/l/100.
* Changed a couple of 'int' to NSIntegermltownsend2010-04-291-2/+2
|
* Perform index range checking before attempting to remove a table index. ↵stuconnolly2010-04-291-2/+6
| | | | Fixes exception http://spbug.com/l/164.
* For add/rename/duplicate DB: check new name input for an existing db name ↵drx7772010-04-291-3/+3
| | | | and disable OK button if it does.
* Changed appearance of copy/rename DB to match that of copyTable. drx7772010-04-293-142/+131
| | | | | Added the to be copied/renamed database name to the name input sheet. Added necessary outlets. Added the current db name as preset value in the rename input field. Renamed databaseNewSheet to databaseCopySheet and copyOnlyStructureButton to copyDatabaseDataButton and inverted behaviour of the button.
* Disable copy/rename database in menu, if no database is selecteddrx7772010-04-291-1/+3
|
* Disables copy/rename confirmation buttons in copy/rename sheet if no name is ↵drx7772010-04-292-17/+13
| | | | provided
* Only switch to the renamed/duplicated database name, if the action was ↵drx7772010-04-295-13/+21
| | | | successful. Caused an existing DB to be selected, after ren/dup failed because it exists.
* Cleanup/simplification: using messageWindow property directly instead of the ↵drx7772010-04-294-25/+9
| | | | getTableWindow method; removed the latter
* Now longer using [NSApp mainWindow] but a reference to the correct window ↵drx7772010-04-297-19/+12
| | | | for message sheets. It could have caused messages appearing in the wrong window.
* Added class SPDBActionCommons providing common functionality to all derived ↵drx7772010-04-2911-93/+108
| | | | DatabaseActions classes, thus reducing code duplicates.
* removing debug output (NSLog calls)drx7772010-04-291-2/+0
|
* Duplicate/Rename DB: catch an unnecessary error message on canceling input ↵drx7772010-04-291-2/+6
| | | | sheet by checking the returnCode of the sheet.
* Missed a few files in previous commit.stuconnolly2010-04-290-0/+0
|
* It would help if I actually used the correct keyword myself when setting SVN ↵stuconnolly2010-04-292-2/+2
| | | | properties.
* Attempt to fix SVN poperties.stuconnolly2010-04-290-0/+0
|
* - Fix CFRunLoopWakeUp crashes seen on 10.5.8 with SSH connections by ↵rowanbeentje2010-04-281-0/+4
| | | | running the run loop after disconnection to flush calls
* * removed SPDatabaseCopyTest testCopyDatabaseTables which is out of place heredrx7772010-04-289-46/+145
| | | | | | | | | * minor restructuring of SPTableCopy for readability and debuggability * corrected wrong default copyright header on some files * SPCopyTableTest: removed testCopyTableFromTo since it is integrated in testCopyTableFromToWithData; * SPCopyTableTest: fixed test to reflect two queries table creation (show create and create) instead of create like (<4.1 compatibility)
* Menu item reordering.stuconnolly2010-04-281-22/+80
|
* SVN properties.stuconnolly2010-04-2810-10/+10
|
* This changeset implements renaming and duplicating databases on a server. ↵drx7772010-04-2823-54/+2239
| | | | | | | | | | | | | | | | | | | Details as follows: * altered MCPConnection listTablesFromDB:like: to return NSArray * altered MCPConnection listFieldsFromTable:like: to use backtick quoted strings for table and fieldnames * added MCPConnection listTablesFromDB for a complete table list * added SPStringAdditions.h to various files to prevent warnings * added sheets for duplicate/rename DB in DBView.xib * added duplicate/rename menu items to MainMenu.xib * added outlets in TableDocument: databaseNewSheet databaseRenameSheet databaseCopyNameField databaseRenameNameField copyOnlyStructureButton copyDatabaseButton renameDatabaseButton * added methods in TableDocument: getConnection, copyDatabase, renameDatabase, _copyDatabase, _renameDatabase * added OCMock Framework for object mocking in tests * added group Others/DatabaseActions
* Added myself to the list of devs, testing svn commit accessdrx7772010-04-281-3/+6
|
* - Upgrade MySQL libraries to 5.1.46 (was 5.1.44)rowanbeentje2010-04-274-3/+3
| | | | | - Alter build scripts to use --enable-local-infile as a configuration option; this addresses http://spbug.com/644
* Remeber to refresh the user manager's schemas table view when switching to ↵stuconnolly2010-04-273-24/+69
| | | | the schema privileges tab. Fixes issue #648.
* Add extra connection checking at multiple stages of getting the server's ↵stuconnolly2010-04-272-16/+21
| | | | process list. Fixes http://spbug.com/l/152.
* Correctly quote database name when GRANT'ing and REVOK'ing privileges. Fixes ↵stuconnolly2010-04-271-2/+2
| | | | issue #647.
* - Improve threading of SPFileHandle to achieve much faster writing due to ↵rowanbeentje2010-04-262-9/+31
| | | | increased separation of the writing thread. This results in a up-to 1.2x faster MySQL dump for fast servers, and makes SPFileHandle faster than NSFileHandle for writing data (either directly or GZIP compressed).
* Enable all *reasonable* warnings for all build configurations and fix a few ↵stuconnolly2010-04-268-7/+95
| | | | of them.
* Add the option to set whether or not old leaks logs are deleted.stuconnolly2010-04-252-37/+43
|
* Dump leaks logs to the user's desktop, falling back to /tmp if not possible.stuconnolly2010-04-251-12/+40
|
* Enhance SPLogger by adding the ability to run leaks() against the ↵stuconnolly2010-04-243-42/+162
| | | | | | | | | application upon termination with the result being written to /tmp. To enable call setDumpLeaksOnTermination on SPLogger. Note, that SPLogger has been restructed to accommodate calling this method without writing the additional log file to the user's desktop. Could probably be enhanced a bit by someone with better C skills than me.
* Bunch of improvements to the serve processes panel, including:stuconnolly2010-04-247-110/+1045
| | | | | | | | | | - MCPKit's listProcesses (mysql_list_processes) method is now used, instead of running the query ourselves. - The ability to set whether or not the list is auto refreshed. - The ability to set the autorefresh interval, either via the presets or by entering a custom value (the interface for this might need updating). - Get the process list is now performed on a background thread. This completes the implementation of issue #607.
* Merge in minor fixes from 0.9.8 RC merge review:rowanbeentje2010-04-242-2/+4
| | | | | | - Make a tiny fix to narrow down completion to avoid memory overrelease issues - Unhide the "Show create view syntax" menu and contextual menu items when selecting a view
* - Ensure that Growl notifications are made from the main thread. This ↵rowanbeentje2010-04-231-0/+8
| | | | addresses http://spbug.com/643 , and should also fix race condition crashes caused by the timer firing on a closed thread.
* Perform bounds checking in the process list controller's table view data ↵stuconnolly2010-04-231-2/+2
| | | | source method. Fixes exception http://spbug.com/l/146.
* Only attempt to check or set the max allowed packet if there is an active ↵stuconnolly2010-04-233-20/+34
| | | | connection as well as only displaying dialogs when there is a window visible. Fixes http://spbug.com/l/113.
* - SPNarrowDownCompletion: Pass NSApp certain events *after* processing ↵rowanbeentje2010-04-231-2/+3
| | | | locally, to fix further crashes like http://spbug.com/l/139 .
* - Allow CMTextView to track SPNarrowDownCompletion state, ensuring old ↵rowanbeentje2010-04-224-35/+50
| | | | | | | windows are closed. This also allows SPNarrowDownCompletion to be closed when CMTextView is deallocated; this should fix http://spbug.com/l/139 . - Fix some minor memory leaks
* Ensure that table change selection notifications are posted to the main thread.stuconnolly2010-04-221-1/+1
|
* changed many occurrences of "REMOVE" to "DELETE", eg. "DELETE DATABASE"jakob2010-04-229-46/+46
|
* fix for #642 (deleting more than 3 rows failed on MySQL before 5.0.3)jakob2010-04-221-5/+9
|
* Speed up SPDatabaseData by obtaining the server version when the connection ↵stuconnolly2010-04-212-17/+29
| | | | is set to prevent multiple calls everytime the list of available storange engines, etc. is requested.
* When saving an SPF only save the socket if it's present. Fixes ↵stuconnolly2010-04-201-1/+1
| | | | http://spbug.com/l/137
* Localize 'Edit Favorites...' popup button menu item.stuconnolly2010-04-202-3/+3
|
* Fix an issue whereby choosing to edit the selected favourite in the ↵stuconnolly2010-04-203-13/+2
| | | | connection view would select the wrong favourite in the preferences because sorting has been applied to the table view.
* - Fix exceptions when right-clicking on the query favourites list. This ↵rowanbeentje2010-04-201-1/+2
| | | | addresses http://spbug.com/l/133 .
* - more fixing of issue 641. I forgot to consider the case of deleting the ↵jakob2010-04-191-2/+11
| | | | last row in the table
* - fix for #641 with regard to deleting rows (duplicating still doesnt work)jakob2010-04-191-4/+46
| | | | | - update row count after pressing escape when editing a new row