aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* A patch to improve View support, addressing Issue #130. This patch undoes ↵rowanbeentje2009-02-2310-183/+432
| | | | the damage caused by r333, making views viewable again, and extends support by preventing errors in the info pane, by drawing views with a different icon to easily differentiate them, by making all source/index information non-editable to match GUI to behaviour, and to tweak the interface slightly to match.
* Deselect favorites when any detail other than the password is edited. This ↵rowanbeentje2009-02-213-6/+75
| | | | improves clarity, but also fixes an issue: if a connection with amended details failed, the default favourite details are reloaded in the sheet if a favorite is selected. This change allows a connection to fail and the actual used details to be reshown in the sheet.
* Fix the last two warnings in TableContent.m. Also include an error string ↵rowanbeentje2009-02-191-3/+4
| | | | instead of breaking display when an NSData object can't be encoded, in the style of the -text or blob- placeholder.
* Moved "query favourites", "query history" and "Run Query" buttons to the ↵avenjamin2009-02-191-253/+276
| | | | other side of the splitter handle. This allows you to collapse the Query text field and still have access to the favourites and history popups.
* Fix Issue #140 (Tables with many columns compress the end columns against ↵rowanbeentje2009-02-192-101/+58
| | | | | | | | | the end of the table): - Set column sizing to "Uniform" , instead of "Sequential" - "Sequential" autosized columns so that all columns remained visible within the table, with as many columns as possible at full width, resulting in many columns being set to their minimum width. - Automatically delete saved column widths which are at minimum width on first run of this new version. This will delete columns intentionally set to minimum idth (once), but otherwise all tables which had their columns autoresized had the minimum/broken widths saved so even the fix above would not show. - Remove old CocoaMySQL prefs upgrade code, and store the last run bundle version in the code to allow prefs upgrades to occur according to the build number in future.
* - Ensure that the button controlling whether all data should be edited in a ↵rowanbeentje2009-02-182-3/+3
| | | | | | | sheet shows its state correctly (fixes Issue #169) - Fixes editing with "Don't load blob and text fields" preference enabled by fixing an incorrect method call
* Sets and enforces a connection timeout, and handles connection timeouts ↵rowanbeentje2009-02-185-21/+839
| | | | | | | | | | | | | | | | | | | appropriately - offering to retry, reconnect, or disconnect. This fixes Issue #93, Issue #69, and Issue #77. The gory details: Previously, MCPKit was correctly running mysql_ping to ensure a connection still existed before running a query, and aborted the query if the connection was no longer active.However the code very rarely checked the response of this, so if a query failed subsequent queries would continue to be run and the program would end up checking non-existent results, throwing Cocoa exceptions and generally breaking. However, mysql_ping would also use the default timeout (30 seconds) for each check - when running the (previous to r333) 14 queries to switch tables, this resulted in a long hang before the program even broke. To exacerbate the issue, certain situations triggered a bug present in mysql_ping in the old client binaries we're using (http://bugs.mysql.com/bug.php?id=9678), causing mysql_ping to never return despite the presence of a timeout, and so causing an indefinite hang. This issue has been fixed by: - Setting a new 10 second connection timeout for both new connections (Issue #69) and for mysql_pings. Once preferences have been redesigned we'll probably make this value editable. - Enforce the 10 second timeout even if mysql_ping hangs by using interrupts. - Wrap mysql_ping in a new method to do the above and also catch re-established connections without reporting false failures. - When a connection has failed, prompt the user to Retry, Reconnect, or Disconnect. Reconnect uses the original details for the old connection to establish a new connection, also attempting to preserve the current encoding. - Do not return control to the main loop until a connection has been reestablished (or disconnected) - this ensures the program is never in a broken state without having to rewrite all query usage. Much of the above patches the MCPKit connection methods as necessary.
* Visible improvements in this build:rowanbeentje2009-02-1824-649/+2235
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Significantly reduce the queries that have to be performed, improving lag - especially over slow connections (Issue #118; see new controller info under headline code changes). - Fix Issue #117 properly (export numeric quoting - we now have access to column types and so can quote appropriately). - Fix Issue #145 (loss of unsigned/null/default attributes when reordering columns). - Fixes Issue #90 (support for filtering DECIMAL column types) - Improve table scrolling speed when the table contains long items. (Added a NSFormatter to automatically truncate strings > 150 chars for display purposes only) - Improved SQL compatibility - for example /* C style comments */ are now correctly ignored in imports and custom queries. - Add text and symbols emphasising that the table info pane / status view row count is an approximation (partially addresses Issue #141) - Fixes a major memory leak whenever opening or scrolling tables containing text/blob data. - SQL import is now faster (SQL parsing part is 3x faster). - Speed up SQL export (1.5x faster for numeric data; 1.1x faster for string data) and slightly speed up CSV export (~1.1x faster). - Display sizes on the status view using the byte size formatter, as per table info pane. Headline code changes: - Add a new NSMutableString subclass, SPSQLParser. See the header file for documentation and overview, but in short it's a centralised place for SQL parsing. Centralises and improves parsing, improves comment support, improves quoting support. Despite the improved featureset this is also faster than the previous distributed implementations - for example, when used to replace the old splitQueries:, > 3x speedup. - Implement a new controller which handles a structure and status cache for the current table, and provides structure parsing for specified tables. This cache is now used throughout the code, reducing the queries that have to be performed and providing additional information about the table structure for use; I think it also improves column type format slightly. - The table info pane and the status view now draw all their data from the cache. Tweaks: - Table encoding is now detected directly instead of being derived from the collation - increased accuracy and cope with the DEFAULT encoding. - Comments and formatting cleaned up in bits I was working on, obviously. - A couple of methods - particularly [tablesListInstance table] and [tableDocument encoding] - have been renamed to avoid conflicts and fix code warnings. Future improvements now possible: - As we now have access to column types and other information, we can provide per-type behaviour where desired. - The table parsing doesn't currently pull out comments or table indices, together with one or two other attributes. Some of this would be useful for display; some, such as indices, could be used to draw the table structure view as long as we're happy discarding a couple of columns (ie cardinality!)
* Fixed Issue #168avenjamin2009-02-181-1/+3
| | | | Choose Database popup button now reverts to current database when cancelling the "Add Database…" dialog.
* Query failing because of field length applied to datetime field. Fixes #135.stuconnolly2009-01-291-1/+1
|
* Add 'Refresh Databases' menu item to the main database selection drop down. ↵stuconnolly2009-01-291-8/+12
| | | | Fixes issue #143
* Header change.stuconnolly2009-01-291-0/+2
|
* Header changes.stuconnolly2009-01-292-5/+3
|
* Date filters were order wrong causing the opposite of the expected result to ↵stuconnolly2009-01-281-4/+4
| | | | be returned. Fixes #151.
* We are not quoting the filter argument when filter type is 'IN' meaning the ↵stuconnolly2009-01-281-8/+7
| | | | SQL is failing.
* trim-application.sh shouldn't be included in the application bundle.stuconnolly2009-01-281-2/+0
|
* Added shell script to trim application bundle on 'Release' builds. Saves a ↵stuconnolly2009-01-282-3/+135
| | | | whole meg on current build.
* Separate out the creation of a human readable string from the number of ↵stuconnolly2009-01-286-54/+151
| | | | bytes into a category class method of NSString so we can potentially use it in other places.
* Enable menu separator now that we've enabled the print menu item.stuconnolly2009-01-271-2/+1
|
* Hide the help menu item until we've actually got some help documentation to ↵stuconnolly2009-01-271-2/+3
| | | | display.
* Updated copyright year to 2009.stuconnolly2009-01-271-0/+0
|
* Point the menu links to Sequel Pro's website rather than the Goolge Code site.stuconnolly2009-01-271-3/+3
|
* Commented the handleQuiteCommand method and put in a return of nil.mltownsend2009-01-201-1/+2
|
* We don't need the old SSH tunneling code lying about as its not used. Its ↵stuconnolly2009-01-183-270/+0
| | | | looged in Subversion if we ever need it again. Resolves issue #147.
* Added the print method to go from. Sort of works by printing the literal ↵mltownsend2009-01-181-0/+8
| | | | NSView that is currently selected.
* + Updated to use new icon in TABLE INFORMATION pane. (#146)avenjamin2009-01-184-5/+5
|
* #144 value of the "import format" popup button is now remembered in the ↵abhibeckert2009-01-142-12/+16
| | | | import panel
* Re-enabled Print Menu for preparation of being able to print something usefulmltownsend2009-01-131-7/+5
|
* Bored at home, so added my website to my name.mltownsend2009-01-081-1/+1
|
* Got a little bored during work, so tidied up the credits, yay.stuconnolly2009-01-061-18/+18
|
* Added cancel button to the import/export progress sheet. Also added ↵mltownsend2009-01-043-46/+121
| | | | importing on a separate thread.
* Fix for the MainMenu.xib not being compiled properly. All the XIBs were ↵stuconnolly2008-12-311-4/+59
| | | | being recopied whenever one was changed and not compiled.
* Truncate the displayed text of the filter drop down buttons. Addresses issue ↵stuconnolly2008-12-271-37/+42
| | | | #121.
* • CMTextView.m : added new auto-complete keywordsavenjamin2008-12-222-45/+90
| | | | • TableSource.m : fixed spelling error
* Clean up of validate menu items method.avenjamin2008-12-221-18/+8
|
* Disabled "Remove Database…" menu item when no database selected. Issue #124avenjamin2008-12-221-0/+4
|
* Spelling error in Flush Privilege's success message. Issue #123avenjamin2008-12-222-2/+2
|
* Removed Panther compatibilitiymltownsend2008-12-182-32/+11
|
* Mutating a NSMutableDictionary while enumerating through it. mltownsend2008-12-171-3/+4
|
* Fixed a range assertion error in SQL dumps when exporting small strings, ↵rowanbeentje2008-12-151-2/+4
| | | | caused by r274
* Thought this was fixed.stuconnolly2008-12-131-63/+14
|
* Provide a partial fix for Issue #117 by adding leading-zero tests to the ↵rowanbeentje2008-12-121-7/+10
| | | | NSScanner numeric checks, and clarifying comments to make it clearer that NSScanner should be replaced when possible.
* Added perl script to automatically add the build version to Info.plist.stuconnolly2008-12-103-1/+62
|
* Define CMMCPConnection's delegate methods to prevent warnings.stuconnolly2008-12-101-0/+7
|
* Remove warning.stuconnolly2008-12-101-4/+8
|
* Fixed MainMenu.xib not being compiled properly.stuconnolly2008-12-102-33/+89
|
* MERGED r262:266 from branches/stuart02 to trunk to include new project ↵stuconnolly2008-12-10242-436/+446
| | | | structure.
* - Re-add the LIMIT FROM NSStepper rowanbeentje2008-12-102-160/+240
| | | | | | | | - Allow Return or Enter pressed in the Limit From textbox to trigger a table filter - Reset the content table view position on filtering or limit - Refresh no longer clears the LIMIT FROM value if it's still valid - Resolves Issue #65 and partially addresses Issue #49.
* Slight tweak to per-table encoding autodetection following testing and quick ↵rowanbeentje2008-12-091-8/+1
| | | | chat with Stuart - now calls [TableDocument setEncoding:] so that all encoding setting is handled in one place. This fixes a bug where table encoding was detected correctly but only partly used, and adds error detection by falling back to connection autodetection if encoding change fails.
* Separate update_date checks from create_date checks, as InnoDB tables have a ↵rowanbeentje2008-12-091-7/+19
| | | | create_date but not an update_date. Fixes the Table Information pane on InnoDB tables and associated draw errors.