aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* • some progress on the filter table approachBibiko2010-09-283-20/+820
|
* • fixed exception while length checking for import into new table if ↵Bibiko2010-09-281-2/+2
| | | | | | checked value is not a NSString - fixes issue 1649
* - Make further improvements to 10.5.8 crashes by catching another ↵rowanbeentje2010-09-271-1/+8
| | | | release-on-close after mulitple windows were opened, improving http://spbug.com/728 .
* - Fix missing tableContentView references, which are required following the ↵rowanbeentje2010-09-271-26/+18
| | | | | | | content filter changes. This addresses http://spbug.com/l/1648 . - Clean up code a little
* • some progress on the filter table approachBibiko2010-09-273-33/+79
|
* When checking for DB changes during an export, don't refresh the table list, ↵stuconnolly2010-09-271-59/+51
| | | | which results in wiping the user's selection. Fix for issue #832.
* Correctly uppercase menu item. Also, update strings files.stuconnolly2010-09-273-423/+122
|
* • initial sketch approach to allow to write complex WHERE clauses by ↵Bibiko2010-09-273-326/+1705
| | | | | | using a table approach - not yet activated
* • made SPCopyTable more independent against missing 'tableStorage' objectBibiko2010-09-271-2/+2
|
* - Fix support for delimiters at the very end of a query string/filerowanbeentje2010-09-271-2/+2
|
* Improve delimiter support in imported SQL files:rowanbeentje2010-09-271-7/+13
| | | | | | - Retain the delimiter if one is found, to avoid autorelease issues. This fixes http://spbug.com/l/124 . - Improve delimiter support in a few functions, particularly SPSQLParser's trimAndReturnStringToCharacter:trimmingInclusively:returningInclusively:ignoringQuotedStrings, to improve compatibility
* * One label was too short in Content Filter Managerdmoagx2010-09-265-145/+2376
| | | | * Changed some NSLocalizedString() comments to be more descriptive - keep in mind that the comment is the only thing that can provide context here.
* Tweak favourites sorting from r2696, fixing exceptions when no sort type is ↵rowanbeentje2010-09-262-4/+4
| | | | selected
* Implement threading locking when modifying the query console/controller's ↵stuconnolly2010-09-262-0/+13
| | | | log data storage to prevent race conditions. Should fix crash: http://spbug.com/l/1644
* Remember the width of the server process list tableview columns between ↵stuconnolly2010-09-263-0/+30
| | | | application launches. Implements issue #814.
* Remove 10.4 related code and associated macros.stuconnolly2010-09-265-68/+11
|
* - Correctly sort connection favourites upon startup for both the connection ↵stuconnolly2010-09-265-146/+81
| | | | | | | and preferences view. Fixes issue #807. - Remove the default favourite indicator from the preferences view.
* - Remove "Release when closed" from three panels; this was causing ↵rowanbeentje2010-09-252-34/+145
| | | | conflicts with manual memory management on 10.5.8 on quit. This addresses http://spbug.com/728 , together with a number of recorded crashes ( http://spbug.com/l/190, http://spbug.com/l/1522 )
* Fix for exception http://spbug.com/l/1638 caused by the result of comment ↵stuconnolly2010-09-251-1/+1
| | | | changes in r2682.
* Consolidate and improve ping code:rowanbeentje2010-09-254-171/+153
| | | | | | | | - Foreground and keepalive pings now use the same code, which has been tidied and improved - Global variables are no longer incorrectly shared across multiple instances - If a ping thread blocks in a state where pthread_cancel no longer functions, the connection is assumed to have failed (network issues etc) This should further improve MySQL crashes linked to pings, and will hopefully address Issue #830. Also update localizable strings
* Change the comment fomat used when displaying and copying the create ↵stuconnolly2010-09-241-8/+5
| | | | syntaxes for multiple tables to '--' from '#'. Implements issue #842.
* • corrected switch() {} syntaxBibiko2010-09-231-3/+8
| | | | - this fixes issue 841
* Fix add index sheet height.stuconnolly2010-09-231-23/+23
|
* Add support in the new index sheet for specifying an index's key block size ↵stuconnolly2010-09-223-42/+245
| | | | (in the advanced view) which was added in MySQL 5.1.10.
* • fixed issue836 by avoiding the fact that while selecting a new table ↵Bibiko2010-09-223-103/+213
| | | | | | | | the CREATE SYNTAX will be parsed twice under certain circumstances which led to this issue - introduced a isWorking mechanism to SPTableData; while SPTableData is updating its cache (ie the CREATE SYNTAX is being parsed) each request for values will return nil or an empty array; the caller is responsible to decide what to do • various commenting stuff • various speed improvements
* Fix an issue where by an export would fail to begin when the check for ↵stuconnolly2010-09-221-2/+6
| | | | database changes was not required (functionality introduced in r2670). Fixes issue #835.
* • fixed issue 834 for filtering table list if TablesListView doesn't have ↵Bibiko2010-09-221-1/+1
| | | | | | the focus - corrected in tableViewSelectionDidChange: the check whether the selection was changed or not
* Add missing SVN properties and general comments tidy up.stuconnolly2010-09-2125-130/+74
|
* • do not use title strings of NSPopupButtons for creating the CREATE ↵Bibiko2010-09-211-105/+110
| | | | | | | TRIGGER query due to possible localizations, instead make usage of selected indices - fixes i829 - some code cleaning and commenting stuff
* • TableStructureBibiko2010-09-212-27/+131
| | | | | | - started general cell editing validation due to currently set type and other parameters to help user while setting up/changing fields (must be tested) - set BINARY checked if collation ends with _bin since string fields stores that information in that way for convenience - added TINYTEXT as type suggestion
* Update Localizable.strings and resolve the use of multiple comments for the ↵stuconnolly2010-09-216-19/+18
| | | | same string.
* • 'doPerformQueryService' set toolbar to Custom QueryBibiko2010-09-211-5/+6
| | | | - minor commenting stuff
* • reverted to rev 2630 which removed an 'unnecessary' [table reloadData]; ↵Bibiko2010-09-211-0/+1
| | | | there're instances where one has to reload the table explicitly
* Very minor tidy up.stuconnolly2010-09-201-3/+2
|
* • avoid exceptions etc. if content filter clause is emptyBibiko2010-09-201-10/+22
| | | | - in addition alert the user that this clause was empty to avoid confusion of filtered result set
* • SPTableContentBibiko2010-09-203-156/+551
| | | | | | | | | | | - added at the end of [self loadTableValues] an alert if loading failed • SPContentFilterManager - removed any key bindings for hopefully getting rid of some "mutating method sent to immutable object" exceptions/crashes [1479, 1372, 1310, 295, 1227, 692, 149] - better handling of ESC to cancel the name in-cell editing in table - improved validations - some general code improvements - added/changed comments
* • SPTableContentBibiko2010-09-203-184/+235
| | | | | - avoid replacing of % by %% for user-defined content filters if no argument is required • minor commenting stuff and code cleaning
* • fixed in [_addIndexUsingDetails:]: do not release supportsLength and ↵Bibiko2010-09-201-187/+208
| | | | | | | | | | | requiresLength since they are still in use • fixed: if new field was added store the the underlying NSDictionary not only the field name • fixed in [addIndex:]: init indexedFields with a mutable copy - this fixes all issue for "mutating method sent to immutable object" of SPIndexController like i1609 • fixed "Add" Button validation • fixed display of "Size" column validation • code cosmetics
* - A further attempt to improve MySQL library crashes by improving threaded ↵rowanbeentje2010-09-202-1/+33
| | | | | | | pings. This returns to an old approach by attempting to use interrupt signals to force a hung network read to close; however, the signal is now sent by the watchdog thread in a thread-safe fashion to specifically target the locking thread. If this approach works we'll probably consolidate the ping code to use it throughout. - Update localizable strings
* - Before performing an export (except from a dot export), refresh the table ↵stuconnolly2010-09-192-46/+106
| | | | | | | list to accommodate cases where additional tables have been added to the database by external applications. If so inform the user of this, giving them the choice of whether or not to continue with the export. - Update Localizable.strings
* - Prevent the table content from being filtered or pages through if a row ↵rowanbeentje2010-09-181-0/+2
| | | | is currently being edited and can't been saved cleanly. Addresses at least http://spbug.com/l/735 .
* - Remove a number of invalid [NSTableView makeFirstResponder] calls that ↵rowanbeentje2010-09-188-12/+12
| | | | | | | had crept into the source, replacing with the correct [NSWindow makeFirstResponder:NSTableView]. This fixes a number of exceptions. - Update localisable strings.
* - Clean up warnings when building with GCCrowanbeentje2010-09-183-10/+15
|
* Add index sheet:stuconnolly2010-09-182-12/+12
| | | | | | | | - Fix an exception caused when cancelling adding an index with the advanced options view open. - Move 'Cancel and 'Add' buttons to be inline with index type and name controls. Both found/suggested by Rowan.
* - Fix crashes triggered by connection unlocking after disconnection; this ↵rowanbeentje2010-09-181-2/+2
| | | | addresses http://spbug.com/l/1269 and possibly improves the vio_delete crashes
* - When opening the add new sheet, ensure that the remove button is disabled ↵stuconnolly2010-09-171-0/+10
| | | | | | | when there is only one indexed field. - When cancelling adding a new index reset the indexed columns.
* - Fix a UI validation bug when adding an additional indexed field with a ↵stuconnolly2010-09-171-2/+4
| | | | | | | | | length specified and the advanced view open. - Fix an exception when adding the same indexed field when creating a new index. Both found by Max. Thanks Max!
* * Fixes minor label length issues and one unlocalized stringdmoagx2010-09-173-597/+72
|
* New add index sheet, which includes:stuconnolly2010-09-177-404/+1809
| | | | | | | | | - The ability to easily index multiple columns - The ability to specify the storage type (HASH or BTREE) that should be used when available and permitted - The ability to specify a length prefix when indexing a specific column (required on TEXT columns) Requires lots of testing.
* • only some minor code cosmeticsBibiko2010-09-173-412/+413
|