aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Update background keepalive pings:rowanbeentje2010-09-031-11/+33
| | | | | | | - Fully lock the connection for background pings; this may slow down queries after connection disuse (when the keepalive is still active/blocked), but strengens thread safety to hopefully fix vio_delete crashes - Fix pthread_cancel use; previously pthread_cancel after a keepalive may have resulted in cancelling unrelated threads where the thread ID was reused This should increase stability and improve program consistency.
* • first preparations to support a CSV import into a new table (not yet ↵Bibiko2010-09-024-72/+787
| | | | | | | | executable) - changed order of target tables: New Table, Refresh List, separator, list of all names - cleaned code a bit * removed check for available tables in SPDataImport, now if no table in db the CSV Field Mapper opens in "New Table" mode
* • CSV Import Field mapperBibiko2010-09-021-1/+0
| | | | - make sure that after Refresh Table List the mapping table will be updated as well
* • corrected spelling of "First line contains fields names" to "First line ↵Bibiko2010-09-012-8/+24
| | | | contains field names"
* • Show/Copy Create Syntax now come up with all create syntaxes of selected ↵Bibiko2010-09-012-110/+111
| | | | | | | items • if Create Syntax is a PROC wrap the output by DELIMITER ;; etc. to simplify a copy&paste • merged code for copyCreateTableSyntax into showCreateTableSyntax distinguished by the sender (if sender == self) then copy otherwise show
* Remove an attempt to obtain a bool value from a var that is already one ↵stuconnolly2010-09-011-1/+1
| | | | resulting in a crash when attempting to remove an index. Fixes log: http://spbug.com/l/1007.
* • removed command to make the CustomQuery's table first responder after ↵Bibiko2010-09-011-1/+0
| | | | | | performing queries for now to avoid exceptions like in 1527 - not sure why, it seems to be a thread issue
* - Ensure previous outstanding performSelector: requests are cancelled to ↵rowanbeentje2010-09-011-0/+4
| | | | avoid calls on released objects; this addresses http://spbug.com/l/1408, http://spbug.com/l/254 and http://spbug.com/l/781
* • fixed AppleScript crash after calling 'open' without any parameterBibiko2010-08-312-10/+33
| | | | | | | | - this should fix the issues 108, 1398, 226 , 1157, 1473 • added AppleScript support for command 'print' - it prints the active view • renamed SP classes in sequel-pro.scriptSuite • AppleScript command 'make new document' opens a new window and connects to default automatically if set
* • fixed in field editing mode the editing of BINARY fieldsBibiko2010-08-312-4/+10
|
* - Add connection checks before uses of mysql_hex_string and ↵rowanbeentje2010-08-311-16/+51
| | | | mysql_real_escape_string (which require an active connection). This addresses http://spbug.com/l/54 .
* - Attempt more status checking before closing the MySQL connection, in an ↵rowanbeentje2010-08-303-3/+3
| | | | | | | attempt to further address http://spbug.com/l/13 - Update localisable strings
* - When a table content page reload loads no data, and so triggers a reload ↵rowanbeentje2010-08-301-0/+1
| | | | of the first page, the previous row count was not correctly reset, thus sometimes triggering an exception. This correctly resets the count, addressing http://spbug.com/l/558
* - Set pagination limit number formatter *off* lenient to allow editing ↵rowanbeentje2010-08-301-114/+494
| | | | formatted numbers (eg editing the default 1,000 to 2,000) without formatting characters such as commas being truncated
* • added some basic VIEW INFORMATION coming from information.schema.VIEWSBibiko2010-08-303-155/+212
|
* - Improve background thread reconnect interaction with the interface; if ↵rowanbeentje2010-08-291-3/+10
| | | | the application is in a modal state, the background thread waits. This improves interface behaviour on multiple SSH disconnections after sleep/wake (finishing Issue #798) and also disconnections while the interface is modally locked (eg editing text/blobs).
* • further improvements for in cell editing of view data in TableContent tablesBibiko2010-08-272-135/+138
| | | | | | | - simplified code - reduced number of queries for edit status - WHERE argument to identify first try to avoid using blob data for speed, if field is not identified with ignoring blob data then use blob data as well
* • further improvements for in cell editing in CustomQuery tablesBibiko2010-08-273-110/+108
| | | | | | | | - simplified code - reduced number of queries for edit status - WHERE argument to identify first try to avoid using blob data for speed, if field is not identified with ignoring blob data then use blob data as well • for TableContent fixed tooltip display - note: improvements as for CustomQuery follow soon
* • fixed issue that data in views weren't editable (copy&paste typo problem)Bibiko2010-08-261-0/+1
|
* • removed onMainThread for [Content/CustomTable makeFirstResponder] to ↵Bibiko2010-08-265-64/+111
| | | | | | | | | avoid the trampoline exceptions • unified error message while cell editing • in Custom Query table cell editing errors are displayed as tooltips and added these message if edit event comes from the keyboard • fixed: check edit status in Content Tables only for views to avoid unnecessary queries • used [SPCustomQuery fieldEditStatusForRow:andColumn:] consequently to simplify code
* If the user chooses to overwrite the output file(s) when performing an ↵stuconnolly2010-08-262-2/+11
| | | | export make sure compression and CSV and XML headers and re-enable/rewritten.
* Exporter:rowanbeentje2010-08-265-31/+62
| | | | | | - Enable alternating table lines in the export table view - this addresses Issue #797 - Reconnect GZIp & BZIP2 compression functionality (TODO: not currently working for file overwrites; to be discussed)
* Encoding changes and improvements, particularly to increase compatibility ↵rowanbeentje2010-08-2521-206/+351
| | | | | | | | | | | with extended characters in MySQL identifiers (names of dbs/tables/cols): - Move encoding queries and control into MCPKit, with newly cleaned-up methods, and switch a number of locations to using the new code. - Use UTF8 connections for many identifier-based queries (selecting and listing databases, tables, stored procs, table information). This fixes selection and creation of table and database names containing extended characters, also fixing exceptions and errors. - Improve UTF8 over Latin1 to correctly set the client character set encoding as well, fixing custom queries and edits; remove custom code in SPTableContent achieving the same thing in a single location. - Fix database encoding detection routines - Update localisable strings
* • added tooltip about non-editable while keyboard navigation and trying to ↵Bibiko2010-08-252-2/+33
| | | | | | modify a cell • in Custom Query table after field editor sheet dismissing preserve the the edited field selection
* • after editing in Custom Query table preserve the selected line even if ↵Bibiko2010-08-252-8/+14
| | | | the actual edited line due to new data will come up in another line
* • fixed several issues for in cell editing of Custom Query tables and view ↵Bibiko2010-08-254-87/+67
| | | | | | | | data in Content tables - now each cell can be selected via keyboard navigation regardless whether it's editable or not; only if the user tries to modify it then it will be checked if it's editable or not - for speed while navigation - fixed issue for view data editing to show blobs in editor sheet if user wants to modify it - Note: still work on progress
* • outsourced control:textView:doCommandBySelector: stuff to SPCopyTable ↵Bibiko2010-08-245-203/+358
| | | | | | | | | | since we need that for Content and Custom Query table; only class specific stuff like ESC trapping will handled in the actual class • enabled in cell editing for Custom Query tables - also added spreadsheet button to Custom Query status bar • fixed ESC trapping: F5 can be used for completion • simplified [SPCopyTable keyDown:] for trapping ENTER/RETURN key • some code cosmetics
* • in [SPCustomQuery tableSortCallback]Bibiko2010-08-241-7/+3
| | | | | - removed unnecessary header indicator image setting - set [[customQueryView onMainThread] setNeedsDisplay:YES] to ensure to display table rendering correctly after changing the sort order
* • added context menu for Copy, Copy with Header, Copy as SQL Insert to ↵Bibiko2010-08-243-4/+149
| | | | Custom Query table
* • introduced tri-state sort order for Content and Custom Query tablesBibiko2010-08-242-188/+242
| | | | | | | - by clicking a the same table header the sort will changed to desc, asc, no sort order, desc, asc, etc. • fixed sorting issue for Custom Query table - reset sort order status before executing a new custom query • code cosmetics: reduced file size for SPCustomQuery.m
* • Content Window cell editingBibiko2010-08-241-0/+6
| | | | - If enum field is edited RETURN selects the new value instead of saving the entire row
* • fixed memory leak in [SPDataAdditions ↵Bibiko2010-08-243-342/+341
| | | | | | | | | | shortStringRepresentationUsingEncoding] after simplifying the code • fixed NSAutoreleaseNoPool(): SPMainThreadTrampoline autoreleased with no pool in place - leak while canceling a print job - call [self endTask] BEFORE [pool drain] • in SPTableContent set the focus to table after editing a cell by the field editor sheet on main thread - this could fix exception 1481 • some code cosmetics: reduced file sizes
* • Table Content editing via keyboardBibiko2010-08-231-0/+12
| | | | | - disable ↑ and ↓ for jumping the next table cell if current cell is a enum field to allow to use the arrow keys for selecting an item from the list - Note: ?\018↩ handling has to be improved here! (coming soon)
* • changed TAB and SHIFT-TAB behaviour of Content Window tableBibiko2010-08-231-29/+98
| | | | | | | - now it selects any field (if it's editable for views) regardless whether the field is a blob - if user tries to edit a blob field the field editor sheet will occur for editing • after cancellation of cell editing in the Content Window table preserve the focus on the table • minor code cosmetics for editing of data coming from a view in Content Window
* • first preparations to allow in cell editing in Custom Query (not yet ↵Bibiko2010-08-224-172/+929
| | | | | | | | | | active) • view data editing - disable add/duplicate/remove row for views - first improvements for editing navigation via keyboard - after editing avoid relaodTable instead use loadTableValues - outsourced: (NSInteger)fieldEditStatusForRow:andColumn: since it will be used for keyboard editing navigation
* • moved changes done in r 2566 to tableViewSelectionDidChange: if no item ↵Bibiko2010-08-221-4/+12
| | | | in tablesList is selected to reset SP
* • after deleting of items in tablesList set selectedTableType to ↵Bibiko2010-08-221-2/+7
| | | | | | SPTableTypeNone and selectedTableName since the table will be deselectAll - fixes various updates like title bar etc. and avoid crashes/exceptions
* • view editingBibiko2010-08-221-11/+19
| | | | - if multipleLineEditingButton is set to on or field is a blob field allow to show the field data as non-editable fieldEditorSheet if field is not editable
* • view editingBibiko2010-08-221-3/+16
| | | | | - fixed: call endTask for the current progress spinner if while editing a field the data were changed meanwhile - fixed line breaking of some long tooltips
* • implemented the editing of views in Content WindowBibiko2010-08-212-2/+277
| | | | | | - the editing is field based as for Custom Query editing - shouldEditRow checks if the clicked field can be identified unambiguously - CAUTION: This must be tested heavily before releasing!! Esp. any kind of threading issues and progress spinner stuff for slower connections
* • overall replacement of:Bibiko2010-08-2014-191/+162
| | | | | | | | | [aString appendString:[NSString stringWithFormat:]] by [aString appendFormat:] since it's much more faster • first look at loop where several [aStr appendString:] occur to try to combine them into one appendString or appendFormat since the allocation of memory takes really time Note: I tested all my changes but we should test it further to be sure that I didn't a mistake!
* Fix various potential memory leaks and general warnings as a result of ↵stuconnolly2010-08-197-11/+17
| | | | static analysis.
* • made usage of SPBeginWaitingAlertSheet while closing a spf file for ↵Bibiko2010-08-194-16/+29
| | | | | | | readability of that spf file • suppress if a window with one tab will be closed that [... parentTabShouldClose] method will be called twice via closeTab: - this issue could be the reason for recent crashes/exception esp. of the NSNavigator (should be investigated further)
* • added SPBeginWaitingAlertSheet() routine which offers the chance to ↵Bibiko2010-08-195-51/+140
| | | | | | display an alert sheet which waits for the change in the didEndSelector method of a passed class NSInteger variable • applied the SPBeginWaitingAlertSheet routine to Pref > Editor's check for unsaved color themes and in SPCustomQuery's sheet about Stop/Continue/Run All if a query failed after executing "Run All"
* • added SPFileManagerAdditionsBibiko2010-08-198-6/+203
| | | | | | | | - [(NSString*)applicationSupportDirectoryForSubDirectory:error:] Return the application support folder of the current application for 'subDirectory'. If this folder doesn't exist it will be created. If 'subDirectory' == nil it only returns the application support folder of the current application. • added SPThemesSupportFolder constant
* Move SPCopyTable in Xcode's logical file structure.stuconnolly2010-08-191-2/+2
|
* Missing changes from r2554.stuconnolly2010-08-194-272/+254
|
* • fixed xcode project for commit 2554 to apply the renaming of ↵Bibiko2010-08-191-6/+6
| | | | CMCopyTable.* to the project
* Rename CMCopyTable to SPCopyTable.stuconnolly2010-08-198-16/+16
|
* • fixed issue if SP's theme support folder or saved theme file resp. was ↵Bibiko2010-08-191-0/+28
| | | | removed while SP's Editor Preferences window is open