| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
* Changed some NSLocalizedString() comments to be more descriptive - keep in mind that the comment is the only thing that can provide context here.
|
|
|
|
| |
selected
|
|
|
|
| |
log data storage to prevent race conditions. Should fix crash: http://spbug.com/l/1644
|
|
|
|
| |
application launches. Implements issue #814.
|
| |
|
|
|
|
|
|
|
| |
and preferences view. Fixes issue #807.
- Remove the default favourite indicator from the preferences view.
|
|
|
|
| |
conflicts with manual memory management on 10.5.8 on quit. This addresses http://spbug.com/728 , together with a number of recorded crashes ( http://spbug.com/l/190, http://spbug.com/l/1522 )
|
|
|
|
| |
changes in r2682.
|
|
|
|
|
|
|
|
| |
- Foreground and keepalive pings now use the same code, which has been tidied and improved
- Global variables are no longer incorrectly shared across multiple instances
- If a ping thread blocks in a state where pthread_cancel no longer functions, the connection is assumed to have failed (network issues etc)
This should further improve MySQL crashes linked to pings, and will hopefully address Issue #830. Also update localizable strings
|
|
|
|
| |
syntaxes for multiple tables to '--' from '#'. Implements issue #842.
|
|
|
|
| |
- this fixes issue 841
|
| |
|
|
|
|
| |
(in the advanced view) which was added in MySQL 5.1.10.
|
|
|
|
|
|
|
|
| |
the CREATE SYNTAX will be parsed twice under certain circumstances which led to this issue
- introduced a isWorking mechanism to SPTableData; while SPTableData is updating its cache (ie the CREATE SYNTAX is being parsed) each request for values will return nil or an empty array; the caller is responsible to decide what to do
• various commenting stuff
• various speed improvements
|
|
|
|
| |
database changes was not required (functionality introduced in r2670). Fixes issue #835.
|
|
|
|
|
|
| |
the focus
- corrected in tableViewSelectionDidChange: the check whether the selection was changed or not
|
| |
|
|
|
|
|
|
|
| |
TRIGGER query due to possible localizations, instead make usage of selected indices
- fixes i829
- some code cleaning and commenting stuff
|
|
|
|
|
|
| |
- started general cell editing validation due to currently set type and other parameters to help user while setting up/changing fields (must be tested)
- set BINARY checked if collation ends with _bin since string fields stores that information in that way for convenience
- added TINYTEXT as type suggestion
|
|
|
|
| |
same string.
|
|
|
|
| |
- minor commenting stuff
|
|
|
|
| |
there're instances where one has to reload the table explicitly
|
| |
|
|
|
|
| |
- in addition alert the user that this clause was empty to avoid confusion of filtered result set
|
|
|
|
|
|
|
|
|
|
|
| |
- added at the end of [self loadTableValues] an alert if loading failed
• SPContentFilterManager
- removed any key bindings for hopefully getting rid of some "mutating method sent to immutable object" exceptions/crashes [1479, 1372, 1310, 295, 1227, 692, 149]
- better handling of ESC to cancel the name in-cell editing in table
- improved validations
- some general code improvements
- added/changed comments
|
|
|
|
|
| |
- avoid replacing of % by %% for user-defined content filters if no argument is required
• minor commenting stuff and code cleaning
|
|
|
|
|
|
|
|
|
|
|
| |
requiresLength since they are still in use
• fixed: if new field was added store the the underlying NSDictionary not only the field name
• fixed in [addIndex:]: init indexedFields with a mutable copy
- this fixes all issue for "mutating method sent to immutable object" of SPIndexController like i1609
• fixed "Add" Button validation
• fixed display of "Size" column validation
• code cosmetics
|
|
|
|
|
|
|
| |
pings. This returns to an old approach by attempting to use interrupt signals to force a hung network read to close; however, the signal is now sent by the watchdog thread in a thread-safe fashion to specifically target the locking thread. If this approach works we'll probably consolidate the ping code to use it throughout.
- Update localizable strings
|
|
|
|
|
|
|
| |
list to accommodate cases where additional tables have been added to the database by external applications. If so inform the user of this, giving them the choice of whether or not to continue with the export.
- Update Localizable.strings
|
|
|
|
| |
is currently being edited and can't been saved cleanly. Addresses at least http://spbug.com/l/735 .
|
|
|
|
|
|
|
| |
had crept into the source, replacing with the correct [NSWindow makeFirstResponder:NSTableView]. This fixes a number of exceptions.
- Update localisable strings.
|
| |
|
|
|
|
|
|
|
|
| |
- Fix an exception caused when cancelling adding an index with the advanced options view open.
- Move 'Cancel and 'Add' buttons to be inline with index type and name controls.
Both found/suggested by Rowan.
|
|
|
|
| |
addresses http://spbug.com/l/1269 and possibly improves the vio_delete crashes
|
|
|
|
|
|
|
| |
when there is only one indexed field.
- When cancelling adding a new index reset the indexed columns.
|
|
|
|
|
|
|
|
|
| |
length specified and the advanced view open.
- Fix an exception when adding the same indexed field when creating a new index.
Both found by Max. Thanks Max!
|
| |
|
|
|
|
|
|
|
|
|
| |
- The ability to easily index multiple columns
- The ability to specify the storage type (HASH or BTREE) that should be used when available and permitted
- The ability to specify a length prefix when indexing a specific column (required on TEXT columns)
Requires lots of testing.
|
| |
|
| |
|
|
|
|
| |
• Field Editor Sheet field name label also displays NOT NULL if set
|
| |
|
|
|
|
|
|
|
|
|
|
| |
single function in each class
- Tweak NSTableView subclasses to catch presses of the Escape key and ask the class to abort row editing. This makes Esc key behaviour much more consistent, and allows cancelling/reverting edits made via the mouse (eg checkboxes, dropdowns, enums), or after the cell editing has finished but the row is still selected.
- Remove debug
- Update localisable strings
|
| |
|
|
|
|
|
| |
- Shift Left now also considers leading SPACES (issue 822)
- changed approach for Shift Right/Left of a selection: instead to iterate through all lines do a simple find&replace which is much more faster (4x) and additionally it improves the undo behaviour
|
|
|
|
|
|
| |
allowed to type in
• enabled max length and BIT field validation for CustomQuery
|
| |
|
|
|
|
| |
- Slightly limited in that the addTabButton's target and action must be set for it to work.
|
|
|
|
|
|
| |
• re-enabled length checking while editing in FieldEditorSheet
• FieldEditorSheet now shows field type declaration
• some preparations for BINARY editing in FieldEditorSheet
|
| |
|