diff options
Diffstat (limited to 'Source')
29 files changed, 2533 insertions, 2006 deletions
diff --git a/Source/SPAppController.m b/Source/SPAppController.m index 63011789..f51cfc13 100644 --- a/Source/SPAppController.m +++ b/Source/SPAppController.m @@ -80,7 +80,7 @@ [[NSUserDefaults standardUserDefaults] registerDefaults:[NSDictionary dictionaryWithContentsOfFile:[[NSBundle mainBundle] pathForResource:@"PreferenceDefaults" ofType:@"plist"]]]; // Migrate old connection favorites to the app's support directory (only uncomment when ready) - //SPMigrateConnectionFavoritesData(); + SPMigrateConnectionFavoritesData(); } /** diff --git a/Source/SPConnectionController.h b/Source/SPConnectionController.h index 86167a91..2cd4d170 100644 --- a/Source/SPConnectionController.h +++ b/Source/SPConnectionController.h @@ -26,9 +26,15 @@ #import <MCPKit/MCPKit.h> #import "SPConnectionControllerDelegateProtocol.h" -#import "SPFavoritesOutlineView.h" -@class SPDatabaseDocument, SPKeychain, SPSSHTunnel, BWAnchoredButtonBar, SPFavoriteNode; +@class SPDatabaseDocument, + SPFavoritesController, + SPKeychain, + SPSSHTunnel, + SPTreeNode, + SPFavoriteNode, + SPFavoritesOutlineView, + BWAnchoredButtonBar; @interface NSObject (BWAnchoredButtonBar) @@ -36,28 +42,20 @@ @end -@interface SPFlippedView : NSView - -- (BOOL)isFlipped; - -@end - @interface SPConnectionController : NSObject { id <SPConnectionControllerDelegateProtocol> delegate; - SPDatabaseDocument *tableDocument; - NSView *databaseConnectionSuperview; - NSSplitView *databaseConnectionView; - SPKeychain *keychain; - NSUserDefaults *prefs; - NSMutableArray *favorites; + SPDatabaseDocument *dbDocument; SPSSHTunnel *sshTunnel; + SPKeychain *keychain; + MCPConnection *mySQLConnection; - BOOL automaticFavoriteSelection; - BOOL cancellingConnection; - BOOL isConnecting; + + NSView *databaseConnectionSuperview; + NSSplitView *databaseConnectionView; + // Standard details NSInteger previousType; NSInteger type; NSString *name; @@ -67,20 +65,23 @@ NSString *database; NSString *socket; NSString *port; - int useSSL; - int sslKeyFileLocationEnabled; + + // SSL details + NSInteger useSSL; + NSInteger sslKeyFileLocationEnabled; NSString *sslKeyFileLocation; - int sslCertificateFileLocationEnabled; + NSInteger sslCertificateFileLocationEnabled; NSString *sslCertificateFileLocation; - int sslCACertFileLocationEnabled; + NSInteger sslCACertFileLocationEnabled; NSString *sslCACertFileLocation; + + // SSH details NSString *sshHost; NSString *sshUser; NSString *sshPassword; - int sshKeyLocationEnabled; + NSInteger sshKeyLocationEnabled; NSString *sshKeyLocation; NSString *sshPort; - @private NSString *favoritesPBoardType; NSString *connectionKeychainItemName; NSString *connectionKeychainItemAccount; @@ -92,8 +93,9 @@ IBOutlet NSView *connectionView; IBOutlet NSSplitView *connectionSplitView; IBOutlet NSScrollView *connectionDetailsScrollView; + IBOutlet NSTextField *connectionInstructionsTextField; IBOutlet BWAnchoredButtonBar *connectionSplitViewButtonBar; - IBOutlet SPFavoritesOutlineView *favoritesTable; + IBOutlet SPFavoritesOutlineView *favoritesOutlineView; IBOutlet NSWindow *errorDetailWindow; IBOutlet NSTextView *errorDetailText; @@ -109,8 +111,14 @@ IBOutlet NSView *sslCertificateLocationHelp; IBOutlet NSView *sslCACertLocationHelp; + IBOutlet NSTextField *standardNameField; + IBOutlet NSTextField *sshNameField; + IBOutlet NSTextField *socketNameField; IBOutlet NSTextField *standardSQLHostField; IBOutlet NSTextField *sshSQLHostField; + IBOutlet NSTextField *standardUserField; + IBOutlet NSTextField *socketUserField; + IBOutlet NSTextField *sshUserField; IBOutlet NSSecureTextField *standardPasswordField; IBOutlet NSSecureTextField *socketPasswordField; IBOutlet NSSecureTextField *sshPasswordField; @@ -130,12 +138,20 @@ IBOutlet NSTextField *progressIndicatorText; IBOutlet NSMenuItem *favoritesSortByMenuItem; + BOOL isConnecting; + BOOL cancellingConnection; BOOL reverseFavoritesSort; BOOL mySQLConnectionCancelled; + BOOL automaticFavoriteSelection; + BOOL favoriteNameFieldWasTouched; - SPFavoritesSortItem previousSortItem, currentSortItem; + NSImage *folderImage; + NSUserDefaults *prefs; - SPFavoriteNode *favoritesRoot; + SPTreeNode *favoritesRoot; + SPFavoriteNode *currentFavorite; + SPFavoritesController *favoritesController; + SPFavoritesSortItem previousSortItem, currentSortItem; } @property (readwrite, assign) id <SPConnectionControllerDelegateProtocol> delegate; @@ -147,17 +163,17 @@ @property (readwrite, retain) NSString *database; @property (readwrite, retain) NSString *socket; @property (readwrite, retain) NSString *port; -@property (readwrite, assign) int useSSL; -@property (readwrite, assign) int sslKeyFileLocationEnabled; +@property (readwrite, assign) NSInteger useSSL; +@property (readwrite, assign) NSInteger sslKeyFileLocationEnabled; @property (readwrite, retain) NSString *sslKeyFileLocation; -@property (readwrite, assign) int sslCertificateFileLocationEnabled; +@property (readwrite, assign) NSInteger sslCertificateFileLocationEnabled; @property (readwrite, retain) NSString *sslCertificateFileLocation; -@property (readwrite, assign) int sslCACertFileLocationEnabled; +@property (readwrite, assign) NSInteger sslCACertFileLocationEnabled; @property (readwrite, retain) NSString *sslCACertFileLocation; @property (readwrite, retain) NSString *sshHost; @property (readwrite, retain) NSString *sshUser; @property (readwrite, retain) NSString *sshPassword; -@property (readwrite, assign) int sshKeyLocationEnabled; +@property (readwrite, assign) NSInteger sshKeyLocationEnabled; @property (readwrite, retain) NSString *sshKeyLocation; @property (readwrite, retain) NSString *sshPort; @@ -169,36 +185,38 @@ @property (readonly, assign) BOOL isConnecting; @property (readonly, assign) NSString *favoritesPBoardType; -- (id)initWithDocument:(SPDatabaseDocument *)theTableDocument; +- (id)initWithDocument:(SPDatabaseDocument *)document; // Connection processes - (IBAction)initiateConnection:(id)sender; - (IBAction)cancelMySQLConnection:(id)sender; -- (void)initiateSSHTunnelConnection; -- (void)sshTunnelCallback:(SPSSHTunnel *)theTunnel; -- (void)initiateMySQLConnection; -- (void)cancelConnection; -- (void)failConnectionWithTitle:(NSString *)theTitle errorMessage:(NSString *)theErrorMessage detail:(NSString *)errorDetail; -- (void)addConnectionToDocument; // Interface interaction +- (IBAction)nodeDoubleClicked:(id)sender; - (IBAction)chooseKeyLocation:(id)sender; -- (IBAction)editFavorites:(id)sender; - (IBAction)showHelp:(id)sender; - (IBAction)updateSSLInterface:(id)sender; -- (void)resizeTabViewToConnectionType:(NSUInteger)theType animating:(BOOL)animate; - (IBAction)sortFavorites:(id)sender; - (IBAction)reverseSortFavorites:(id)sender; -// Connection details interaction -- (BOOL)checkHost; +- (void)resizeTabViewToConnectionType:(NSUInteger)theType animating:(BOOL)animate; // Favorites interaction -- (void)updateFavorites; - (void)updateFavoriteSelection:(id)sender; -- (id)selectedFavorite; -- (IBAction)addFavorite:(id)sender; +- (NSMutableDictionary *)selectedFavorite; +- (SPTreeNode *)selectedFavoriteNode; +- (NSArray *)selectedFavoriteNodes; -- (void)scrollViewFrameChanged:(NSNotification *)aNotification; +- (IBAction)addFavorite:(id)sender; +- (IBAction)addFavoriteUsingCurrentDetails:(id)sender; +- (IBAction)addGroup:(id)sender; +- (IBAction)removeNode:(id)sender; +- (IBAction)duplicateFavorite:(id)sender; +- (IBAction)renameFavorite:(id)sender; +- (IBAction)makeSelectedFavoriteDefault:(id)sender; + +// Import/export favorites +- (IBAction)importFavorites:(id)sender; +- (IBAction)exportFavorites:(id)sender; @end diff --git a/Source/SPConnectionController.m b/Source/SPConnectionController.m index aaff9687..f7a09471 100644 --- a/Source/SPConnectionController.m +++ b/Source/SPConnectionController.m @@ -32,17 +32,32 @@ #import "SPAlertSheets.h" #import "SPKeychain.h" #import "SPSSHTunnel.h" -#import "SPFavoriteNode.h" #import "SPTableTextFieldCell.h" +#import "SPFavoritesController.h" +#import "SPFavoriteNode.h" + +// Constants +static const NSString *SPRemoveNode = @"RemoveNode"; +static const NSString *SPImportFavorites = @"ImportFavorites"; +static const NSString *SPExportFavorites = @"ExportFavorites"; +static const NSString *SPExportFavoritesFilename = @"SequelProFavorites.plist"; @interface SPConnectionController (PrivateAPI) +- (BOOL)_checkHost; - (void)_sortFavorites; -- (void)_buildFavoritesTree; +- (void)_favoriteTypeDidChange; +- (void)_reloadFavoritesViewData; - (void)_restoreConnectionInterface; - (void)_mySQLConnectionEstablished; +- (void)_selectNode:(SPTreeNode *)node; - (void)_initiateMySQLConnectionInBackground; +- (NSNumber *)_createNewFavoriteID; +- (SPTreeNode *)_favoriteNodeForFavoriteID:(NSInteger)favoriteID; + +- (void)_updateFavoritePasswordsFromField:(NSControl *)control; + @end @implementation SPConnectionController @@ -83,124 +98,145 @@ * Initialise the connection controller, linking it to the * parent document and setting up the parent window. */ -- (id) initWithDocument:(SPDatabaseDocument *)theTableDocument +- (id)initWithDocument:(SPDatabaseDocument *)document { if (self = [super init]) { - tableDocument = theTableDocument; - databaseConnectionSuperview = [tableDocument databaseView]; - databaseConnectionView = [tableDocument valueForKey:@"contentViewSplitter"]; + + // Weak reference + dbDocument = document; + + databaseConnectionSuperview = [dbDocument databaseView]; + databaseConnectionView = [dbDocument valueForKey:@"contentViewSplitter"]; + + // Keychain references connectionKeychainItemName = nil; connectionKeychainItemAccount = nil; connectionSSHKeychainItemName = nil; connectionSSHKeychainItemAccount = nil; - mySQLConnection = nil; + sshTunnel = nil; - cancellingConnection = NO; + mySQLConnection = nil; isConnecting = NO; + cancellingConnection = NO; mySQLConnectionCancelled = NO; - favoritesPBoardType = @"FavoritesPBoardType"; - + + favoriteNameFieldWasTouched = YES; + // Load the connection nib, keeping references to the top-level objects for later release nibObjectsToRelease = [[NSMutableArray alloc] init]; NSArray *connectionViewTopLevelObjects = nil; NSNib *nibLoader = [[NSNib alloc] initWithNibNamed:@"ConnectionView" bundle:[NSBundle mainBundle]]; + [nibLoader instantiateNibWithOwner:self topLevelObjects:&connectionViewTopLevelObjects]; [nibObjectsToRelease addObjectsFromArray:connectionViewTopLevelObjects]; [nibLoader release]; - + // Hide the main view and position and display the connection view [databaseConnectionView setHidden:YES]; [connectionView setFrame:[databaseConnectionView frame]]; - [databaseConnectionSuperview addSubview:connectionView]; - [connectionSplitView setPosition:[[tableDocument valueForKey:@"dbTablesTableView"] frame].size.width-6 ofDividerAtIndex:0]; + [databaseConnectionSuperview addSubview:connectionView]; + [connectionSplitView setPosition:[[dbDocument valueForKey:@"dbTablesTableView"] frame].size.width-6 ofDividerAtIndex:0]; [connectionSplitViewButtonBar setSplitViewDelegate:self]; + [[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(scrollViewFrameChanged:) name:NSViewFrameDidChangeNotification object:nil]; - + + // Generic folder image for use in the outline view's groups + folderImage = [[[NSWorkspace sharedWorkspace] iconForFileType:NSFileTypeForHFSTypeCode(kGenericFolderIcon)] retain]; + + [folderImage setSize:NSMakeSize(16, 16)]; + // Set up a keychain instance and preferences reference, and create the initial favorites list keychain = [[SPKeychain alloc] init]; prefs = [[NSUserDefaults standardUserDefaults] retain]; - - favorites = nil; - - // Load favorites - [self updateFavorites]; - - // Expand the favorites heading - [favoritesTable expandItem:[[favoritesRoot nodeChildren] objectAtIndex:0]]; - - // Register an observer for changes within the favorites - [prefs addObserver:self forKeyPath:SPFavorites options:NSKeyValueObservingOptionNew context:NULL]; - - // Set sort items - currentSortItem = [prefs integerForKey:SPFavoritesSortedBy]; - reverseFavoritesSort = [prefs boolForKey:SPFavoritesSortedInReverse]; - - // Register double click for the favorites view (double click favorite to connect) - [favoritesTable setTarget:self]; - [favoritesTable registerForDraggedTypes:[NSArray arrayWithObject:favoritesPBoardType]]; - [favoritesTable setDraggingSourceOperationMask:NSDragOperationMove forLocal:YES]; - + + // Create a reference to the favorites controller, forcing the data to be loaded from disk and the + // tree constructor. + favoritesController = [SPFavoritesController sharedFavoritesController]; + + // Tree reference + favoritesRoot = [favoritesController favoritesTree]; + + // Update the UI + [self _reloadFavoritesViewData]; + + // Set sort items + currentSortItem = [prefs integerForKey:SPFavoritesSortedBy]; + reverseFavoritesSort = [prefs boolForKey:SPFavoritesSortedInReverse]; + + // Register double click action for the favorites outline view (double click favorite to connect) + [favoritesOutlineView setTarget:self]; + [favoritesOutlineView setDoubleAction:@selector(nodeDoubleClicked:)]; + [favoritesOutlineView registerForDraggedTypes:[NSArray arrayWithObject:SPFavoritesPasteboardDragType]]; + [favoritesOutlineView setDraggingSourceOperationMask:NSDragOperationMove forLocal:YES]; + + // Registered to be notified of changes to connection information + [self addObserver:self forKeyPath:SPFavoriteNameKey options:(NSKeyValueObservingOptionOld | NSKeyValueObservingOptionNew) context:NULL]; + [self addObserver:self forKeyPath:SPFavoriteHostKey options:(NSKeyValueObservingOptionOld | NSKeyValueObservingOptionNew) context:NULL]; + [self addObserver:self forKeyPath:SPFavoriteUserKey options:(NSKeyValueObservingOptionOld | NSKeyValueObservingOptionNew) context:NULL]; + [self addObserver:self forKeyPath:SPFavoriteDatabaseKey options:(NSKeyValueObservingOptionOld | NSKeyValueObservingOptionNew) context:NULL]; + [self addObserver:self forKeyPath:SPFavoriteSocketKey options:(NSKeyValueObservingOptionOld | NSKeyValueObservingOptionNew) context:NULL]; + [self addObserver:self forKeyPath:SPFavoritePortKey options:(NSKeyValueObservingOptionOld | NSKeyValueObservingOptionNew) context:NULL]; + [self addObserver:self forKeyPath:SPFavoriteUseSSLKey options:(NSKeyValueObservingOptionOld | NSKeyValueObservingOptionNew) context:NULL]; + [self addObserver:self forKeyPath:SPFavoriteSSHHostKey options:(NSKeyValueObservingOptionOld | NSKeyValueObservingOptionNew) context:NULL]; + [self addObserver:self forKeyPath:SPFavoriteSSHUserKey options:(NSKeyValueObservingOptionOld | NSKeyValueObservingOptionNew) context:NULL]; + [self addObserver:self forKeyPath:SPFavoriteSSHPortKey options:(NSKeyValueObservingOptionOld | NSKeyValueObservingOptionNew) context:NULL]; + [self addObserver:self forKeyPath:SPFavoriteSSHKeyLocationEnabledKey options:(NSKeyValueObservingOptionOld | NSKeyValueObservingOptionNew) context:NULL]; + [self addObserver:self forKeyPath:SPFavoriteSSHKeyLocationKey options:(NSKeyValueObservingOptionOld | NSKeyValueObservingOptionNew) context:NULL]; + [self addObserver:self forKeyPath:SPFavoriteSSLKeyFileLocationEnabledKey options:(NSKeyValueObservingOptionOld | NSKeyValueObservingOptionNew) context:NULL]; + [self addObserver:self forKeyPath:SPFavoriteSSLKeyFileLocationKey options:(NSKeyValueObservingOptionOld | NSKeyValueObservingOptionNew) context:NULL]; + [self addObserver:self forKeyPath:SPFavoriteSSLCertificateFileLocationEnabledKey options:(NSKeyValueObservingOptionOld | NSKeyValueObservingOptionNew) context:NULL]; + [self addObserver:self forKeyPath:SPFavoriteSSLCertificateFileLocationKey options:(NSKeyValueObservingOptionOld | NSKeyValueObservingOptionNew) context:NULL]; + [self addObserver:self forKeyPath:SPFavoriteSSLCACertFileLocationEnabledKey options:(NSKeyValueObservingOptionOld | NSKeyValueObservingOptionNew) context:NULL]; + [self addObserver:self forKeyPath:SPFavoriteSSLCACertFileLocationKey options:(NSKeyValueObservingOptionOld | NSKeyValueObservingOptionNew) context:NULL]; + // Sort the favourites to match prefs and select the appropriate row - if a valid sort option is selected - if (currentSortItem > -1) [self _sortFavorites]; - - NSInteger tableRow = [prefs integerForKey:[prefs boolForKey:SPSelectLastFavoriteUsed] ? SPLastFavoriteIndex : SPDefaultFavorite]; - - if (tableRow < [favorites count]) { - previousType = [[[favorites objectAtIndex:tableRow] objectForKey:SPFavoriteTypeKey] integerValue]; - [favoritesTable selectRowIndexes:[NSIndexSet indexSetWithIndex:(tableRow + 1)] byExtendingSelection:NO]; - [self resizeTabViewToConnectionType:[[[favorites objectAtIndex:tableRow] objectForKey:SPFavoriteTypeKey] integerValue] animating:NO]; - [favoritesTable scrollRowToVisible:[favoritesTable selectedRow]]; - } + // TODO: Fix me, sorting currently does not work in the new outline view + //if (currentSortItem > -1) [self _sortFavorites]; + + SPTreeNode *favorite = [self _favoriteNodeForFavoriteID:[prefs integerForKey:([prefs boolForKey:SPSelectLastFavoriteUsed]) ? SPLastFavoriteID : SPDefaultFavorite]]; + + if (favorite) { + + NSNumber *typeNumber = [[[favorite representedObject] nodeFavorite] objectForKey:SPFavoriteTypeKey]; + + previousType = (typeNumber) ? [typeNumber integerValue] : SPTCPIPConnection; + + [self _selectNode:favorite]; + + [self resizeTabViewToConnectionType:[[[[favorite representedObject] nodeFavorite] objectForKey:SPFavoriteTypeKey] integerValue] animating:NO]; + + [favoritesOutlineView scrollRowToVisible:[favoritesOutlineView selectedRow]]; + } else { previousType = SPTCPIPConnection; + [self resizeTabViewToConnectionType:SPTCPIPConnection animating:NO]; } } - + return self; } -- (void) dealloc -{ - [prefs removeObserver:self forKeyPath:SPFavorites]; - [[NSNotificationCenter defaultCenter] removeObserver:self]; - [keychain release]; - [prefs release]; - - for (id retainedObject in nibObjectsToRelease) [retainedObject release]; - [nibObjectsToRelease release]; - - if (favorites) [favorites release]; - if (mySQLConnection) [mySQLConnection release]; - if (sshTunnel) [sshTunnel setConnectionStateChangeSelector:nil delegate:nil], [sshTunnel disconnect], [sshTunnel release]; - if (connectionKeychainItemName) [connectionKeychainItemName release]; - if (connectionKeychainItemAccount) [connectionKeychainItemAccount release]; - if (connectionSSHKeychainItemName) [connectionSSHKeychainItemName release]; - if (connectionSSHKeychainItemAccount) [connectionSSHKeychainItemAccount release]; - - [super dealloc]; -} - #pragma mark - #pragma mark Connection processes -/* +/** * Starts the connection process; invoked when user hits the connect button * or double-clicks on a favourite. * Error-checks fields as required, and triggers connection of MySQL or any * connection proxies in use. */ - (IBAction)initiateConnection:(id)sender -{ +{ // Ensure that host is not empty if this is a TCP/IP or SSH connection if (([self type] == SPTCPIPConnection || [self type] == SPSSHTunnelConnection) && ![[self host] length]) { - SPBeginAlertSheet(NSLocalizedString(@"Insufficient connection details", @"insufficient details message"), NSLocalizedString(@"OK", @"OK button"), nil, nil, [tableDocument parentWindow], self, nil, nil, NSLocalizedString(@"Insufficient details provided to establish a connection. Please enter at least the hostname.", @"insufficient details informative message")); + SPBeginAlertSheet(NSLocalizedString(@"Insufficient connection details", @"insufficient details message"), NSLocalizedString(@"OK", @"OK button"), nil, nil, [dbDocument parentWindow], self, nil, nil, NSLocalizedString(@"Insufficient details provided to establish a connection. Please enter at least the hostname.", @"insufficient details informative message")); return; } - + // If SSH is enabled, ensure that the SSH host is not nil if ([self type] == SPSSHTunnelConnection && ![[self sshHost] length]) { - SPBeginAlertSheet(NSLocalizedString(@"Insufficient connection details", @"insufficient details message"), NSLocalizedString(@"OK", @"OK button"), nil, nil, [tableDocument parentWindow], self, nil, nil, NSLocalizedString(@"Insufficient details provided to establish a connection. Please enter the hostname for the SSH Tunnel, or disable the SSH Tunnel.", @"insufficient SSH tunnel details informative message")); + SPBeginAlertSheet(NSLocalizedString(@"Insufficient connection details", @"insufficient details message"), NSLocalizedString(@"OK", @"OK button"), nil, nil, [dbDocument parentWindow], self, nil, nil, NSLocalizedString(@"Insufficient details provided to establish a connection. Please enter the hostname for the SSH Tunnel, or disable the SSH Tunnel.", @"insufficient SSH tunnel details informative message")); return; } @@ -208,13 +244,13 @@ if ([self type] == SPSSHTunnelConnection && sshKeyLocationEnabled && sshKeyLocation) { if (![[NSFileManager defaultManager] fileExistsAtPath:[sshKeyLocation stringByExpandingTildeInPath]]) { [self setSshKeyLocationEnabled:NSOffState]; - SPBeginAlertSheet(NSLocalizedString(@"SSH Key not found", @"SSH key check error"), NSLocalizedString(@"OK", @"OK button"), nil, nil, [tableDocument parentWindow], self, nil, nil, NSLocalizedString(@"A SSH key location was specified, but no file was found in the specified location. Please re-select the key and try again.", @"SSH key not found message")); + SPBeginAlertSheet(NSLocalizedString(@"SSH Key not found", @"SSH key check error"), NSLocalizedString(@"OK", @"OK button"), nil, nil, [dbDocument parentWindow], self, nil, nil, NSLocalizedString(@"A SSH key location was specified, but no file was found in the specified location. Please re-select the key and try again.", @"SSH key not found message")); return; } } // Ensure that a socket connection is not inadvertently used - if (![self checkHost]) return; + if (![self _checkHost]) return; // If SSL keys have been supplied, verify they exist if (([self type] == SPTCPIPConnection || [self type] == SPSocketConnection) && [self useSSL]) { @@ -223,7 +259,7 @@ { [self setSslKeyFileLocationEnabled:NSOffState]; [self setSslKeyFileLocation:nil]; - SPBeginAlertSheet(NSLocalizedString(@"SSL Key File not found", @"SSL key file check error"), NSLocalizedString(@"OK", @"OK button"), nil, nil, [tableDocument parentWindow], self, nil, nil, NSLocalizedString(@"A SSL key file location was specified, but no file was found in the specified location. Please re-select the key file and try again.", @"SSL key file not found message")); + SPBeginAlertSheet(NSLocalizedString(@"SSL Key File not found", @"SSL key file check error"), NSLocalizedString(@"OK", @"OK button"), nil, nil, [dbDocument parentWindow], self, nil, nil, NSLocalizedString(@"A SSL key file location was specified, but no file was found in the specified location. Please re-select the key file and try again.", @"SSL key file not found message")); return; } if (sslCertificateFileLocationEnabled && sslCertificateFileLocation @@ -231,7 +267,7 @@ { [self setSslCertificateFileLocationEnabled:NSOffState]; [self setSslCertificateFileLocation:nil]; - SPBeginAlertSheet(NSLocalizedString(@"SSL Certificate File not found", @"SSL certificate file check error"), NSLocalizedString(@"OK", @"OK button"), nil, nil, [tableDocument parentWindow], self, nil, nil, NSLocalizedString(@"A SSL certificate location was specified, but no file was found in the specified location. Please re-select the certificate and try again.", @"SSL certificate file not found message")); + SPBeginAlertSheet(NSLocalizedString(@"SSL Certificate File not found", @"SSL certificate file check error"), NSLocalizedString(@"OK", @"OK button"), nil, nil, [dbDocument parentWindow], self, nil, nil, NSLocalizedString(@"A SSL certificate location was specified, but no file was found in the specified location. Please re-select the certificate and try again.", @"SSL certificate file not found message")); return; } if (sslCACertFileLocationEnabled && sslCACertFileLocation @@ -239,7 +275,7 @@ { [self setSslCACertFileLocationEnabled:NSOffState]; [self setSslCACertFileLocation:nil]; - SPBeginAlertSheet(NSLocalizedString(@"SSL Certificate Authority File not found", @"SSL certificate authority file check error"), NSLocalizedString(@"OK", @"OK button"), nil, nil, [tableDocument parentWindow], self, nil, nil, NSLocalizedString(@"A SSL Certificate Authority certificate location was specified, but no file was found in the specified location. Please re-select the Certificate Authority certificate and try again.", @"SSL CA certificate file not found message")); + SPBeginAlertSheet(NSLocalizedString(@"SSL Certificate Authority File not found", @"SSL certificate authority file check error"), NSLocalizedString(@"OK", @"OK button"), nil, nil, [dbDocument parentWindow], self, nil, nil, NSLocalizedString(@"A SSL Certificate Authority certificate location was specified, but no file was found in the specified location. Please re-select the Certificate Authority certificate and try again.", @"SSL CA certificate file not found message")); return; } } @@ -247,7 +283,7 @@ // Basic details have validated - start the connection process animating isConnecting = YES; cancellingConnection = NO; - + [addToFavoritesButton setHidden:YES]; [addToFavoritesButton display]; [helpButton setHidden:YES]; @@ -258,9 +294,9 @@ [progressIndicator display]; [progressIndicatorText setHidden:NO]; [progressIndicatorText display]; - + // Start the current tab's progress indicator - [tableDocument setIsProcessing:YES]; + [dbDocument setIsProcessing:YES]; // If the password(s) are marked as having been originally sourced from a keychain, check whether they // have been changed or not; if not, leave the mark in place and remove the password from the field @@ -271,11 +307,13 @@ [[standardPasswordField undoManager] removeAllActionsWithTarget:standardPasswordField]; [[socketPasswordField undoManager] removeAllActionsWithTarget:socketPasswordField]; [[sshPasswordField undoManager] removeAllActionsWithTarget:sshPasswordField]; - } else { + } + else { [connectionKeychainItemName release], connectionKeychainItemName = nil; [connectionKeychainItemAccount release], connectionKeychainItemAccount = nil; } } + if (connectionSSHKeychainItemName) { if ([[keychain getPasswordForName:connectionSSHKeychainItemName account:connectionSSHKeychainItemAccount] isEqualToString:[self sshPassword]]) { [self setSshPassword:[[NSString string] stringByPaddingToLength:[[self sshPassword] length] withString:@"sp" startingAtIndex:0]]; @@ -285,22 +323,22 @@ [connectionSSHKeychainItemAccount release], connectionSSHKeychainItemAccount = nil; } } - + // Inform the delegate that we are starting the connection process if (delegate && [delegate respondsToSelector:@selector(connectionControllerInitiatingConnection:)]) { [delegate connectionControllerInitiatingConnection:self]; } - + // Trim whitespace and newlines from the host field before attempting to connect [self setHost:[[self host] stringByTrimmingCharactersInSet:[NSCharacterSet whitespaceAndNewlineCharacterSet]]]; - + // Initiate the SSH connection process for tunnels if ([self type] == SPSSHTunnelConnection) { [self performSelector:@selector(initiateSSHTunnelConnection) withObject:nil afterDelay:0.0]; return; } - - // ...or start the MySQL connection process directly + + // ...or start the MySQL connection process directly [self performSelector:@selector(initiateMySQLConnection) withObject:nil afterDelay:0.0]; } @@ -314,229 +352,39 @@ - (IBAction)cancelMySQLConnection:(id)sender { [connectButton setEnabled:NO]; - + [progressIndicatorText setStringValue:NSLocalizedString(@"Cancelling...", @"cancelling task status message")]; [progressIndicatorText display]; - + mySQLConnectionCancelled = YES; } -/* - * Initiate the SSH connection process. - * This should only be called as part of initiateConnection:, and will indirectly - * call initiateMySQLConnection if it's successful. - */ -- (void)initiateSSHTunnelConnection -{ - [progressIndicatorText setStringValue:NSLocalizedString(@"SSH connecting...", @"SSH connecting very short status message")]; - [progressIndicatorText display]; - - // Trim whitespace and newlines from the SSH host field before attempting to connect - [self setSshHost:[[self sshHost] stringByTrimmingCharactersInSet:[NSCharacterSet whitespaceAndNewlineCharacterSet]]]; - - // Set up the tunnel details - sshTunnel = [[SPSSHTunnel alloc] initToHost:[self sshHost] port:[[self sshPort] integerValue] login:[self sshUser] tunnellingToPort:([[self port] length]?[[self port] integerValue]:3306) onHost:[self host]]; - [sshTunnel setParentWindow:[tableDocument parentWindow]]; - - // Add keychain or plaintext password as appropriate - note the checks in initiateConnection. - if (connectionSSHKeychainItemName) { - [sshTunnel setPasswordKeychainName:connectionSSHKeychainItemName account:connectionSSHKeychainItemAccount]; - } else if (sshPassword) { - [sshTunnel setPassword:[self sshPassword]]; - } - - // Set the public key path if appropriate - if (sshKeyLocationEnabled && sshKeyLocation) { - [sshTunnel setKeyFilePath:sshKeyLocation]; - } - - // Set the callback function on the tunnel - [sshTunnel setConnectionStateChangeSelector:@selector(sshTunnelCallback:) delegate:self]; - - // Ask the tunnel to connect. This will call the callback below on success or failure, passing - // itself as an argument - retain count should be one at this point. - [sshTunnel connect]; -} - -/* - * Cancel connection. - * Currently only cleans up the SSH connection (MySQL connection isn't threaded) - */ -- (void)cancelConnection -{ - if (!sshTunnel) return; - - cancellingConnection = YES; - - [sshTunnel disconnect]; - [sshTunnel release]; - - sshTunnel = nil; -} - -/* - * A callback function for the SSH Tunnel setup process - will be called on a connection - * state change, allowing connection to fail or proceed as appropriate. If successful, - * will call initiateMySQLConnection. - */ -- (void)sshTunnelCallback:(SPSSHTunnel *)theTunnel -{ - if (cancellingConnection) return; - NSInteger newState = [theTunnel state]; - - if (newState == PROXY_STATE_IDLE) { - [tableDocument setTitlebarStatus:NSLocalizedString(@"SSH Disconnected", @"SSH disconnected titlebar marker")]; - [self failConnectionWithTitle:NSLocalizedString(@"SSH connection failed!", @"SSH connection failed title") errorMessage:[theTunnel lastError] detail:[sshTunnel debugMessages]]; - } else if (newState == PROXY_STATE_CONNECTED) { - [tableDocument setTitlebarStatus:NSLocalizedString(@"SSH Connected", @"SSH connected titlebar marker")]; - [self initiateMySQLConnection]; - } else { - [tableDocument setTitlebarStatus:NSLocalizedString(@"SSH Connecting…", @"SSH connecting titlebar marker")]; - } -} - -/* - * Set up the MySQL connection, either through a successful tunnel or directly in the background. - */ -- (void)initiateMySQLConnection -{ - // Disable the favorites table view to prevent further connections attempts - [favoritesTable setEnabled:NO]; - - if (sshTunnel) - [progressIndicatorText setStringValue:NSLocalizedString(@"MySQL connecting...", @"MySQL connecting very short status message")]; - else - [progressIndicatorText setStringValue:NSLocalizedString(@"Connecting...", @"Generic connecting very short status message")]; - - [progressIndicatorText display]; - - [connectButton setTitle:NSLocalizedString(@"Cancel", @"cancel button")]; - [connectButton setAction:@selector(cancelMySQLConnection:)]; - [connectButton setEnabled:YES]; - [connectButton display]; - - [NSThread detachNewThreadSelector:@selector(_initiateMySQLConnectionInBackground) toTarget:self withObject:nil]; -} - -/* - * Ends a connection attempt by stopping the connection animation and - * displaying a specified error message. - */ -- (void)failConnectionWithTitle:(NSString *)theTitle errorMessage:(NSString *)theErrorMessage detail:(NSString *)errorDetail -{ - BOOL isSSHTunnelBindError = NO; - - // Clean up the interface - [progressIndicator stopAnimation:self]; - [progressIndicator display]; - [progressIndicatorText setHidden:YES]; - [progressIndicatorText display]; - [addToFavoritesButton setHidden:NO]; - [addToFavoritesButton display]; - [connectButton setEnabled:YES]; - [tableDocument clearStatusIcon]; - - // Release as appropriate - if (sshTunnel) { - [sshTunnel disconnect], [sshTunnel release], sshTunnel = nil; - - // If the SSH tunnel connection failed because the port it was trying to bind to was already in use take note - // of it so we can give the user the option of connecting via standard connection and use the existing tunnel. - if ([theErrorMessage rangeOfString:@"bind"].location != NSNotFound) { - isSSHTunnelBindError = YES; - } - } - - if (errorDetail) [errorDetailText setString:errorDetail]; - - // Inform the delegate that the connection attempt failed - if (delegate && [delegate respondsToSelector:@selector(connectionControllerConnectAttemptFailed:)]) { - [delegate connectionControllerConnectAttemptFailed:self]; - } - - // Only display the connection error message if there is a window visible and the connection attempt - // wasn't cancelled even though it failed. - if ([[tableDocument parentWindow] isVisible] && (!mySQLConnectionCancelled)) { - SPBeginAlertSheet(theTitle, NSLocalizedString(@"OK", @"OK button"), (errorDetail) ? NSLocalizedString(@"Show Detail", @"Show detail button") : nil, (isSSHTunnelBindError) ? NSLocalizedString(@"Use Standard Connection", @"use standard connection button") : nil, [tableDocument parentWindow], self, @selector(connectionFailureSheetDidEnd:returnCode:contextInfo:), @"connect", theErrorMessage); - } -} - -/** - * Alert sheet callback method - invoked when an error sheet is closed. - */ -- (void)connectionFailureSheetDidEnd:(NSAlert *)alert returnCode:(NSInteger)returnCode contextInfo:(void *)contextInfo -{ - // Restore the passwords from keychain for editing if appropriate - if (connectionKeychainItemName) { - [self setPassword:[keychain getPasswordForName:connectionKeychainItemName account:connectionKeychainItemAccount]]; - } - if (connectionSSHKeychainItemName) { - [self setSshPassword:[keychain getPasswordForName:connectionSSHKeychainItemName account:connectionSSHKeychainItemAccount]]; - } - - if (returnCode == NSAlertAlternateReturn) { - [errorDetailText setFont:[NSFont userFontOfSize:12]]; - [errorDetailText setAlignment:NSLeftTextAlignment]; - [errorDetailWindow makeKeyAndOrderFront:self]; - } - // Currently only SSH port bind errors offer a 3rd option in the error dialog, but if this ever changes - // this will definitely need to be updated. - else if (returnCode == NSAlertOtherReturn) { - // Extract the local port number that SSH attempted to bind to from the debug output - NSString *tunnelPort = [[[errorDetailText string] componentsMatchedByRegex:@"LOCALHOST:([0-9]+)" capture:1L] lastObject]; - - // Change the connection type to standard TCP/IP - [self setType:SPTCPIPConnection]; - - // Change connection details - [self setPort:tunnelPort]; - [self setHost:@"127.0.0.1"]; - - // Change to standard TCP/IP connection view - [self resizeTabViewToConnectionType:SPTCPIPConnection animating:YES]; - - // Initiate the connection after half a second to give the connection view a chance to resize - [self performSelector:@selector(initiateConnection:) withObject:self afterDelay:0.5]; - } -} +#pragma mark - +#pragma mark Interface interaction /** - * Add the connection to the parent document and restore the - * interface, allowing the application to run as normal. + * Registered in initWithDocument: to be the double click action of the favorites outline view. */ -- (void)addConnectionToDocument +- (IBAction)nodeDoubleClicked:(id)sender { - // Hide the connection view and restore the main view - [connectionView removeFromSuperviewWithoutNeedingDisplay]; - [databaseConnectionView setHidden:NO]; - - // Restore the toolbar icons - NSArray *toolbarItems = [[[tableDocument parentWindow] toolbar] items]; - - for (NSInteger i = 0; i < [toolbarItems count]; i++) [[toolbarItems objectAtIndex:i] setEnabled:YES]; - - // Set keychain id for saving SPF files - if ([self valueForKeyPath:@"selectedFavorite.id"]) { - [tableDocument setKeychainID:[[self valueForKeyPath:@"selectedFavorite.id"] stringValue]]; + SPTreeNode *node = [self selectedFavoriteNode]; + + // Only proceed to initiate a connection if a leaf node (i.e. a favorite and not a group) was double clicked. + if (![node isGroup]) { + [self initiateConnection:self]; } + // Otherwise start editing the group item's name else { - [tableDocument setKeychainID:@""]; + [favoritesOutlineView editColumn:0 row:[favoritesOutlineView selectedRow] withEvent:nil select:YES]; } - - // Pass the connection to the table document, allowing it to set - // up the other classes and the rest of the interface. - [tableDocument setConnection:mySQLConnection]; } -#pragma mark - -#pragma mark Interface interaction - /** * Opens the SSH/SSL key selection window, ready to select a key file. */ - (IBAction)chooseKeyLocation:(id)sender { - [favoritesTable deselectAll:self]; + [favoritesOutlineView deselectAll:self]; NSString *directoryPath = nil; NSString *filePath = nil; NSArray *permittedFileTypes = nil; @@ -569,7 +417,7 @@ } permittedFileTypes = [NSArray arrayWithObjects:@"pem", @"key", @"", nil]; [openPanel setAccessoryView:sslKeyFileLocationHelp]; - + // SSL certificate file location: } else if (sender == standardSSLCertificateButton || sender == socketSSLCertificateButton) { if ([sender state] == NSOffState) { @@ -578,7 +426,7 @@ } permittedFileTypes = [NSArray arrayWithObjects:@"pem", @"cert", @"", nil]; [openPanel setAccessoryView:sslCertificateLocationHelp]; - + // SSL CA certificate file location: } else if (sender == standardSSLCACertButton || sender == socketSSLCACertButton) { if ([sender state] == NSOffState) { @@ -592,72 +440,14 @@ [openPanel beginSheetForDirectory:directoryPath file:filePath types:permittedFileTypes - modalForWindow:[tableDocument parentWindow] + modalForWindow:[dbDocument parentWindow] modalDelegate:self didEndSelector:@selector(chooseKeyLocationSheetDidEnd:returnCode:contextInfo:) contextInfo:sender]; } /** - * Called after closing the SSH/SSL key selection sheet. - */ -- (void)chooseKeyLocationSheetDidEnd:(NSOpenPanel *)openPanel returnCode:(NSInteger)returnCode contextInfo:(void *)contextInfo -{ - NSString *abbreviatedFileName = [[openPanel filename] stringByAbbreviatingWithTildeInPath]; - - // SSH key file selection - if (contextInfo == sshSSHKeyButton) { - if (returnCode == NSCancelButton) { - [self setSshKeyLocationEnabled:NSOffState]; - return; - } - [self setSshKeyLocation:abbreviatedFileName]; - - // SSL key file selection - } else if (contextInfo == standardSSLKeyFileButton || contextInfo == socketSSLKeyFileButton) { - if (returnCode == NSCancelButton) { - [self setSslKeyFileLocationEnabled:NSOffState]; - [self setSslKeyFileLocation:nil]; - return; - } - [self setSslKeyFileLocation:abbreviatedFileName]; - - // SSL certificate file selection - } else if (contextInfo == standardSSLCertificateButton || contextInfo == socketSSLCertificateButton) { - if (returnCode == NSCancelButton) { - [self setSslCertificateFileLocationEnabled:NSOffState]; - [self setSslCertificateFileLocation:nil]; - return; - } - [self setSslCertificateFileLocation:abbreviatedFileName]; - - // SSL CA certificate file selection - } else if (contextInfo == standardSSLCACertButton || contextInfo == socketSSLCACertButton) { - if (returnCode == NSCancelButton) { - [self setSslCACertFileLocationEnabled:NSOffState]; - [self setSslCACertFileLocation:nil]; - return; - } - [self setSslCACertFileLocation:abbreviatedFileName]; - } -} - -/** - * Opens the preferences window, or brings it to the front, and switch to the favorites tab. - * If a favorite is selected in the connection sheet, it is also select in the prefs window. - */ -- (IBAction)editFavorites:(id)sender -{ - SPPreferenceController *prefsController = [[NSApp delegate] preferenceController]; - - [prefsController showWindow:self]; - [prefsController displayFavoritePreferences:self]; - - if ([favoritesTable numberOfSelectedRows]) [[prefsController favoritesPreferencePane] selectFavorites:[NSArray arrayWithObject:[self valueForKeyPath:@"selectedFavorite"]]]; -} - -/** - * Show connection help. + * Show connection help webpage. */ - (IBAction)showHelp:(id)sender { @@ -676,83 +466,6 @@ #pragma mark Connection details interaction and display /** - * Trigger a resize action whenever the tab view changes. The connection - * detail forms are held within container views, which are of a fixed width; - * the tabview and buttons are contained within a resizable view which - * is set to dimensions based on the container views, allowing the view - * to be sized according to the detail type. - */ -- (void)tabView:(NSTabView *)tabView didSelectTabViewItem:(NSTabViewItem *)tabViewItem -{ - NSInteger selectedTabView = [tabView indexOfTabViewItem:tabViewItem]; - - // Deselect any selected favorite for manual changes - if (!automaticFavoriteSelection) [favoritesTable deselectAll:self]; - automaticFavoriteSelection = NO; - - if (selectedTabView == previousType) return; - - [self resizeTabViewToConnectionType:selectedTabView animating:YES]; - - // Update the host as appropriate - if ((selectedTabView != SPSocketConnection) && [[self host] isEqualToString:@"localhost"]) { - [self setHost:@""]; - } - - previousType = selectedTabView; -} - -/** - * As the scrollview resizes, keep the details centered within it if - * the detail frame is larger than the scrollview size; otherwise, pin - * the detail frame to the top of the scrollview. - */ -- (void)scrollViewFrameChanged:(NSNotification *)aNotification -{ - NSRect scrollViewFrame = [connectionDetailsScrollView frame]; - NSRect scrollDocumentFrame = [[connectionDetailsScrollView documentView] frame]; - NSRect connectionDetailsFrame = [connectionResizeContainer frame]; - - // Scroll view is smaller than contents - keep positioned at top. - if (scrollViewFrame.size.height < connectionDetailsFrame.size.height + 10) { - if (connectionDetailsFrame.origin.y != 0) { - connectionDetailsFrame.origin.y = 0; - [connectionResizeContainer setFrame:connectionDetailsFrame]; - scrollDocumentFrame.size.height = connectionDetailsFrame.size.height + 10; - [[connectionDetailsScrollView documentView] setFrame:scrollDocumentFrame]; - } - - // Otherwise, center. - } else { - connectionDetailsFrame.origin.y = (scrollViewFrame.size.height - connectionDetailsFrame.size.height)/3; - [connectionResizeContainer setFrame:connectionDetailsFrame]; - scrollDocumentFrame.size.height = scrollViewFrame.size.height; - [[connectionDetailsScrollView documentView] setFrame:scrollDocumentFrame]; - } -} - -/** - * When a favorite is selected, and the connection details are edited, deselect the favorite; - * this is clearer and also prevents a failed connection from being repopulated with the - * favorite's details instead of the last used details. - */ -- (void)controlTextDidChange:(NSNotification *)aNotification -{ - [favoritesTable deselectAll:self]; -} - -/** - * When a host field finishes editing, ensure that it hasn't been set to "localhost" - * to ensure that socket connections don't inadvertently occur. - */ -- (void)controlTextDidEndEditing:(NSNotification *)notification -{ - if ([notification object] == standardSQLHostField || [notification object] == sshSQLHostField) { - [self checkHost]; - } -} - -/** * Control tab view resizing based on the supplied connection type, * with an option defining whether it should be animated or not. */ @@ -775,49 +488,15 @@ case SPSSHTunnelConnection: targetResizeRect = [sshConnectionFormContainer frame]; break; - } + } frameRect.size.height = targetResizeRect.size.height + additionalFormHeight; if (animate) { [[connectionResizeContainer animator] setFrame:frameRect]; - } else { - [connectionResizeContainer setFrame:frameRect]; - } -} - -/** - * Check the host field and ensure it isn't set to "localhost" for - * non-socket connections. - */ -- (BOOL)checkHost -{ - if ([self type] != SPSocketConnection && [[self host] isEqualToString:@"localhost"]) { - SPBeginAlertSheet(NSLocalizedString(@"You have entered 'localhost' for a non-socket connection", @"title of error when using 'localhost' for a network connection"), - NSLocalizedString(@"Use 127.0.0.1", @"Use 127.0.0.1 button"), // Main button - NSLocalizedString(@"Connect via socket", @"Connect via socket button"), // Alternate button - nil, // Other button - [tableDocument parentWindow], // Window to attach to - self, // Modal delegate - @selector(localhostErrorSheetDidEnd:returnCode:contextInfo:), // Did end selector - nil, // Contextual info for selectors - NSLocalizedString(@"To MySQL, 'localhost' is a special host and means that a socket connection should be used.\n\nDid you mean to use a socket connection, or to connect to the local machine via a port? If you meant to connect via a port, '127.0.0.1' should be used instead of 'localhost'.", @"message of error when using 'localhost' for a network connection")); - return NO; - } - - return YES; -} - -/** - * Alert sheet callback method - invoked when the error sheet is closed. - */ -- (void)localhostErrorSheetDidEnd:(NSAlert *)alert returnCode:(NSInteger)returnCode contextInfo:(void *)contextInfo -{ - if (returnCode == NSAlertAlternateReturn) { - [self setType:SPSocketConnection]; - [self setHost:@""]; - } else { - [self setHost:@"127.0.0.1"]; + } + else { + [connectionResizeContainer setFrame:frameRect]; } } @@ -828,17 +507,17 @@ * Sorts the favorites table view based on the selected sort by item. */ - (void)sortFavorites:(id)sender -{ +{ previousSortItem = currentSortItem; currentSortItem = [[sender menu] indexOfItem:sender]; - + [prefs setInteger:currentSortItem forKey:SPFavoritesSortedBy]; - + // Perform sorting [self _sortFavorites]; - + if (previousSortItem > -1) [[[sender menu] itemAtIndex:previousSortItem] setState:NSOffState]; - + [[[sender menu] itemAtIndex:currentSortItem] setState:NSOnState]; } @@ -848,36 +527,13 @@ - (void)reverseSortFavorites:(id)sender { reverseFavoritesSort = (![sender state]); - + [prefs setBool:reverseFavoritesSort forKey:SPFavoritesSortedInReverse]; - + // Perform re-sorting [self _sortFavorites]; - - [sender setState:reverseFavoritesSort]; -} - -/** - * Updates the local favorites array from the user defaults - */ -- (void)updateFavorites -{ - [favoritesTable deselectAll:self]; - - if (favorites) [favorites release]; - - if ([prefs objectForKey:SPFavorites]) { - favorites = [[NSMutableArray alloc] initWithArray:[prefs objectForKey:SPFavorites]]; - } - else { - favorites = [[NSMutableArray alloc] init]; - } - - [self _buildFavoritesTree]; - - [favoritesTable reloadData]; - - [favoritesTable expandItem:[[favoritesRoot nodeChildren] objectAtIndex:0]]; + + [sender setState:reverseFavoritesSort]; } /** @@ -885,9 +541,6 @@ */ - (void)updateFavoriteSelection:(id)sender { - // If nothing is selected, return without updating the interface - if (![self selectedFavorite]) return; - automaticFavoriteSelection = YES; // Clear the keychain referral items as appropriate @@ -895,10 +548,19 @@ if (connectionKeychainItemAccount) [connectionKeychainItemAccount release], connectionKeychainItemAccount = nil; if (connectionSSHKeychainItemName) [connectionSSHKeychainItemName release], connectionSSHKeychainItemName = nil; if (connectionSSHKeychainItemAccount) [connectionSSHKeychainItemAccount release], connectionSSHKeychainItemAccount = nil; - + + SPTreeNode *node = [self selectedFavoriteNode]; + // Update key-value properties from the selected favourite, using empty strings where not found - NSDictionary *fav = [self selectedFavorite]; - + NSDictionary *fav = [[node representedObject] nodeFavorite]; + + // Keep a copy of the favorite as it currently stands + if (currentFavorite) [currentFavorite release], currentFavorite = nil; + + currentFavorite = [[node representedObject] copy]; + + [connectionResizeContainer setHidden:NO]; + // Standard details [self setType:([fav objectForKey:SPFavoriteTypeKey] ? [[fav objectForKey:SPFavoriteTypeKey] integerValue] : SPTCPIPConnection)]; [self setName:([fav objectForKey:SPFavoriteNameKey] ? [fav objectForKey:SPFavoriteNameKey] : @"")]; @@ -907,7 +569,7 @@ [self setUser:([fav objectForKey:SPFavoriteUserKey] ? [fav objectForKey:SPFavoriteUserKey] : @"")]; [self setPort:([fav objectForKey:SPFavoritePortKey] ? [fav objectForKey:SPFavoritePortKey] : @"")]; [self setDatabase:([fav objectForKey:SPFavoriteDatabaseKey] ? [fav objectForKey:SPFavoriteDatabaseKey] : @"")]; - + // SSL details [self setUseSSL:([fav objectForKey:SPFavoriteUseSSLKey] ? [[fav objectForKey:SPFavoriteUseSSLKey] intValue] : NSOffState)]; [self setSslKeyFileLocationEnabled:([fav objectForKey:SPFavoriteSSLKeyFileLocationEnabledKey] ? [[fav objectForKey:SPFavoriteSSLKeyFileLocationEnabledKey] intValue] : NSOffState)]; @@ -916,89 +578,173 @@ [self setSslCertificateFileLocation:([fav objectForKey:SPFavoriteSSLCertificateFileLocationKey] ? [fav objectForKey:SPFavoriteSSLCertificateFileLocationKey] : @"")]; [self setSslCACertFileLocationEnabled:([fav objectForKey:SPFavoriteSSLCACertFileLocationEnabledKey] ? [[fav objectForKey:SPFavoriteSSLCACertFileLocationEnabledKey] intValue] : NSOffState)]; [self setSslCACertFileLocation:([fav objectForKey:SPFavoriteSSLCACertFileLocationKey] ? [fav objectForKey:SPFavoriteSSLCACertFileLocationKey] : @"")]; - + // SSH details [self setSshHost:([fav objectForKey:SPFavoriteSSHHostKey] ? [fav objectForKey:SPFavoriteSSHHostKey] : @"")]; [self setSshUser:([fav objectForKey:SPFavoriteSSHUserKey] ? [fav objectForKey:SPFavoriteSSHUserKey] : @"")]; [self setSshKeyLocationEnabled:([fav objectForKey:SPFavoriteSSHKeyLocationEnabledKey] ? [[fav objectForKey:SPFavoriteSSHKeyLocationEnabledKey] intValue] : NSOffState)]; [self setSshKeyLocation:([fav objectForKey:SPFavoriteSSHKeyLocationKey] ? [fav objectForKey:SPFavoriteSSHKeyLocationKey] : @"")]; [self setSshPort:([fav objectForKey:SPFavoriteSSHPortKey] ? [fav objectForKey:SPFavoriteSSHPortKey] : @"")]; - + // Trigger an interface update [self resizeTabViewToConnectionType:[self type] animating:YES]; - + // Check whether the password exists in the keychain, and if so add it; also record the // keychain details so we can pass around only those details if the password doesn't change connectionKeychainItemName = [[keychain nameForFavoriteName:[self valueForKeyPath:@"selectedFavorite.name"] id:[self valueForKeyPath:@"selectedFavorite.id"]] retain]; connectionKeychainItemAccount = [[keychain accountForUser:[self valueForKeyPath:@"selectedFavorite.user"] host:(([self type] == SPSocketConnection)?@"localhost":[self valueForKeyPath:@"selectedFavorite.host"]) database:[self valueForKeyPath:@"selectedFavorite.database"]] retain]; - + [self setPassword:[keychain getPasswordForName:connectionKeychainItemName account:connectionKeychainItemAccount]]; - + if (![[self password] length]) { [self setPassword:nil]; [connectionKeychainItemName release], connectionKeychainItemName = nil; [connectionKeychainItemAccount release], connectionKeychainItemAccount = nil; } - + // And the same for the SSH password connectionSSHKeychainItemName = [[keychain nameForSSHForFavoriteName:[self valueForKeyPath:@"selectedFavorite.name"] id:[self valueForKeyPath:@"selectedFavorite.id"]] retain]; connectionSSHKeychainItemAccount = [[keychain accountForSSHUser:[self valueForKeyPath:@"selectedFavorite.sshUser"] sshHost:[self valueForKeyPath:@"selectedFavorite.sshHost"]] retain]; - + [self setSshPassword:[keychain getPasswordForName:connectionSSHKeychainItemName account:connectionSSHKeychainItemAccount]]; - + if (![[self sshPassword] length]) { [self setSshPassword:nil]; [connectionSSHKeychainItemName release], connectionSSHKeychainItemName = nil; [connectionSSHKeychainItemAccount release], connectionSSHKeychainItemAccount = nil; } - - [prefs setInteger:([favoritesTable selectedRow] - 1) forKey:SPLastFavoriteIndex]; - - // Set next KeyView to password field if it is empty - switch ([self type]) + + [prefs setInteger:([favoritesOutlineView selectedRow] - 1) forKey:SPLastFavoriteID]; + + // Set first responder to password field if it is empty + switch ([self type]) { case SPTCPIPConnection: - if (![[standardPasswordField stringValue] length]) [favoritesTable setNextKeyView:standardPasswordField]; + if (![[standardPasswordField stringValue] length]) [[dbDocument parentWindow] makeFirstResponder:standardPasswordField]; break; case SPSocketConnection: - if (![[socketPasswordField stringValue] length]) [favoritesTable setNextKeyView:socketPasswordField]; + if (![[socketPasswordField stringValue] length]) [[dbDocument parentWindow] makeFirstResponder:socketPasswordField]; break; case SPSSHTunnelConnection: - if (![[sshPasswordField stringValue] length]) [favoritesTable setNextKeyView:sshPasswordField]; + if (![[sshPasswordField stringValue] length]) [[dbDocument parentWindow] makeFirstResponder:sshPasswordField]; break; } } /** - * Returns a KVC-compliant proxy to the currently selected favorite, or nil if nothing selected. + * Returns the selected favorite data dictionary or nil if nothing is selected. + */ +- (NSMutableDictionary *)selectedFavorite +{ + SPTreeNode *node = [self selectedFavoriteNode]; + + return (![node isGroup]) ? [[node representedObject] nodeFavorite] : nil; +} + +/** + * Returns the selected favorite node or nil if nothing is selected. */ -- (id)selectedFavorite +- (SPTreeNode *)selectedFavoriteNode { - if ([favoritesTable selectedRow] == -1) return nil; + NSArray *nodes = [self selectedFavoriteNodes]; + + return ([nodes count]) ? (SPTreeNode *)[[self selectedFavoriteNodes] objectAtIndex:0] : nil; +} - return [favorites objectAtIndex:([favoritesTable selectedRow] - 1)]; +/** + * Returns an array of selected favorite nodes. + */ +- (NSArray *)selectedFavoriteNodes +{ + NSMutableArray *nodes = [NSMutableArray array]; + NSIndexSet *indexes = [favoritesOutlineView selectedRowIndexes]; + + NSUInteger currentIndex = [indexes firstIndex]; + + while (currentIndex != NSNotFound) + { + [nodes addObject:[favoritesOutlineView itemAtRow:currentIndex]]; + + currentIndex = [indexes indexGreaterThanIndex:currentIndex]; + } + + return nodes; } /** - * Adds the current details as a new favorite, select it, and scroll the selected - * row to visible. + * Adds a new connection favorite. */ - (IBAction)addFavorite:(id)sender { - NSString *thePassword, *theSSHPassword; - NSNumber *favoriteid = [NSNumber numberWithInteger:[[NSString stringWithFormat:@"%f", [[NSDate date] timeIntervalSince1970]] hash]]; - NSString *favoriteName = [[self name] length] ? [self name]:[NSString stringWithFormat:@"%@@%@", ([self user] && [[self user] length])?[self user] : @"anonymous", (([self type] == SPSocketConnection) ? @"localhost" : [self host])]; + NSNumber *favoriteID = [self _createNewFavoriteID]; + + NSArray *objects = [NSArray arrayWithObjects:NSLocalizedString(@"New Favorite", @"new favorite name"), + [NSNumber numberWithInteger:0], @"", @"", @"", @"", + [NSNumber numberWithInt:NSOffState], + [NSNumber numberWithInt:NSOffState], + [NSNumber numberWithInt:NSOffState], + [NSNumber numberWithInt:NSOffState], @"", @"", @"", + [NSNumber numberWithInt:NSOffState], @"", @"", favoriteID, nil]; + + NSArray *keys = [NSArray arrayWithObjects: + SPFavoriteNameKey, + SPFavoriteTypeKey, + SPFavoriteHostKey, + SPFavoriteSocketKey, + SPFavoriteUserKey, + SPFavoritePortKey, + SPFavoriteUseSSLKey, + SPFavoriteSSLKeyFileLocationEnabledKey, + SPFavoriteSSLCertificateFileLocationEnabledKey, + SPFavoriteSSLCACertFileLocationEnabledKey, + SPFavoriteDatabaseKey, + SPFavoriteSSHHostKey, + SPFavoriteSSHUserKey, + SPFavoriteSSHKeyLocationEnabledKey, + SPFavoriteSSHKeyLocationKey, + SPFavoriteSSHPortKey, + SPFavoriteIDKey, + nil]; + + // Create default favorite + NSMutableDictionary *favorite = [NSMutableDictionary dictionaryWithObjects:objects forKeys:keys]; + + SPTreeNode *selectedNode = [self selectedFavoriteNode]; + + SPTreeNode *parent = ([selectedNode isGroup]) ? selectedNode : [selectedNode parentNode]; + + SPTreeNode *node = [favoritesController addFavoriteNodeWithData:favorite asChildOfNode:parent]; + + [self _reloadFavoritesViewData]; + [self _selectNode:node]; + + [[[[NSApp delegate] preferenceController] generalPreferencePane] updateDefaultFavoritePopup]; + + favoriteNameFieldWasTouched = NO; + + [favoritesOutlineView editColumn:0 row:[favoritesOutlineView selectedRow] withEvent:nil select:YES]; +} +/** + * Adds the current details as a new connection favorite, selects it, and scrolls the selected + * row to be visible. + */ +- (IBAction)addFavoriteUsingCurrentDetails:(id)sender +{ + NSString *thePassword, *theSSHPassword; + NSNumber *favoriteid = [self _createNewFavoriteID]; + NSString *favoriteName = [[self name] length] ? [self name] : [NSString stringWithFormat:@"%@@%@", ([self user] && [[self user] length])?[self user] : @"anonymous", (([self type] == SPSocketConnection) ? @"localhost" : [self host])]; + if (![[self name] length] && [self database] && ![[self database] isEqualToString:@""]) { favoriteName = [NSString stringWithFormat:@"%@ %@", [self database], favoriteName]; } - + // Ensure that host is not empty if this is a TCP/IP or SSH connection if (([self type] == SPTCPIPConnection || [self type] == SPSSHTunnelConnection) && ![[self host] length]) { NSRunAlertPanel(NSLocalizedString(@"Insufficient connection details", @"insufficient details message"), NSLocalizedString(@"Insufficient details provided to establish a connection. Please provide at least a host.", @"insufficient details informative message"), NSLocalizedString(@"OK", @"OK button"), nil, nil); return; } - + // If SSH is enabled, ensure that the SSH host is not nil if ([self type] == SPSSHTunnelConnection && ![[self sshHost] length]) { NSRunAlertPanel(NSLocalizedString(@"Insufficient connection details", @"insufficient details message"), NSLocalizedString(@"Please enter the hostname for the SSH Tunnel, or disable the SSH Tunnel.", @"message of panel when ssh details are incomplete"), NSLocalizedString(@"OK", @"OK button"), nil, nil); @@ -1006,22 +752,22 @@ } // Ensure that a socket connection is not inadvertently used - if (![self checkHost]) return; - + if (![self _checkHost]) return; + // Construct the favorite details - cannot use only dictionaryWithObjectsAndKeys for possible nil values. NSMutableDictionary *newFavorite = [NSMutableDictionary dictionaryWithObjectsAndKeys: [NSNumber numberWithInteger:[self type]], SPFavoriteTypeKey, favoriteName, SPFavoriteNameKey, favoriteid, SPFavoriteIDKey, nil]; - + // Standard details if ([self host]) [newFavorite setObject:[self host] forKey:SPFavoriteHostKey]; if ([self socket]) [newFavorite setObject:[self socket] forKey:SPFavoriteSocketKey]; if ([self user]) [newFavorite setObject:[self user] forKey:SPFavoriteUserKey]; if ([self port]) [newFavorite setObject:[self port] forKey:SPFavoritePortKey]; if ([self database]) [newFavorite setObject:[self database] forKey:SPFavoriteDatabaseKey]; - + // SSL details if ([self useSSL]) [newFavorite setObject:[NSNumber numberWithInt:[self useSSL]] forKey:SPFavoriteUseSSLKey]; [newFavorite setObject:[NSNumber numberWithInt:[self sslKeyFileLocationEnabled]] forKey:SPFavoriteSSLKeyFileLocationEnabledKey]; @@ -1030,7 +776,7 @@ if ([self sslCertificateFileLocation]) [newFavorite setObject:[self sslCertificateFileLocation] forKey:SPFavoriteSSLCertificateFileLocationKey]; [newFavorite setObject:[NSNumber numberWithInt:[self sslCACertFileLocationEnabled]] forKey:SPFavoriteSSLCACertFileLocationEnabledKey]; if ([self sslCACertFileLocation]) [newFavorite setObject:[self sslCACertFileLocation] forKey:SPFavoriteSSLCACertFileLocationKey]; - + // SSH details if ([self sshHost]) [newFavorite setObject:[self sshHost] forKey:SPFavoriteSSHHostKey]; if ([self sshUser]) [newFavorite setObject:[self sshUser] forKey:SPFavoriteSSHUserKey]; @@ -1038,22 +784,13 @@ [newFavorite setObject:[NSNumber numberWithInt:[self sshKeyLocationEnabled]] forKey:SPFavoriteSSHKeyLocationEnabledKey]; if ([self sshKeyLocation]) [newFavorite setObject:[self sshKeyLocation] forKey:SPFavoriteSSHKeyLocationKey]; - // Add the new favorite to the user defaults array - NSMutableArray *currentFavorites = ([prefs objectForKey:SPFavorites]) ? [[NSMutableArray alloc] initWithArray:[prefs objectForKey:SPFavorites]] : [[NSMutableArray alloc] init]; - - [currentFavorites addObject:newFavorite]; - - [prefs setObject:[NSArray arrayWithArray:currentFavorites] forKey:SPFavorites]; - - [currentFavorites release]; - // Add the password to keychain as appropriate thePassword = [self password]; - + if (mySQLConnection && connectionKeychainItemName) { thePassword = [keychain getPasswordForName:connectionKeychainItemName account:connectionKeychainItemAccount]; } - + if (thePassword && (![thePassword isEqualToString:@""])) { [keychain addPassword:thePassword forName:[keychain nameForFavoriteName:favoriteName id:[NSString stringWithFormat:@"%lld", [favoriteid longLongValue]]] @@ -1062,71 +799,375 @@ // Add the SSH password to keychain as appropriate theSSHPassword = [self sshPassword]; - + if (mySQLConnection && connectionSSHKeychainItemName) { theSSHPassword = [keychain getPasswordForName:connectionSSHKeychainItemName account:connectionSSHKeychainItemAccount]; } - + if (theSSHPassword && (![theSSHPassword isEqualToString:@""])) { [keychain addPassword:theSSHPassword forName:[keychain nameForSSHForFavoriteName:favoriteName id:[NSString stringWithFormat:@"%lld", [favoriteid longLongValue]]] account:[keychain accountForSSHUser:[self sshUser] sshHost:[self sshHost]]]; } - - // Update the favorites list and selection - [self updateFavorites]; - - [favoritesTable selectRowIndexes:[NSIndexSet indexSetWithIndex:[favorites count]-1] byExtendingSelection:NO]; - [favoritesTable scrollRowToVisible:[favoritesTable selectedRow]]; + + SPTreeNode *node = [favoritesController addFavoriteNodeWithData:newFavorite asChildOfNode:nil]; + + [self _reloadFavoritesViewData]; + [self _selectNode:node]; // Update the favorites popup button in the preferences [[[[NSApp delegate] preferenceController] generalPreferencePane] updateDefaultFavoritePopup]; } /** - * If the favorites list in the preferences change, trigger a reload of - * the favorites table data. + * Adds a new group node to the favorites tree with a default name. Once added it is selected for editing. */ -- (void)observeValueForKeyPath:(NSString *)keyPath ofObject:(id)object change:(NSDictionary *)change context:(void *)context +- (IBAction)addGroup:(id)sender { - if ([keyPath isEqualToString:SPFavorites]) { - [self updateFavorites]; + SPTreeNode *selectedNode = [self selectedFavoriteNode]; + + SPTreeNode *parent = ([selectedNode isGroup]) ? selectedNode : [selectedNode parentNode]; + + SPTreeNode *node = [favoritesController addGroupNodeWithName:NSLocalizedString(@"New Folder", @"new folder placeholder name") asChildOfNode:parent]; + + [self _reloadFavoritesViewData]; + [self _selectNode:node]; + + [favoritesOutlineView editColumn:0 row:[favoritesOutlineView selectedRow] withEvent:nil select:YES]; +} + +/** + * Removes the selected node. + */ +- (IBAction)removeNode:(id)sender +{ + if ([favoritesOutlineView numberOfSelectedRows] == 1) { + + SPTreeNode *node = [self selectedFavoriteNode]; + + NSString *message = @""; + NSString *informativeMessage = @""; + + if (![node isGroup]) { + message = [NSString stringWithFormat:NSLocalizedString(@"Delete favorite '%@'?", @"delete database message"), [[[node representedObject] nodeFavorite] objectForKey:SPFavoriteNameKey]]; + informativeMessage = [NSString stringWithFormat:NSLocalizedString(@"Are you sure you want to delete the favorite '%@'? This operation cannot be undone.", @"delete database informative message"), [[[node representedObject] nodeFavorite] objectForKey:SPFavoriteNameKey]]; + } + else { + message = [NSString stringWithFormat:NSLocalizedString(@"Delete group '%@'?", @"delete database message"), [[node representedObject] nodeName]]; + informativeMessage = [NSString stringWithFormat:NSLocalizedString(@"Are you sure you want to delete the group '%@'? All favorites within this group will also be deleted. This operation cannot be undone.", @"delete database informative message"), [[node representedObject] nodeName]]; + } + + NSAlert *alert = [NSAlert alertWithMessageText:message + defaultButton:NSLocalizedString(@"Delete", @"delete button") + alternateButton:NSLocalizedString(@"Cancel", @"cancel button") + otherButton:nil + informativeTextWithFormat:informativeMessage]; + + NSArray *buttons = [alert buttons]; + + // Change the alert's cancel button to have the key equivalent of return + [[buttons objectAtIndex:0] setKeyEquivalent:@"d"]; + [[buttons objectAtIndex:0] setKeyEquivalentModifierMask:NSCommandKeyMask]; + [[buttons objectAtIndex:1] setKeyEquivalent:@"\r"]; + + [alert setAlertStyle:NSCriticalAlertStyle]; + + [alert beginSheetModalForWindow:[dbDocument parentWindow] + modalDelegate:self + didEndSelector:@selector(sheetDidEnd:returnCode:contextInfo:) + contextInfo:SPRemoveNode]; + } +} + +/** + * Duplicates the selected connection favorite. + */ +- (IBAction)duplicateFavorite:(id)sender +{ + if ([favoritesOutlineView numberOfSelectedRows] == 1) { + + NSMutableDictionary *favorite = [NSMutableDictionary dictionaryWithDictionary:[self selectedFavorite]]; + + NSNumber *favoriteID = [self _createNewFavoriteID]; + + NSInteger duplicatedFavoriteType = [[favorite objectForKey:SPFavoriteTypeKey] integerValue]; + + // Update the unique ID + [favorite setObject:favoriteID forKey:SPFavoriteIDKey]; + + // Alter the name for clarity + [favorite setObject:[NSString stringWithFormat:NSLocalizedString(@"%@ Copy", @"Initial favourite name after duplicating a previous favourite"), [favorite objectForKey:SPFavoriteNameKey]] forKey:SPFavoriteNameKey]; + + // Create new keychain items if appropriate + if (password && [password length]) { + NSString *keychainName = [keychain nameForFavoriteName:[favorite objectForKey:SPFavoriteNameKey] id:[favorite objectForKey:SPFavoriteIDKey]]; + NSString *keychainAccount = [keychain accountForUser:[favorite objectForKey:SPFavoriteUserKey] host:((duplicatedFavoriteType == SPSocketConnection) ? @"localhost" : [favorite objectForKey:SPFavoriteHostKey]) database:[favorite objectForKey:SPFavoriteDatabaseKey]]; + NSString *favoritePassword = [keychain getPasswordForName:keychainName account:keychainAccount]; + + keychainName = [keychain nameForFavoriteName:[favorite objectForKey:SPFavoriteNameKey] id:[favorite objectForKey:SPFavoriteIDKey]]; + + [keychain addPassword:favoritePassword forName:keychainName account:keychainAccount]; + + favoritePassword = nil; + } + + if (sshPassword && [sshPassword length]) { + NSString *keychainSSHName = [keychain nameForSSHForFavoriteName:[favorite objectForKey:SPFavoriteNameKey] id:[favorite objectForKey:SPFavoriteIDKey]]; + NSString *keychainSSHAccount = [keychain accountForSSHUser:[favorite objectForKey:SPFavoriteSSHUserKey] sshHost:[favorite objectForKey:SPFavoriteSSHHostKey]]; + NSString *favoriteSSHPassword = [keychain getPasswordForName:keychainSSHName account:keychainSSHAccount]; + + keychainSSHName = [keychain nameForSSHForFavoriteName:[favorite objectForKey:SPFavoriteNameKey] id:[favorite objectForKey:SPFavoriteIDKey]]; + + [keychain addPassword:favoriteSSHPassword forName:keychainSSHName account:keychainSSHAccount]; + + favoriteSSHPassword = nil; + } + + SPTreeNode *selectedNode = [self selectedFavoriteNode]; + + SPTreeNode *parent = ([selectedNode isGroup]) ? selectedNode : [selectedNode parentNode]; + + SPTreeNode *node = [favoritesController addFavoriteNodeWithData:favorite asChildOfNode:parent]; + + [self _reloadFavoritesViewData]; + [self _selectNode:node]; + + [[(SPPreferenceController *)[[NSApp delegate] preferenceController] generalPreferencePane] updateDefaultFavoritePopup]; } } +/** + * Switches the selected favorite/group to editing mode so it can be renamed. + */ +- (IBAction)renameFavorite:(id)sender +{ + if ([favoritesOutlineView numberOfSelectedRows] == 1) { + [favoritesOutlineView editColumn:0 row:[favoritesOutlineView selectedRow] withEvent:nil select:YES]; + } +} + +/** + * Marks the selected favorite as the default. + */ +- (IBAction)makeSelectedFavoriteDefault:(id)sender +{ + NSInteger favoriteID = [[[self selectedFavorite] objectForKey:SPFavoriteIDKey] integerValue]; + + [prefs setInteger:favoriteID forKey:SPDefaultFavorite]; +} + #pragma mark - -#pragma mark Menu Validation +#pragma mark Import/export favorites --(BOOL)validateMenuItem:(NSMenuItem *)menuItem +/** + * Displays an open panel, allowing the user to import their favorites. + */ +- (IBAction)importFavorites:(id)sender { - SEL action = [menuItem action]; - if ((action == @selector(sortFavorites:)) || (action == @selector(reverseSortFavorites:))) { + NSOpenPanel *openPanel = [NSOpenPanel openPanel]; + + [openPanel beginSheetForDirectory:nil + file:nil + types:nil + modalForWindow:[dbDocument parentWindow] + modalDelegate:self + didEndSelector:@selector(importExportFavoritesSheetDidEnd:returnCode:contextInfo:) + contextInfo:SPImportFavorites]; +} - // Loop all the items in the sort by menu only checking the currently selected one - for (NSMenuItem *item in [[menuItem menu] itemArray]) - { - [item setState:([[menuItem menu] indexOfItem:item] == currentSortItem) ? NSOnState : NSOffState]; +/** + * Displays a save panel, allowing the user to export their favorites. + */ +- (IBAction)exportFavorites:(id)sender +{ + NSSavePanel *savePanel = [NSSavePanel savePanel]; + + [savePanel beginSheetForDirectory:nil + file:SPExportFavoritesFilename + modalForWindow:[dbDocument parentWindow] + modalDelegate:self + didEndSelector:@selector(importExportFavoritesSheetDidEnd:returnCode:contextInfo:) + contextInfo:SPExportFavorites]; +} + +#pragma mark - +#pragma mark Key Value Observing + +/** + * This method is called as part of Key Value Observing. + */ +- (void)observeValueForKeyPath:(NSString *)keyPath ofObject:(id)object change:(NSDictionary *)change context:(void *)context +{ + id oldObject = [change objectForKey:NSKeyValueChangeOldKey]; + id newObject = [change objectForKey:NSKeyValueChangeNewKey]; + + if (oldObject != newObject) { + NSMutableDictionary *favorite = [self selectedFavorite]; + + [favorite setObject:(newObject) ? newObject : @"" forKey:keyPath]; + + // Save the new data to disk + [favoritesController saveFavorites]; + + [self _reloadFavoritesViewData]; + } +} + +#pragma mark - +#pragma mark Sheet methods + +/** + * Called when the user dismisses the remove node sheet. + */ +- (void)sheetDidEnd:(id)sheet returnCode:(NSInteger)returnCode contextInfo:(NSString *)contextInfo +{ + // Remove the current favorite/group + if ([contextInfo isEqualToString:SPRemoveNode]) { + if (returnCode == NSAlertDefaultReturn) { + + SPTreeNode *node = [self selectedFavoriteNode]; + + if (![node isGroup]) { + NSDictionary *favorite = [[node representedObject] nodeFavorite]; + + // Get selected favorite's details + NSString *favoriteName = [favorite objectForKey:SPFavoriteNameKey]; + NSString *favoriteUser = [favorite objectForKey:SPFavoriteUserKey]; + NSString *favoriteHost = [favorite objectForKey:SPFavoriteHostKey]; + NSString *favoriteDatabase = [favorite objectForKey:SPFavoriteDatabaseKey]; + NSString *favoriteSSHUser = [favorite objectForKey:SPFavoriteSSHUserKey]; + NSString *favoriteSSHHost = [favorite objectForKey:SPFavoriteSSHHostKey]; + NSString *favoriteID = [favorite objectForKey:SPFavoriteIDKey]; + + NSInteger favoriteType = [[favorite objectForKey:SPFavoriteTypeKey] integerValue]; + + // Remove passwords from the Keychain + [keychain deletePasswordForName:[keychain nameForFavoriteName:favoriteName id:favoriteID] + account:[keychain accountForUser:favoriteUser host:((type == SPSocketConnection) ? @"localhost" : favoriteHost) database:favoriteDatabase]]; + [keychain deletePasswordForName:[keychain nameForSSHForFavoriteName:favoriteName id:favoriteID] + account:[keychain accountForSSHUser:favoriteSSHUser sshHost:favoriteSSHHost]]; + + // Reset last used favorite + if ([[favorite objectForKey:SPFavoriteIDKey] integerValue] == [prefs integerForKey:SPLastFavoriteID]) { + [prefs setInteger:0 forKey:SPLastFavoriteID]; + } + + // Reset default favorite + if ([[favorite objectForKey:SPFavoriteIDKey] integerValue] == [prefs integerForKey:SPDefaultFavorite]) { + [prefs setInteger:[prefs integerForKey:SPLastFavoriteID] forKey:SPDefaultFavorite]; + } + } + + [favoritesController removeFavoriteNode:node]; + + [self _reloadFavoritesViewData]; + + [[(SPPreferenceController *)[[NSApp delegate] preferenceController] generalPreferencePane] updateDefaultFavoritePopup]; } + } +} - // Check or uncheck the reverse sort item - if (action == @selector(reverseSortFavorites:)) { - [menuItem setState:reverseFavoritesSort]; +/** + * Called after closing the SSH/SSL key selection sheet. + */ +- (void)chooseKeyLocationSheetDidEnd:(NSOpenPanel *)openPanel returnCode:(NSInteger)returnCode contextInfo:(void *)contextInfo +{ + NSString *abbreviatedFileName = [[openPanel filename] stringByAbbreviatingWithTildeInPath]; + + // SSH key file selection + if (contextInfo == sshSSHKeyButton) { + if (returnCode == NSCancelButton) { + [self setSshKeyLocationEnabled:NSOffState]; + return; + } + + [self setSshKeyLocation:abbreviatedFileName]; + } + // SSL key file selection + else if (contextInfo == standardSSLKeyFileButton || contextInfo == socketSSLKeyFileButton) { + if (returnCode == NSCancelButton) { + [self setSslKeyFileLocationEnabled:NSOffState]; + [self setSslKeyFileLocation:nil]; + return; + } + + [self setSslKeyFileLocation:abbreviatedFileName]; + } + // SSL certificate file selection + else if (contextInfo == standardSSLCertificateButton || contextInfo == socketSSLCertificateButton) { + if (returnCode == NSCancelButton) { + [self setSslCertificateFileLocationEnabled:NSOffState]; + [self setSslCertificateFileLocation:nil]; + return; + } + + [self setSslCertificateFileLocation:abbreviatedFileName]; + } + // SSL CA certificate file selection + else if (contextInfo == standardSSLCACertButton || contextInfo == socketSSLCACertButton) { + if (returnCode == NSCancelButton) { + [self setSslCACertFileLocationEnabled:NSOffState]; + [self setSslCACertFileLocation:nil]; + return; } - } - return YES; + + [self setSslCACertFileLocation:abbreviatedFileName]; + } +} +/** + * Called when the user dismisses either the import of export favorites panels. + */ +- (void)importExportFavoritesSheetDidEnd:(NSOpenPanel *)openPanel returnCode:(NSInteger)returnCode contextInfo:(NSString *)contextInfo +{ + +} + +/** + * Alert sheet callback method - invoked when the error sheet is closed. + */ +- (void)localhostErrorSheetDidEnd:(NSAlert *)alert returnCode:(NSInteger)returnCode contextInfo:(void *)contextInfo +{ + if (returnCode == NSAlertAlternateReturn) { + [self setType:SPSocketConnection]; + [self setHost:@""]; + } + else { + [self setHost:@"127.0.0.1"]; + } } #pragma mark - #pragma mark Private API /** + * Check the host field and ensure it isn't set to 'localhost' for non-socket connections. + */ +- (BOOL)_checkHost +{ + if ([self type] != SPSocketConnection && [[self host] isEqualToString:@"localhost"]) { + SPBeginAlertSheet(NSLocalizedString(@"You have entered 'localhost' for a non-socket connection", @"title of error when using 'localhost' for a network connection"), + NSLocalizedString(@"Use 127.0.0.1", @"Use 127.0.0.1 button"), // Main button + NSLocalizedString(@"Connect via socket", @"Connect via socket button"), // Alternate button + nil, // Other button + [dbDocument parentWindow], // Window to attach to + self, // Modal delegate + @selector(localhostErrorSheetDidEnd:returnCode:contextInfo:), // Did end selector + nil, // Contextual info for selectors + NSLocalizedString(@"To MySQL, 'localhost' is a special host and means that a socket connection should be used.\n\nDid you mean to use a socket connection, or to connect to the local machine via a port? If you meant to connect via a port, '127.0.0.1' should be used instead of 'localhost'.", @"message of error when using 'localhost' for a network connection")); + return NO; + } + + return YES; +} + +/** * Sorts the connection favorites based on the selected criteria. */ - (void)_sortFavorites { NSString *sortKey = SPFavoriteNameKey; - + switch (currentSortItem) { case SPFavoritesSortNameItem: @@ -1139,61 +1180,57 @@ sortKey = SPFavoriteTypeKey; break; } - + NSSortDescriptor *sortDescriptor = nil; - + if (currentSortItem == SPFavoritesSortTypeItem) { sortDescriptor = [[[NSSortDescriptor alloc] initWithKey:sortKey ascending:(!reverseFavoritesSort)] autorelease]; } else { sortDescriptor = [[[NSSortDescriptor alloc] initWithKey:sortKey ascending:(!reverseFavoritesSort) selector:@selector(caseInsensitiveCompare:)] autorelease]; } - - NSDictionary *first = [[favorites objectAtIndex:0] retain]; - - [favorites removeObjectAtIndex:0]; - [favorites sortUsingDescriptors:[NSArray arrayWithObject:sortDescriptor]]; - [favorites insertObject:first atIndex:0]; - - // Rebuild the favorites tree - [self _buildFavoritesTree]; - - [favoritesTable reloadData]; - - [favoritesTable expandItem:[[favoritesRoot nodeChildren] objectAtIndex:0]]; - - [first release]; + + // TODO: Perform actual sorting here + + [self _reloadFavoritesViewData]; } /** - * Builds a tree structure from the user's connection favorties by wrapping them in SPFavoriteNode instances. + * Updates the favorite's host when the type changes. */ -- (void)_buildFavoritesTree +- (void)_favoriteTypeDidChange { - if (favoritesRoot) [favoritesRoot release], favoritesRoot = nil; - - favoritesRoot = [[SPFavoriteNode alloc] init]; - - // Add a dummy item to represent the favorites heading - SPFavoriteNode *favoritesNode = [[SPFavoriteNode alloc] init]; - - [favoritesNode setNodeIsGroup:YES]; - [favoritesNode setNodeName:NSLocalizedString(@"FAVORITES", @"Favorites title at the top of the sidebar")]; - - for (NSDictionary *favorite in favorites) - { - SPFavoriteNode *node2 = [[SPFavoriteNode alloc] init]; - - [node2 setNodeFavorite:favorite]; - - [[favoritesNode nodeChildren] addObject:node2]; - - [node2 release]; + // TODO: Handle changing favorite connection types + + /*NSDictionary *favorite = [[[self selectedFavoriteNode] representedObject] nodeFavorite]; + + // If either socket or host is localhost, clear. + if ((selectedTabView != SPSocketConnection) && [[favorite objectForKey:SPFavoriteHostKey] isEqualToString:@"localhost"]) { + [self setHost:@""]; } + + // Update the name for newly added favorites if not already touched by the user, by trigger a KVO update + if (!favoriteNameFieldWasTouched) { + [self setName:[NSString stringWithFormat:@"%@@%@", + ([favorite objectForKey:SPFavoriteUserKey]) ? [favorite objectForKey:SPFavoriteUserKey] : @"", + ((previousType == SPSocketConnection) ? @"localhost" : + (([favorite objectForKey:SPFavoriteHostKey]) ? [favorite valueForKeyPath:SPFavoriteHostKey] : @"")) + ]]; + } + + // Request a password refresh to keep keychain references in synch with the favorites + [self _updateFavoritePasswordsFromField:nil];*/ +} - [[favoritesRoot nodeChildren] addObject:favoritesNode]; - - [favoritesNode release]; +/** + * Convenience method for rebuilding the connection favorites tree, reloading the outline view, expanding the + * items and scrolling to the selected item. + */ +- (void)_reloadFavoritesViewData +{ + [favoritesOutlineView reloadData]; + [favoritesOutlineView expandItem:[[favoritesRoot childNodes] objectAtIndex:0] expandChildren:YES]; + [favoritesOutlineView scrollRowToVisible:[favoritesOutlineView selectedRow]]; } /** @@ -1203,13 +1240,13 @@ { // Must be performed on the main thread if (![NSThread isMainThread]) return [[self onMainThread] _restoreConnectionInterface]; - + // Reset the window title - [[tableDocument parentWindow] setTitle:[tableDocument displayName]]; - + [[dbDocument parentWindow] setTitle:[dbDocument displayName]]; + // Stop the current tab's progress indicator - [tableDocument setIsProcessing:NO]; - + [dbDocument setIsProcessing:NO]; + // Reset the UI [addToFavoritesButton setHidden:NO]; [addToFavoritesButton display]; @@ -1222,47 +1259,56 @@ [progressIndicator display]; [progressIndicatorText setHidden:YES]; [progressIndicatorText display]; - + // Re-enable favorites table view - [favoritesTable setEnabled:YES]; - [favoritesTable display]; - + [favoritesOutlineView setEnabled:YES]; + [favoritesOutlineView display]; + mySQLConnectionCancelled = NO; - + // Revert the connect button back to its original selector [connectButton setAction:@selector(initiateConnection:)]; } /** + * Selected the supplied node in the favorites outline view. + */ +- (void)_selectNode:(SPTreeNode *)node +{ + [favoritesOutlineView selectRowIndexes:[NSIndexSet indexSetWithIndex:[favoritesOutlineView rowForItem:node]] byExtendingSelection:NO]; + [favoritesOutlineView scrollRowToVisible:[favoritesOutlineView selectedRow]]; +} + +/** * Called on the main thread once the MySQL connection is established on the background thread. Either the - * connection was cancelled or it was successful. + * connection was cancelled or it was successful. */ - (void)_mySQLConnectionEstablished -{ +{ isConnecting = NO; - - // If the user hit cancel during the connection attempt, kill the connection once + + // If the user hit cancel during the connection attempt, kill the connection once // established and reset the UI. - if (mySQLConnectionCancelled) { + if (mySQLConnectionCancelled) { if ([mySQLConnection isConnected]) { [mySQLConnection disconnect]; [mySQLConnection release], mySQLConnection = nil; } - + // Kill the SSH connection if present [self cancelConnection]; - + [self _restoreConnectionInterface]; - + return; } - + [progressIndicatorText setStringValue:NSLocalizedString(@"Connected", @"connection established message")]; [progressIndicatorText display]; - + // Stop the current tab's progress indicator - [tableDocument setIsProcessing:NO]; - + [dbDocument setIsProcessing:NO]; + // Successful connection! [connectButton setEnabled:NO]; [connectButton display]; @@ -1273,19 +1319,20 @@ // If SSL was enabled, check it was established correctly if (useSSL && ([self type] == SPTCPIPConnection || [self type] == SPSocketConnection)) { if (![mySQLConnection isConnectedViaSSL]) { - SPBeginAlertSheet(NSLocalizedString(@"SSL connection not established", @"SSL requested but not used title"), NSLocalizedString(@"OK", @"OK button"), nil, nil, [tableDocument parentWindow], nil, nil, nil, NSLocalizedString(@"You requested that the connection should be established using SSL, but MySQL made the connection without SSL.\n\nThis may be because the server does not support SSL connections, or has SSL disabled; or insufficient details were supplied to establish an SSL connection.\n\nThis connection is not encrypted.", @"SSL connection requested but not established error detail")); - } else { - [tableDocument setStatusIconToImageWithName:@"titlebarlock"]; + SPBeginAlertSheet(NSLocalizedString(@"SSL connection not established", @"SSL requested but not used title"), NSLocalizedString(@"OK", @"OK button"), nil, nil, [dbDocument parentWindow], nil, nil, nil, NSLocalizedString(@"You requested that the connection should be established using SSL, but MySQL made the connection without SSL.\n\nThis may be because the server does not support SSL connections, or has SSL disabled; or insufficient details were supplied to establish an SSL connection.\n\nThis connection is not encrypted.", @"SSL connection requested but not established error detail")); + } + else { + [dbDocument setStatusIconToImageWithName:@"titlebarlock"]; } } // Re-enable favorites table view - [favoritesTable setEnabled:YES]; - [favoritesTable display]; - + [favoritesOutlineView setEnabled:YES]; + [favoritesOutlineView display]; + // Release the tunnel if set - will now be retained by the connection if (sshTunnel) [sshTunnel release], sshTunnel = nil; - + // Pass the connection to the document and clean up the interface [self addConnectionToDocument]; } @@ -1296,11 +1343,11 @@ - (void)_initiateMySQLConnectionInBackground { NSAutoreleasePool *pool = [[NSAutoreleasePool alloc] init]; - + // Initialise to socket if appropriate. if ([self type] == SPSocketConnection) { mySQLConnection = [[MCPConnection alloc] initToSocket:[self socket] withLogin:[self user]]; - + // Otherwise, initialise to host, using tunnel if appropriate } else { if ([self type] == SPSSHTunnelConnection) { @@ -1311,11 +1358,11 @@ } else { mySQLConnection = [[MCPConnection alloc] initToHost:[self host] withLogin:[self user] - usingPort:([[self port] length]?[[self port] integerValue]:3306)]; + usingPort:([[self port] length] ? [[self port] integerValue] : 3306)]; } } - - // Only set the password if there is no Keychain item set. The connection will ask the delegate for passwords in the Keychain. + + // Only set the password if there is no Keychain item set. The connection will ask the delegate for passwords in the Keychain. if (!connectionKeychainItemName && [self password]) { [mySQLConnection setPassword:[self password]]; } @@ -1327,28 +1374,28 @@ certificatePath:[self sslCertificateFileLocationEnabled] ? [self sslCertificateFileLocation] : nil certificateAuthorityCertificatePath:[self sslCACertFileLocationEnabled] ? [self sslCACertFileLocation] : nil]; } - + // Connection delegate must be set before actual connection attempt is made - [mySQLConnection setDelegate:tableDocument]; + [mySQLConnection setDelegate:dbDocument]; // Set whether or not we should enable delegate logging according to the prefs [mySQLConnection setDelegateQueryLogging:[prefs boolForKey:SPConsoleEnableLogging]]; - + // Set options from preferences [mySQLConnection setConnectionTimeout:[[prefs objectForKey:SPConnectionTimeoutValue] integerValue]]; [mySQLConnection setUseKeepAlive:[[prefs objectForKey:SPUseKeepAlive] boolValue]]; [mySQLConnection setKeepAliveInterval:[[prefs objectForKey:SPKeepAliveInterval] doubleValue]]; - + // Connect [mySQLConnection connect]; - + if (![mySQLConnection isConnected]) { if (sshTunnel) { - + // If an SSH tunnel is running, temporarily block to allow the tunnel to register changes in state [[NSRunLoop currentRunLoop] runMode:NSModalPanelRunLoopMode beforeDate:[NSDate dateWithTimeIntervalSinceNow:0.2]]; - + // If the state is connection refused, attempt the MySQL connection again with the host using the hostfield value. if ([sshTunnel state] == PROXY_STATE_FORWARDING_FAILED) { if ([sshTunnel localPortFallback]) { @@ -1360,7 +1407,7 @@ } } } - + if (![mySQLConnection isConnected]) { NSString *errorMessage = @""; if (sshTunnel && [sshTunnel state] == PROXY_STATE_FORWARDING_FAILED) { @@ -1379,56 +1426,183 @@ errorMessage = [NSString stringWithFormat:NSLocalizedString(@"Unable to connect to host %@, or the request timed out.\n\nBe sure that the address is correct and that you have the necessary privileges, or try increasing the connection timeout (currently %ld seconds).\n\nMySQL said: %@", @"message of panel when connection to host failed"), [self host], (long)[[prefs objectForKey:SPConnectionTimeoutValue] integerValue], [mySQLConnection getLastErrorMessage]]; [[self onMainThread] failConnectionWithTitle:NSLocalizedString(@"Connection failed!", @"connection failed title") errorMessage:errorMessage detail:nil]; } - + // Tidy up isConnecting = NO; - + if (sshTunnel) [sshTunnel release], sshTunnel = nil; - + [mySQLConnection release], mySQLConnection = nil; [self _restoreConnectionInterface]; [pool release]; - + return; } } - + if ([self database] && ![[self database] isEqualToString:@""]) { if (![mySQLConnection selectDB:[self database]]) { [[self onMainThread] failConnectionWithTitle:NSLocalizedString(@"Could not select database", @"message when database selection failed") errorMessage:[NSString stringWithFormat:NSLocalizedString(@"Connected to host, but unable to connect to database %@.\n\nBe sure that the database exists and that you have the necessary privileges.\n\nMySQL said: %@", @"message of panel when connection to db failed"), [self database], [mySQLConnection getLastErrorMessage]] detail:nil]; - + // Tidy up isConnecting = NO; - + if (sshTunnel) [sshTunnel release], sshTunnel = nil; - + [mySQLConnection release], mySQLConnection = nil; [self _restoreConnectionInterface]; [pool release]; - + return; } } - + // Connection established [self performSelectorOnMainThread:@selector(_mySQLConnectionEstablished) withObject:nil waitUntilDone:NO]; - + [pool release]; } -@end +/** + * Creates a new favorite ID based on the UNIX epoch time. + */ +- (NSNumber *)_createNewFavoriteID +{ + return [NSNumber numberWithInteger:[[NSString stringWithFormat:@"%f", [[NSDate date] timeIntervalSince1970]] hash]]; +} -#pragma mark - -#pragma mark NSView subclass - flipped view for simpler drawing +/** + * Returns the favorite node for the conection favorite with the supplied ID. + */ +- (SPTreeNode *)_favoriteNodeForFavoriteID:(NSInteger)favoriteID +{ + SPTreeNode *node = nil; + + if (!favoritesRoot) return; + + for (node in [favoritesRoot allChildLeafs]) + { + if ([[[[node representedObject] nodeFavorite] objectForKey:SPFavoriteIDKey] integerValue] == favoriteID) { + return node; + } + } +} /** - * Add an implementation of a flipped view to simplify drawing. + * Check all fields used in the keychain names against the old values for that + * favorite, and update the keychain names to match if necessary. + * If an (optional) recognised password field is supplied, that field is assumed + * to have changed and is used to supply the new value. */ -@implementation SPFlippedView: NSView +- (void)_updateFavoritePasswordsFromField:(NSControl *)control +{ + if (!currentFavorite) return; + + NSDictionary *oldFavorite = [currentFavorite nodeFavorite]; + NSDictionary *newFavorite = [[[self selectedFavoriteNode] representedObject] nodeFavorite]; + + NSString *passwordValue; + NSString *oldKeychainName, *newKeychainName; + NSString *oldKeychainAccount, *newKeychainAccount; + NSString *oldHostnameForPassword = ([[oldFavorite objectForKey:SPFavoriteTypeKey] integerValue] == SPSocketConnection) ? @"localhost" : [oldFavorite objectForKey:SPFavoriteHostKey]; + NSString *newHostnameForPassword = ([[newFavorite objectForKey:SPFavoriteTypeKey] integerValue] == SPSocketConnection) ? @"localhost" : [newFavorite objectForKey:SPFavoriteHostKey]; + + // SQL passwords are indexed by name, host, user and database. If any of these + // have changed, or a standard password field has, alter the keychain item to match. + if (![[oldFavorite objectForKey:SPFavoriteNameKey] isEqualToString:[newFavorite objectForKey:SPFavoriteNameKey]] || + ![oldHostnameForPassword isEqualToString:newHostnameForPassword] || + ![[oldFavorite objectForKey:SPFavoriteUserKey] isEqualToString:[newFavorite objectForKey:SPFavoriteUserKey]] || + ![[oldFavorite objectForKey:SPFavoriteDatabaseKey] isEqualToString:[newFavorite objectForKey:SPFavoriteDatabaseKey]] || + control == standardPasswordField || control == socketPasswordField || control == sshPasswordField) + { + // Determine the correct password field to read the password from, defaulting to standard + if (control == socketPasswordField) { + passwordValue = [socketPasswordField stringValue]; + } + else if (control == sshPasswordField) { + passwordValue = [sshPasswordField stringValue]; + } + else { + passwordValue = [standardPasswordField stringValue]; + } + + // Get the old keychain name and account strings + oldKeychainName = [keychain nameForFavoriteName:[oldFavorite objectForKey:SPFavoriteNameKey] id:[newFavorite objectForKey:SPFavoriteIDKey]]; + oldKeychainAccount = [keychain accountForUser:[oldFavorite objectForKey:SPFavoriteUserKey] host:oldHostnameForPassword database:[oldFavorite objectForKey:SPFavoriteDatabaseKey]]; + + // Delete the old keychain item + [keychain deletePasswordForName:oldKeychainName account:oldKeychainAccount]; + + // Set up the new keychain name and account strings + newKeychainName = [keychain nameForFavoriteName:[newFavorite objectForKey:SPFavoriteNameKey] id:[newFavorite objectForKey:SPFavoriteIDKey]]; + newKeychainAccount = [keychain accountForUser:[newFavorite objectForKey:SPFavoriteUserKey] host:newHostnameForPassword database:[newFavorite objectForKey:SPFavoriteDatabaseKey]]; + + // Add the new keychain item if the password field has a value + if ([passwordValue length]) { + [keychain addPassword:passwordValue forName:newKeychainName account:newKeychainAccount]; + } + + // Synch password changes + [standardPasswordField setStringValue:passwordValue]; + [socketPasswordField setStringValue:passwordValue]; + [sshPasswordField setStringValue:passwordValue]; + + passwordValue = @""; + } + + // If SSH account/password details have changed, update the keychain to match + if (![[oldFavorite objectForKey:SPFavoriteNameKey] isEqualToString:[newFavorite objectForKey:SPFavoriteNameKey]] || + ![[oldFavorite objectForKey:SPFavoriteSSHHostKey] isEqualToString:[newFavorite objectForKey:SPFavoriteSSHHostKey]] || + ![[oldFavorite objectForKey:SPFavoriteSSHUserKey] isEqualToString:[newFavorite objectForKey:SPFavoriteSSHUserKey]] || + control == sshSSHPasswordField) + { + // Get the old keychain name and account strings + oldKeychainName = [keychain nameForSSHForFavoriteName:[oldFavorite objectForKey:SPFavoriteNameKey] id:[newFavorite objectForKey:SPFavoriteIDKey]]; + oldKeychainAccount = [keychain accountForSSHUser:[oldFavorite objectForKey:SPFavoriteSSHUserKey] sshHost:[oldFavorite objectForKey:SPFavoriteSSHHostKey]]; + + // Delete the old keychain item + [keychain deletePasswordForName:oldKeychainName account:oldKeychainAccount]; + + // Set up the new keychain name and account strings + newKeychainName = [keychain nameForSSHForFavoriteName:[newFavorite objectForKey:SPFavoriteNameKey] id:[newFavorite objectForKey:SPFavoriteIDKey]]; + newKeychainAccount = [keychain accountForSSHUser:[newFavorite objectForKey:SPFavoriteSSHUserKey] sshHost:[newFavorite objectForKey:SPFavoriteSSHHostKey]]; + + // Add the new keychain item if the password field has a value + if ([[sshPasswordField stringValue] length]) { + [keychain addPassword:[sshPasswordField stringValue] forName:newKeychainName account:newKeychainAccount]; + } + } + + // Update the current favorite + if (currentFavorite) [currentFavorite release], currentFavorite = nil; + + if ([[favoritesOutlineView selectedRowIndexes] count]) { + currentFavorite = [[[self selectedFavoriteNode] representedObject] copy]; + } +} + +#pragma mark - -- (BOOL)isFlipped +- (void)dealloc { - return YES; + [keychain release]; + [prefs release]; + + [folderImage release], folderImage = nil; + + for (id retainedObject in nibObjectsToRelease) [retainedObject release]; + + [nibObjectsToRelease release]; + + if (mySQLConnection) [mySQLConnection release]; + if (sshTunnel) [sshTunnel setConnectionStateChangeSelector:nil delegate:nil], [sshTunnel disconnect], [sshTunnel release]; + if (connectionKeychainItemName) [connectionKeychainItemName release]; + if (connectionKeychainItemAccount) [connectionKeychainItemAccount release]; + if (connectionSSHKeychainItemName) [connectionSSHKeychainItemName release]; + if (connectionSSHKeychainItemAccount) [connectionSSHKeychainItemAccount release]; + if (currentFavorite) [currentFavorite release], currentFavorite = nil; + + [super dealloc]; } @end diff --git a/Source/SPConnectionControllerDelegate.m b/Source/SPConnectionControllerDelegate.m index a2653c5a..65804eff 100644 --- a/Source/SPConnectionControllerDelegate.m +++ b/Source/SPConnectionControllerDelegate.m @@ -25,88 +25,11 @@ #import "SPConnectionControllerDelegate.h" #import "SPTableTextFieldCell.h" +#import "SPFavoriteNode.h" +#import "SPGroupNode.h" @implementation SPConnectionController (SPConnectionControllerDelegate) -/*#pragma mark - - #pragma mark TableView drag & drop delegate methods - - - (BOOL)tableView:(NSTableView *)aTableView writeRowsWithIndexes:(NSIndexSet *)rowIndexes toPasteboard:(NSPasteboard *)pboard - { - NSData *archivedData = [NSKeyedArchiver archivedDataWithRootObject:rowIndexes]; - [pboard declareTypes:[NSArray arrayWithObject:favoritesPBoardType] owner:self]; - [pboard setData:archivedData forType:favoritesPBoardType]; - return YES; - } - - - (NSDragOperation)tableView:(NSTableView *)aTableView validateDrop:(id <NSDraggingInfo>)info proposedRow:(NSInteger)row proposedDropOperation:(NSTableViewDropOperation)operation - { - if (row == 0) return NSDragOperationNone; - if ([info draggingSource] == aTableView) - { - [aTableView setDropRow:row dropOperation:NSTableViewDropAbove]; - return NSDragOperationMove; - } - return NSDragOperationNone; - } - - - (BOOL)tableView:(NSTableView *)aTableView acceptDrop:(id <NSDraggingInfo>)info row:(NSInteger)row dropOperation:(NSTableViewDropOperation)operation - { - BOOL acceptedDrop = NO; - - if ((row == 0) || ([info draggingSource] != aTableView)) return acceptedDrop; - - // Disable all automatic sorting - currentSortItem = -1; - reverseFavoritesSort = NO; - - [prefs setInteger:currentSortItem forKey:SPFavoritesSortedBy]; - [prefs setBool:NO forKey:SPFavoritesSortedInReverse]; - - // Remove sort descriptors - [favorites sortUsingDescriptors:[NSArray array]]; - - // Uncheck sort by menu items - for (NSMenuItem *menuItem in [[favoritesSortByMenuItem submenu] itemArray]) - { - [menuItem setState:NSOffState]; - } - - NSPasteboard* pboard = [info draggingPasteboard]; - NSData* rowData = [pboard dataForType:favoritesPBoardType]; - NSIndexSet* rowIndexes = [NSKeyedUnarchiver unarchiveObjectWithData:rowData]; - NSInteger dragRow = [rowIndexes firstIndex]; - NSInteger defaultConnectionRow = [prefs integerForKey:SPLastFavoriteIndex]; - if (defaultConnectionRow == dragRow) - { - [prefs setInteger:row forKey:SPLastFavoriteIndex]; - } - NSMutableDictionary *draggedFavorite = [favorites objectAtIndex:dragRow]; - [favorites removeObjectAtIndex:dragRow]; - if (row > dragRow) - { - row--; - } - [favorites insertObject:draggedFavorite atIndex:row]; - [aTableView reloadData]; - - // reset the prefs with the new order - NSMutableArray *reorderedFavorites = [[NSMutableArray alloc] initWithArray:favorites]; - [reorderedFavorites removeObjectAtIndex:0]; - [prefs setObject:reorderedFavorites forKey:SPFavorites]; - - [[[[NSApp delegate] preferenceController] generalPreferencePane] updateDefaultFavoritePopup]; - - [reorderedFavorites release]; - - [self updateFavorites]; - [aTableView selectRowIndexes:[NSIndexSet indexSetWithIndex:row] byExtendingSelection:NO]; - - acceptedDrop = YES; - - return acceptedDrop; - }*/ - #pragma mark - #pragma mark SplitView delegate methods @@ -144,81 +67,464 @@ - (NSInteger)outlineView:(NSOutlineView *)outlineView numberOfChildrenOfItem:(id)item { - SPFavoriteNode *node = (item == nil ? favoritesRoot : (SPFavoriteNode *)item); + SPTreeNode *node = (item == nil ? favoritesRoot : (SPTreeNode *)item); - return [[node nodeChildren] count]; + return [[node childNodes] count]; } - (id)outlineView:(NSOutlineView *)outlineView child:(NSInteger)index ofItem:(id)item { - SPFavoriteNode *node = (item == nil ? favoritesRoot : (SPFavoriteNode *)item); + SPTreeNode *node = (item == nil ? favoritesRoot : (SPTreeNode *)item); - return NSArrayObjectAtIndex([node nodeChildren], index); + return NSArrayObjectAtIndex([node childNodes], index); } - (BOOL)outlineView:(NSOutlineView *)outlineView isItemExpandable:(id)item { - return [(SPFavoriteNode *)item nodeIsGroup]; + return [(SPTreeNode *)item isGroup]; } - (id)outlineView:(NSOutlineView *)outlineView objectValueForTableColumn:(NSTableColumn *)tableColumn byItem:(id)item { - SPFavoriteNode *node = (SPFavoriteNode *)item; + SPTreeNode *node = (SPTreeNode *)item; + + return (![node isGroup]) ? [[[node representedObject] nodeFavorite] objectForKey:SPFavoriteNameKey] : [[node representedObject] nodeName]; +} + +- (void)outlineView:(NSOutlineView *)outlineView setObjectValue:(id)object forTableColumn:(NSTableColumn *)tableColumn byItem:(id)item +{ + // Trim whitespace + NSString *newName = [object stringByTrimmingCharactersInSet:[NSCharacterSet whitespaceAndNewlineCharacterSet]]; - return ([node nodeIsGroup]) ? [node nodeName] : [[node nodeFavorite] objectForKey:SPFavoriteNameKey]; + if ([newName length]) { + + // Get the node that was renamed + SPTreeNode *node = [self selectedFavoriteNode]; + + if (![node isGroup]) { + // Updating the name triggers a KVO update + [self setName:newName]; + + // Update associated Keychain items + [self _updateFavoritePasswordsFromField:nil]; + } + else { + [[node representedObject] setNodeName:newName]; + + [favoritesController saveFavorites]; + + [self _reloadFavoritesViewData]; + } + } } #pragma mark - #pragma mark Outline view delegate methods - (BOOL)outlineView:(NSOutlineView *)outlineView isGroupItem:(id)item -{ - return [(SPFavoriteNode *)item nodeIsGroup]; +{ + return ([[(SPTreeNode *)item parentNode] parentNode] == nil); } - (void)outlineViewSelectionDidChange:(NSNotification *)notification -{ - if ([favoritesTable numberOfSelectedRows] == 1) { - [self updateFavoriteSelection:self]; +{ + if ([favoritesOutlineView numberOfSelectedRows] == 1) { + + SPTreeNode *node = [self selectedFavoriteNode]; - [addToFavoritesButton setEnabled:NO]; - } + if (![node isGroup]) { + [self updateFavoriteSelection:self]; + + [addToFavoritesButton setEnabled:NO]; + + favoriteNameFieldWasTouched = YES; + + [connectionResizeContainer setHidden:NO]; + [connectionInstructionsTextField setStringValue:NSLocalizedString(@"Enter connection details below, or choose a favorite", @"enter connection details label")]; + } + else { + [connectionResizeContainer setHidden:YES]; + [connectionInstructionsTextField setStringValue:NSLocalizedString(@"Please choose a favorite", @"please choose a favorite connection view label")]; + } + } else { - [addToFavoritesButton setEnabled:YES]; + [connectionResizeContainer setHidden:YES]; + [connectionInstructionsTextField setStringValue:NSLocalizedString(@"Please choose a favorite", @"please choose a favorite connection view label")]; } } - (void)outlineView:(NSOutlineView *)outlineView willDisplayCell:(id)cell forTableColumn:(NSTableColumn *)tableColumn item:(id)item { + SPTreeNode *node = (SPTreeNode *)item; + [(SPTableTextFieldCell *)cell setFont:[NSFont systemFontOfSize:[NSFont smallSystemFontSize]]]; - if ([favoritesTable isEnabled]) { - [(SPTableTextFieldCell *)cell setTextColor:[NSColor blackColor]]; + [(SPTableTextFieldCell *)cell setTextColor:([favoritesOutlineView isEnabled]) ? [NSColor blackColor] : [NSColor grayColor]]; + + if (![[node parentNode] parentNode]) { + [(SPTableTextFieldCell *)cell setImage:nil]; } else { - [(SPTableTextFieldCell *)cell setTextColor:[NSColor grayColor]]; - } - - [(SPTableTextFieldCell *)cell setImage:([(SPFavoriteNode *)item nodeIsGroup]) ? nil : [NSImage imageNamed:@"database-small"]]; + [(SPTableTextFieldCell *)cell setImage:(![node isGroup]) ? [NSImage imageNamed:@"database-small"] : folderImage]; + } } - (CGFloat)outlineView:(NSOutlineView *)outlineView heightOfRowByItem:(id)item { - return ([item nodeIsGroup]) ? 22 : 17; + return ((SPTreeNode *)[[item parentNode] parentNode] == nil) ? 22 : 17; +} + +- (NSString *)outlineView:(NSOutlineView *)outlineView toolTipForCell:(NSCell *)cell rect:(NSRectPointer)rect tableColumn:(NSTableColumn *)tableColumn item:(id)item mouseLocation:(NSPoint)mouseLocation +{ + SPTreeNode *node = (SPTreeNode *)item; + + if (![node isGroup]) { + return [[[node representedObject] nodeFavorite] objectForKey:SPFavoriteNameKey]; + } + else { + NSUInteger favCount = [[node childNodes] count]; + + return [NSString stringWithFormat:@"%@ - %d %@", [[node representedObject] nodeName], favCount, (favCount == 1) ? NSLocalizedString(@"favorite", @"favorite singular label") : NSLocalizedString(@"favorites", @"favorites plural label")]; + } } - (BOOL)outlineView:(NSOutlineView *)outlineView shouldSelectItem:(id)item +{ + return ([[item parentNode] parentNode] != nil); +} + +#pragma mark - +#pragma mark Outline view drag & drop + +/*- (BOOL)outlineView:(NSOutlineView *)outlineView writeItems:(NSArray *)items toPasteboard:(NSPasteboard *)pboard +{ + [pboard declareTypes:[NSArray arrayWithObject:SPFavoritesPasteboardDragType] owner:self]; + [pboard setData:[NSData data] forType:SPFavoritesPasteboardDragType]; + + return YES; +} + +- (NSDragOperation)outlineView:(NSOutlineView *)outlineView validateDrop:(id <NSDraggingInfo>)info proposedItem:(id)item proposedChildIndex:(NSInteger)index { - return (![item nodeIsGroup]); + NSDragOperation result = NSDragOperationNone; + + if ([info draggingSource] == outlineView) { + [outlineView setDropItem:item dropChildIndex:index]; + + result = NSDragOperationMove; + } + + return result; } +- (BOOL)outlineView:(NSOutlineView *)outlineView acceptDrop:(id <NSDraggingInfo>)info item:(id)item childIndex:(NSInteger)index +{ + BOOL acceptedDrop = NO; + + if ((!item) || ([info draggingSource] != outlineView)) return acceptedDrop; + + SPTreeNode *node = (item) ? item : [[[[favoritesRoot childNodes] objectAtIndex:0] childNodes] objectAtIndex:0]; + + // TODO: Fix me, disable automatic sorting + + // Disable all automatic sorting + //currentSortItem = -1; + //reverseFavoritesSort = NO; + + //[prefs setInteger:currentSortItem forKey:SPFavoritesSortedBy]; + //[prefs setBool:NO forKey:SPFavoritesSortedInReverse]; + + // Remove sort descriptors + //[favorites sortUsingDescriptors:[NSArray array]]; + + // Uncheck sort by menu items + for (NSMenuItem *menuItem in [[favoritesSortByMenuItem submenu] itemArray]) + { + [menuItem setState:NSOffState]; + } + + NSArray *nodes = [self selectedFavoriteNodes]; + + if ([node isGroup]) { + if (index == NSOutlineViewDropOnItemIndex) { + index = 0; + } + else { + SPTreeNode *oldNode = node; + + node = [node parentNode]; + index = ([[node childNodes] indexOfObject:oldNode] + 1); + } + } + else { + if (index == NSOutlineViewDropOnItemIndex) { + index = 0; + } + } + + NSMutableArray *childNodeArray = [node mutableChildNodes]; + + for (SPTreeNode *treeNode in nodes) + { + // Remove the node from its old location + NSInteger oldIndex = [childNodeArray indexOfObject:treeNode]; + NSInteger newIndex = index; + + if (oldIndex != NSNotFound) { + + [childNodeArray removeObjectAtIndex:oldIndex]; + + if (index > oldIndex) { + newIndex--; + } + } + else { + [[[treeNode parentNode] mutableChildNodes] removeObject:treeNode]; + } + + [childNodeArray insertObject:treeNode atIndex:newIndex]; + + newIndex++; + } + + [favoritesController saveFavorites]; + + [self _reloadFavoritesViewData]; + + [[[[NSApp delegate] preferenceController] generalPreferencePane] updateDefaultFavoritePopup]; + + acceptedDrop = YES; + + return acceptedDrop; +}*/ + +#pragma mark - +#pragma mark Textfield delegate methods /** - * Double-Click opens the connection. + * Trap and control the 'name' field of the selected favorite. If the user pressed + * 'Add Favorite' the 'name' field is set to 'New Favorite'. If the user did not + * change the 'name' field or delete that field it will be set to user@host automatically. */ -- (BOOL)outlineView:(NSOutlineView *)outlineView shouldEditTableColumn:(NSTableColumn *)tableColumn item:(id)item +- (void)controlTextDidChange:(NSNotification *)notification { - [self initiateConnection:self]; - return NO; + id field = [notification object]; + + NSMutableDictionary *favorite = [self selectedFavorite]; + + BOOL nameFieldIsEmpty = [[favorite objectForKey:SPFavoriteNameKey] isEqualToString:@""]; + + switch (previousType) + { + case SPTCPIPConnection: + + nameFieldIsEmpty = (nameFieldIsEmpty || [[standardNameField stringValue] isEqualToString:@""]); + + if (nameFieldIsEmpty || (!favoriteNameFieldWasTouched && (field == standardUserField || field == standardSQLHostField))) { + [standardNameField setStringValue:[NSString stringWithFormat:@"%@@%@", [standardUserField stringValue], [standardSQLHostField stringValue]]]; + + // Trigger KVO update + [self setName:[standardNameField stringValue]]; + + // If name field is empty enable user@host update + if (nameFieldIsEmpty) favoriteNameFieldWasTouched = NO; + } + + break; + case SPSocketConnection: + + nameFieldIsEmpty = (nameFieldIsEmpty || [[socketNameField stringValue] isEqualToString:@""]); + + if (nameFieldIsEmpty || (!favoriteNameFieldWasTouched && field == socketUserField)) { + [socketNameField setStringValue:[NSString stringWithFormat:@"%@@localhost", [socketUserField stringValue]]]; + + // Trigger KVO update + [self setName:[socketNameField stringValue]]; + + // If name field is empty enable user@host update + if (nameFieldIsEmpty) favoriteNameFieldWasTouched = NO; + } + + break; + case SPSSHTunnelConnection: + + nameFieldIsEmpty = (nameFieldIsEmpty || [[sshNameField stringValue] isEqualToString:@""]); + + if (nameFieldIsEmpty || (!favoriteNameFieldWasTouched && (field == sshUserField || field == sshSQLHostField))) { + [sshNameField setStringValue:[NSString stringWithFormat:@"%@@%@", [sshUserField stringValue], [sshSQLHostField stringValue]]]; + + // Trigger KVO update + [self setName:[sshNameField stringValue]]; + + // If name field is empty enable user@host update + if (nameFieldIsEmpty) favoriteNameFieldWasTouched = NO; + } + + break; + default: + break; + } + + if ((field == standardNameField) || (field == socketNameField) || (field == sshNameField)) favoriteNameFieldWasTouched = YES; } + +/** + * When a host field finishes editing, ensure that it hasn't been set to "localhost" + * to ensure that socket connections don't inadvertently occur. + */ +- (void)controlTextDidEndEditing:(NSNotification *)notification +{ + if ([notification object] == standardSQLHostField || [notification object] == sshSQLHostField) { + [self _checkHost]; + } +} + +/** + * Trap editing end notifications and use them to update the keychain password + * appropriately when name, host, user, password or database changes. + */ +- (BOOL)control:(NSControl *)control textShouldEndEditing:(NSText *)fieldEditor +{ + if (control != favoritesOutlineView) { + // Request a password refresh to keep keychain references in synch with favorites + [self _updateFavoritePasswordsFromField:control]; + } + + // Proceed with editing + return YES; +} + +#pragma mark - +#pragma mark Tab bar delegate methods + +/** + * Trigger a resize action whenever the tab view changes. The connection + * detail forms are held within container views, which are of a fixed width; + * the tabview and buttons are contained within a resizable view which + * is set to dimensions based on the container views, allowing the view + * to be sized according to the detail type. + */ +- (void)tabView:(NSTabView *)tabView didSelectTabViewItem:(NSTabViewItem *)tabViewItem +{ + NSInteger selectedTabView = [tabView indexOfTabViewItem:tabViewItem]; + + // Deselect any selected favorite for manual changes + if (!automaticFavoriteSelection) [favoritesOutlineView deselectAll:self]; + automaticFavoriteSelection = NO; + + if (selectedTabView == previousType) return; + + [self resizeTabViewToConnectionType:selectedTabView animating:YES]; + + // Update the host as appropriate + if ((selectedTabView != SPSocketConnection) && [[self host] isEqualToString:@"localhost"]) { + [self setHost:@""]; + } + + previousType = selectedTabView; + + [self _favoriteTypeDidChange]; +} + +#pragma mark - +#pragma mark Scroll view notifications + +/** + * As the scrollview resizes, keep the details centered within it if + * the detail frame is larger than the scrollview size; otherwise, pin + * the detail frame to the top of the scrollview. + */ +- (void)scrollViewFrameChanged:(NSNotification *)aNotification +{ + NSRect scrollViewFrame = [connectionDetailsScrollView frame]; + NSRect scrollDocumentFrame = [[connectionDetailsScrollView documentView] frame]; + NSRect connectionDetailsFrame = [connectionResizeContainer frame]; + + // Scroll view is smaller than contents - keep positioned at top. + if (scrollViewFrame.size.height < connectionDetailsFrame.size.height + 10) { + if (connectionDetailsFrame.origin.y != 0) { + connectionDetailsFrame.origin.y = 0; + [connectionResizeContainer setFrame:connectionDetailsFrame]; + scrollDocumentFrame.size.height = connectionDetailsFrame.size.height + 10; + [[connectionDetailsScrollView documentView] setFrame:scrollDocumentFrame]; + } + } + // Otherwise, center + else { + connectionDetailsFrame.origin.y = (scrollViewFrame.size.height - connectionDetailsFrame.size.height)/3; + [connectionResizeContainer setFrame:connectionDetailsFrame]; + scrollDocumentFrame.size.height = scrollViewFrame.size.height; + [[connectionDetailsScrollView documentView] setFrame:scrollDocumentFrame]; + } +} + +#pragma mark - +#pragma mark Menu Validation + +/** + * Menu item validation. + */ +- (BOOL)validateMenuItem:(NSMenuItem *)menuItem +{ + SEL action = [menuItem action]; + + SPTreeNode *node = [self selectedFavoriteNode]; + + if ((action == @selector(sortFavorites:)) || (action == @selector(reverseSortFavorites:))) { + + // TODO: Fix me, disabled because of new outline view + return NO; + + // Loop all the items in the sort by menu only checking the currently selected one + for (NSMenuItem *item in [[menuItem menu] itemArray]) + { + [item setState:([[menuItem menu] indexOfItem:item] == currentSortItem) ? NSOnState : NSOffState]; + } + + // Check or uncheck the reverse sort item + if (action == @selector(reverseSortFavorites:)) { + [menuItem setState:reverseFavoritesSort]; + } + } + + // Remove the selected favorite + if (action == @selector(removeNode:)) { + return ([favoritesOutlineView numberOfSelectedRows] == 1); + } + + // Duplicate and make the selected favorite the default + if (action == @selector(duplicateFavorite:)) { + return (([favoritesOutlineView numberOfSelectedRows] == 1) && (![node isGroup])); + } + + // Make selected favorite the default + if (action == @selector(makeSelectedFavoriteDefault:)) { + NSInteger favoriteID = [[[self selectedFavorite] objectForKey:SPFavoriteIDKey] integerValue]; + + return (([favoritesOutlineView numberOfSelectedRows] == 1) && (![node isGroup]) && (favoriteID != [prefs integerForKey:SPDefaultFavorite])); + } + + // Rename selected favorite/group + if (action == @selector(renameFavorite:)) { + return ([favoritesOutlineView numberOfSelectedRows] == 1); + } + + // Favorites export + if (action == @selector(exportFavorites:)) { + + NSInteger rows = [favoritesOutlineView numberOfSelectedRows]; + + if (rows > 1) { + [menuItem setTitle:NSLocalizedString(@"Export Selected...", @"export selected favorites menu item")]; + } + else if (rows == 1) { + return (![[self selectedFavoriteNode] isGroup]); + } + + return YES; + } + + return YES; +} + @end diff --git a/Source/SPConnectionHandler.h b/Source/SPConnectionHandler.h new file mode 100644 index 00000000..07bba90e --- /dev/null +++ b/Source/SPConnectionHandler.h @@ -0,0 +1,44 @@ +// +// $Id$ +// +// SPConnectionHandler.h +// sequel-pro +// +// Created by Stuart Connolly (stuconnolly.com) on November 15, 2010 +// Copyright (c) 2010 Stuart Connolly. All rights reserved. +// +// This program is free software; you can redistribute it and/or modify +// it under the terms of the GNU General Public License as published by +// the Free Software Foundation; either version 2 of the License, or +// (at your option) any later version. +// +// This program is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +// GNU General Public License for more details. +// +// You should have received a copy of the GNU General Public License +// along with this program; if not, write to the Free Software +// Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA +// +// More info at <http://code.google.com/p/sequel-pro/> + +#import "SPConnectionController.h" + +/** + * @category SPConnectionHandler SPConnectionHandler.h + * + * @author Stuart Connolly http://stuconnolly.com/ + * + * Connection handler category. Handles all connection related non-interface processes. + */ +@interface SPConnectionController (SPConnectionHandler) + +- (void)initiateSSHTunnelConnection; +- (void)sshTunnelCallback:(SPSSHTunnel *)theTunnel; +- (void)initiateMySQLConnection; +- (void)cancelConnection; +- (void)failConnectionWithTitle:(NSString *)theTitle errorMessage:(NSString *)theErrorMessage detail:(NSString *)errorDetail; +- (void)addConnectionToDocument; + +@end diff --git a/Source/SPConnectionHandler.m b/Source/SPConnectionHandler.m new file mode 100644 index 00000000..818e528f --- /dev/null +++ b/Source/SPConnectionHandler.m @@ -0,0 +1,245 @@ +// +// $Id$ +// +// SPConnectionHandler.m +// sequel-pro +// +// Created by Stuart Connolly (stuconnolly.com) on November 15, 2010 +// Copyright (c) 2010 Stuart Connolly. All rights reserved. +// +// This program is free software; you can redistribute it and/or modify +// it under the terms of the GNU General Public License as published by +// the Free Software Foundation; either version 2 of the License, or +// (at your option) any later version. +// +// This program is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +// GNU General Public License for more details. +// +// You should have received a copy of the GNU General Public License +// along with this program; if not, write to the Free Software +// Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA +// +// More info at <http://code.google.com/p/sequel-pro/> + +#import "SPConnectionHandler.h" +#import "SPAlertSheets.h" + +@implementation SPConnectionController (SPConnectionHandler) + +/* + * Initiate the SSH connection process. + * This should only be called as part of initiateConnection:, and will indirectly + * call initiateMySQLConnection if it's successful. + */ +- (void)initiateSSHTunnelConnection +{ + [progressIndicatorText setStringValue:NSLocalizedString(@"SSH connecting...", @"SSH connecting very short status message")]; + [progressIndicatorText display]; + + // Trim whitespace and newlines from the SSH host field before attempting to connect + [self setSshHost:[[self sshHost] stringByTrimmingCharactersInSet:[NSCharacterSet whitespaceAndNewlineCharacterSet]]]; + + // Set up the tunnel details + sshTunnel = [[SPSSHTunnel alloc] initToHost:[self sshHost] port:[[self sshPort] integerValue] login:[self sshUser] tunnellingToPort:([[self port] length]?[[self port] integerValue]:3306) onHost:[self host]]; + [sshTunnel setParentWindow:[dbDocument parentWindow]]; + + // Add keychain or plaintext password as appropriate - note the checks in initiateConnection. + if (connectionSSHKeychainItemName) { + [sshTunnel setPasswordKeychainName:connectionSSHKeychainItemName account:connectionSSHKeychainItemAccount]; + } else if (sshPassword) { + [sshTunnel setPassword:[self sshPassword]]; + } + + // Set the public key path if appropriate + if (sshKeyLocationEnabled && sshKeyLocation) { + [sshTunnel setKeyFilePath:sshKeyLocation]; + } + + // Set the callback function on the tunnel + [sshTunnel setConnectionStateChangeSelector:@selector(sshTunnelCallback:) delegate:self]; + + // Ask the tunnel to connect. This will call the callback below on success or failure, passing + // itself as an argument - retain count should be one at this point. + [sshTunnel connect]; +} + +/* + * Cancel connection. + * Currently only cleans up the SSH connection (MySQL connection isn't threaded) + */ +- (void)cancelConnection +{ + if (!sshTunnel) return; + + cancellingConnection = YES; + + [sshTunnel disconnect]; + [sshTunnel release]; + + sshTunnel = nil; +} + +/* + * A callback function for the SSH Tunnel setup process - will be called on a connection + * state change, allowing connection to fail or proceed as appropriate. If successful, + * will call initiateMySQLConnection. + */ +- (void)sshTunnelCallback:(SPSSHTunnel *)theTunnel +{ + if (cancellingConnection) return; + + NSInteger newState = [theTunnel state]; + + if (newState == PROXY_STATE_IDLE) { + [dbDocument setTitlebarStatus:NSLocalizedString(@"SSH Disconnected", @"SSH disconnected titlebar marker")]; + + [self failConnectionWithTitle:NSLocalizedString(@"SSH connection failed!", @"SSH connection failed title") errorMessage:[theTunnel lastError] detail:[sshTunnel debugMessages]]; + } + else if (newState == PROXY_STATE_CONNECTED) { + [dbDocument setTitlebarStatus:NSLocalizedString(@"SSH Connected", @"SSH connected titlebar marker")]; + + [self initiateMySQLConnection]; + } + else { + [dbDocument setTitlebarStatus:NSLocalizedString(@"SSH Connecting…", @"SSH connecting titlebar marker")]; + } +} + +/* + * Set up the MySQL connection, either through a successful tunnel or directly in the background. + */ +- (void)initiateMySQLConnection +{ + // Disable the favorites table view to prevent further connections attempts + [favoritesOutlineView setEnabled:NO]; + + if (sshTunnel) { + [progressIndicatorText setStringValue:NSLocalizedString(@"MySQL connecting...", @"MySQL connecting very short status message")]; + } + else { + [progressIndicatorText setStringValue:NSLocalizedString(@"Connecting...", @"Generic connecting very short status message")]; + } + + [progressIndicatorText display]; + + [connectButton setTitle:NSLocalizedString(@"Cancel", @"cancel button")]; + [connectButton setAction:@selector(cancelMySQLConnection:)]; + [connectButton setEnabled:YES]; + [connectButton display]; + + [NSThread detachNewThreadSelector:@selector(_initiateMySQLConnectionInBackground) toTarget:self withObject:nil]; +} + +/* + * Ends a connection attempt by stopping the connection animation and + * displaying a specified error message. + */ +- (void)failConnectionWithTitle:(NSString *)theTitle errorMessage:(NSString *)theErrorMessage detail:(NSString *)errorDetail +{ + BOOL isSSHTunnelBindError = NO; + + // Clean up the interface + [progressIndicator stopAnimation:self]; + [progressIndicator display]; + [progressIndicatorText setHidden:YES]; + [progressIndicatorText display]; + [addToFavoritesButton setHidden:NO]; + [addToFavoritesButton display]; + [connectButton setEnabled:YES]; + [dbDocument clearStatusIcon]; + + // Release as appropriate + if (sshTunnel) { + [sshTunnel disconnect], [sshTunnel release], sshTunnel = nil; + + // If the SSH tunnel connection failed because the port it was trying to bind to was already in use take note + // of it so we can give the user the option of connecting via standard connection and use the existing tunnel. + if ([theErrorMessage rangeOfString:@"bind"].location != NSNotFound) { + isSSHTunnelBindError = YES; + } + } + + if (errorDetail) [errorDetailText setString:errorDetail]; + + // Inform the delegate that the connection attempt failed + if (delegate && [delegate respondsToSelector:@selector(connectionControllerConnectAttemptFailed:)]) { + [delegate connectionControllerConnectAttemptFailed:self]; + } + + // Only display the connection error message if there is a window visible and the connection attempt + // wasn't cancelled even though it failed. + if ([[dbDocument parentWindow] isVisible] && (!mySQLConnectionCancelled)) { + SPBeginAlertSheet(theTitle, NSLocalizedString(@"OK", @"OK button"), (errorDetail) ? NSLocalizedString(@"Show Detail", @"Show detail button") : nil, (isSSHTunnelBindError) ? NSLocalizedString(@"Use Standard Connection", @"use standard connection button") : nil, [dbDocument parentWindow], self, @selector(connectionFailureSheetDidEnd:returnCode:contextInfo:), @"connect", theErrorMessage); + } +} + +/** + * Alert sheet callback method - invoked when an error sheet is closed. + */ +- (void)connectionFailureSheetDidEnd:(NSAlert *)alert returnCode:(NSInteger)returnCode contextInfo:(void *)contextInfo +{ + // Restore the passwords from keychain for editing if appropriate + if (connectionKeychainItemName) { + [self setPassword:[keychain getPasswordForName:connectionKeychainItemName account:connectionKeychainItemAccount]]; + } + if (connectionSSHKeychainItemName) { + [self setSshPassword:[keychain getPasswordForName:connectionSSHKeychainItemName account:connectionSSHKeychainItemAccount]]; + } + + if (returnCode == NSAlertAlternateReturn) { + [errorDetailText setFont:[NSFont userFontOfSize:12]]; + [errorDetailText setAlignment:NSLeftTextAlignment]; + [errorDetailWindow makeKeyAndOrderFront:self]; + } + // Currently only SSH port bind errors offer a 3rd option in the error dialog, but if this ever changes + // this will definitely need to be updated. + else if (returnCode == NSAlertOtherReturn) { + // Extract the local port number that SSH attempted to bind to from the debug output + NSString *tunnelPort = [[[errorDetailText string] componentsMatchedByRegex:@"LOCALHOST:([0-9]+)" capture:1L] lastObject]; + + // Change the connection type to standard TCP/IP + [self setType:SPTCPIPConnection]; + + // Change connection details + [self setPort:tunnelPort]; + [self setHost:@"127.0.0.1"]; + + // Change to standard TCP/IP connection view + [self resizeTabViewToConnectionType:SPTCPIPConnection animating:YES]; + + // Initiate the connection after half a second to give the connection view a chance to resize + [self performSelector:@selector(initiateConnection:) withObject:self afterDelay:0.5]; + } +} + +/** + * Add the connection to the parent document and restore the + * interface, allowing the application to run as normal. + */ +- (void)addConnectionToDocument +{ + // Hide the connection view and restore the main view + [connectionView removeFromSuperviewWithoutNeedingDisplay]; + [databaseConnectionView setHidden:NO]; + + // Restore the toolbar icons + NSArray *toolbarItems = [[[dbDocument parentWindow] toolbar] items]; + + for (NSInteger i = 0; i < [toolbarItems count]; i++) [[toolbarItems objectAtIndex:i] setEnabled:YES]; + + // Set keychain id for saving SPF files + if ([self valueForKeyPath:@"selectedFavorite.id"]) { + [dbDocument setKeychainID:[[self valueForKeyPath:@"selectedFavorite.id"] stringValue]]; + } + else { + [dbDocument setKeychainID:@""]; + } + + // Pass the connection to the table document, allowing it to set + // up the other classes and the rest of the interface. + [dbDocument setConnection:mySQLConnection]; +} + +@end diff --git a/Source/SPConstants.h b/Source/SPConstants.h index 1e48f2c2..09763e45 100644 --- a/Source/SPConstants.h +++ b/Source/SPConstants.h @@ -218,10 +218,6 @@ extern const CGFloat SPLongRunningNotificationTime; // Narrow down completion max rows extern const NSUInteger SPNarrowDownCompletionMaxRows; -// Kill mode constants -extern NSString *SPKillProcessQueryMode; -extern NSString *SPKillProcessConnectionMode; - // Default monospaced font name extern NSString *SPDefaultMonospacedFontName; @@ -253,7 +249,7 @@ extern NSString *SPDataSupportFolder; // General Prefpane extern NSString *SPDefaultFavorite; extern NSString *SPSelectLastFavoriteUsed; -extern NSString *SPLastFavoriteIndex; +extern NSString *SPLastFavoriteID; extern NSString *SPAutoConnectToDefault; extern NSString *SPDefaultViewMode; extern NSString *SPLastViewMode; diff --git a/Source/SPConstants.m b/Source/SPConstants.m index cd683a5b..1ef054bb 100644 --- a/Source/SPConstants.m +++ b/Source/SPConstants.m @@ -31,10 +31,6 @@ const CGFloat SPLongRunningNotificationTime = 3.0; // Narrow down completion max rows const NSUInteger SPNarrowDownCompletionMaxRows = 15; -// Kill mode constants -NSString *SPKillProcessQueryMode = @"SPKillProcessQueryMode"; -NSString *SPKillProcessConnectionMode = @"SPKillProcessConnectionMode"; - // Default monospaced font name NSString *SPDefaultMonospacedFontName = @"Monaco"; @@ -65,7 +61,7 @@ NSString *SPDataSupportFolder = @"Data"; // General Prefpane NSString *SPDefaultFavorite = @"DefaultFavorite"; NSString *SPSelectLastFavoriteUsed = @"SelectLastFavoriteUsed"; -NSString *SPLastFavoriteIndex = @"LastFavoriteIndex"; +NSString *SPLastFavoriteID = @"LastFavoriteID"; NSString *SPAutoConnectToDefault = @"AutoConnectToDefault"; NSString *SPDefaultViewMode = @"DefaultViewMode"; NSString *SPLastViewMode = @"LastViewMode"; diff --git a/Source/SPDatabaseDocument.m b/Source/SPDatabaseDocument.m index 5f05573c..f1ac803f 100644 --- a/Source/SPDatabaseDocument.m +++ b/Source/SPDatabaseDocument.m @@ -3252,7 +3252,7 @@ if ([connectionController selectedFavorite]) return; // Request the connection controller to add its details to favorites - [connectionController addFavorite:self]; + [connectionController addFavoriteUsingCurrentDetails:self]; } /** @@ -3826,7 +3826,7 @@ { // If the window is being set for the first time - connection controller is visible - update focus if (!parentWindow && !mySQLConnection) { - [aWindow makeFirstResponder:[connectionController valueForKey:@"favoritesTable"]]; + [aWindow makeFirstResponder:[connectionController valueForKey:@"favoritesOutlineView"]]; [connectionController performSelector:@selector(updateFavoriteSelection:) withObject:self afterDelay:0.0]; } @@ -4105,12 +4105,12 @@ [self updateWindowTitle:self]; // Deselect all favorites on the connection controller - [[connectionController valueForKeyPath:@"favoritesTable"] deselectAll:connectionController]; + [[connectionController valueForKeyPath:@"favoritesOutlineView"] deselectAll:connectionController]; // Suppress the possibility to choose an other connection from the favorites // if a connection should initialized by SPF file. Otherwise it could happen // that the SPF file runs out of sync. - [[connectionController valueForKeyPath:@"favoritesTable"] setEnabled:NO]; + [[connectionController valueForKeyPath:@"favoritesOutlineView"] setEnabled:NO]; // Ensure the connection controller is set to a blank slate [connectionController setName:@""]; diff --git a/Source/SPFavoriteNode.h b/Source/SPFavoriteNode.h index d3b25854..5387c137 100644 --- a/Source/SPFavoriteNode.h +++ b/Source/SPFavoriteNode.h @@ -28,38 +28,22 @@ * * @author Stuart Connolly http://stuconnolly.com/ * - * This class is designed to be a simple wrapper around a connection favorite to allow us to easily represent - * them in a tree structure for use in an outline view. If the node is a group item (i.e. a folder) then it - * should have a name as well as zero or more child nodes. Similarly, actual connection favorite nodes, don't - * have a name and should have no children. + * Tree node the represents a connection favorite. */ -@interface SPFavoriteNode : NSObject -{ - BOOL nodeIsGroup; - NSString *nodeName; - +@interface SPFavoriteNode : NSObject <NSCopying> +{ NSDictionary *nodeFavorite; - NSMutableArray *nodeChildren; } /** - * @property nodeIsGroup Indicates whether this node is a group item - */ -@property (readwrite, assign) BOOL nodeIsGroup; - -/** - * @property nodeName The node's name if it's a group item - */ -@property (readwrite, retain) NSString *nodeName; - -/** * @property nodeFavorite The actual favorite dictionary */ @property (readwrite, retain) NSDictionary *nodeFavorite; -/** - * @property nodeChildren This node's children - */ -@property (readwrite, retain) NSMutableArray *nodeChildren; +- (id)initWithDictionary:(NSDictionary *)dictionary; + ++ (SPFavoriteNode *)favoriteNodeWithDictionary:(NSDictionary *)dictionary; + +- (NSDictionary *)dictionaryRepresentation; @end diff --git a/Source/SPFavoriteNode.m b/Source/SPFavoriteNode.m index 51a9d1aa..55a44653 100644 --- a/Source/SPFavoriteNode.m +++ b/Source/SPFavoriteNode.m @@ -27,28 +27,60 @@ @implementation SPFavoriteNode -@synthesize nodeIsGroup; -@synthesize nodeName; @synthesize nodeFavorite; -@synthesize nodeChildren; + +#pragma mark - +#pragma mark Initialisation - (id)init { if ((self = [super init])) { - [self setNodeIsGroup:NO]; - [self setNodeName:nil]; [self setNodeFavorite:nil]; - [self setNodeChildren:[[NSMutableArray alloc] init]]; } return self; } +- (id)initWithDictionary:(NSDictionary *)dictionary +{ + if ((self = [self init])) { + [self setNodeFavorite:dictionary]; + } + + return self; +} + ++ (SPFavoriteNode *)favoriteNodeWithDictionary:(NSDictionary *)dictionary +{ + return [[[self alloc] initWithDictionary:dictionary] autorelease]; +} + +#pragma mark - +#pragma mark Copying protocol methods + +- (id)copyWithZone:(NSZone *)zone +{ + SPFavoriteNode *node = [[[self class] allocWithZone:zone] init]; + + [node setNodeFavorite:[[self nodeFavorite] copyWithZone:zone]]; + + return node; +} + + +#pragma mark - +#pragma mark Other + +- (NSString *)description +{ + return [NSString stringWithFormat:@"<%@: %p ('%@')>", [self className], self, [[self nodeFavorite] objectForKey:SPFavoriteNameKey]]; +} + +#pragma mark - + - (void)dealloc { - if (nodeName) [nodeName release], nodeName = nil; if (nodeFavorite) [nodeFavorite release], nodeFavorite = nil; - if (nodeChildren) [nodeChildren release], nodeChildren = nil; [super dealloc]; } diff --git a/Source/SPFavoritesController.h b/Source/SPFavoritesController.h index 1b9f0aca..095e1cd0 100644 --- a/Source/SPFavoritesController.h +++ b/Source/SPFavoritesController.h @@ -25,6 +25,8 @@ #import "SPSingleton.h" +@class SPTreeNode; + /** * @class SPFavoritesController SPFavoritesController.h * @@ -35,17 +37,31 @@ */ @interface SPFavoritesController : SPSingleton { - NSMutableDictionary *favorites; + SPTreeNode *favoritesTree; + NSMutableDictionary *favoritesData; + + pthread_mutex_t writeLock; + pthread_mutex_t favoritesLock; } /** - * @property favorites Favorites data dictionary + * @property favoritesTree + */ +@property (readonly) SPTreeNode *favoritesTree; + +/** + * @property favoritesData Favorites data dictionary */ -@property (readonly) NSMutableDictionary *favorites; +@property (readonly) NSMutableDictionary *favoritesData; + (SPFavoritesController *)sharedFavoritesController; - (void)saveFavorites; - (void)reloadFavoritesWithSave:(BOOL)save; +- (SPTreeNode *)addGroupNodeWithName:(NSString *)name asChildOfNode:(SPTreeNode *)parent; +- (SPTreeNode *)addFavoriteNodeWithData:(NSDictionary *)data asChildOfNode:(SPTreeNode *)parent; + +- (void)removeFavoriteNode:(SPTreeNode *)node; + @end diff --git a/Source/SPFavoritesController.m b/Source/SPFavoritesController.m index 285cbd90..920cec6b 100644 --- a/Source/SPFavoritesController.m +++ b/Source/SPFavoritesController.m @@ -24,18 +24,27 @@ // More info at <http://code.google.com/p/sequel-pro/> #import "SPFavoritesController.h" +#import "SPFavoriteNode.h" +#import "SPGroupNode.h" +#import "pthread.h" static SPFavoritesController *sharedFavoritesController = nil; @interface SPFavoritesController (PrivateAPI) - (void)_loadFavorites; +- (void)_constructFavoritesTree; +- (void)_saveFavoritesDataInBackground:(NSDictionary *)data; +- (void)_addNode:(SPTreeNode *)node asChildOfNode:(SPTreeNode *)parent; + +- (SPTreeNode *)_constructBranchForNodeData:(NSDictionary *)nodeData; @end @implementation SPFavoritesController -@synthesize favorites; +@synthesize favoritesTree; +@synthesize favoritesData; #pragma mark - #pragma mark Initialisation @@ -51,19 +60,25 @@ static SPFavoritesController *sharedFavoritesController = nil; { if ((self = [super init])) { - favorites = nil; + favoritesTree = nil; + favoritesData = nil; + + pthread_mutex_init(&writeLock, NULL); + pthread_mutex_init(&favoritesLock, NULL); [self _loadFavorites]; + [self _constructFavoritesTree]; } return self; } #pragma mark - -#pragma mark Public API /** * Returns the shared favorites controller. + * + * @return The shared controller instance. */ + (SPFavoritesController *)sharedFavoritesController { @@ -76,6 +91,9 @@ static SPFavoritesController *sharedFavoritesController = nil; return sharedFavoritesController; } +#pragma mark - +#pragma mark Favorites data handling + /** * Saves the current favorites dictionary in memory to disk. Note that the current favorites data file is moved * rather than overwritten in the event that we can't write the new file, the original can simply be restored. @@ -83,129 +101,333 @@ static SPFavoritesController *sharedFavoritesController = nil; */ - (void)saveFavorites { - NSError *error = nil; - NSString *errorString = nil; + pthread_mutex_lock(&favoritesLock); + + [NSThread detachNewThreadSelector:@selector(_saveFavoritesDataInBackground:) toTarget:self withObject:[[[favoritesTree childNodes] objectAtIndex:0] dictionaryRepresentation]]; + + pthread_mutex_unlock(&favoritesLock); +} + +/** + * Reloads the favorites data from disk with the option to save before doing so. + * + * @param save Indicates whether the current favorites data in memory should be saved to disk before being + * reloaded. Specifying NO effectively discards any changes since the last save operation. + */ +- (void)reloadFavoritesWithSave:(BOOL)save +{ + if (save) [self saveFavorites]; + + if (favoritesData) { + [self _loadFavorites]; + [self _constructFavoritesTree]; + } +} + +#pragma mark - +#pragma mark Favorites interaction + +/** + * Adds a new group node with the supplied name to the children of the supplied parent node. + * + * @param name The name of the new group + * @param parent + * + * @return The node instance that was created and added + */ +- (SPTreeNode *)addGroupNodeWithName:(NSString *)name asChildOfNode:(SPTreeNode *)parent +{ + SPTreeNode *node = [SPTreeNode treeNodeWithRepresentedObject:[SPGroupNode groupNodeWithName:name]]; + + [node setIsGroup:YES]; + + [self _addNode:node asChildOfNode:parent]; + + return [node autorelease]; +} + +/** + * Adds a new favorite node with the supplied data to the children of the supplied parent node. + * + * @param data The data for the new favorite + * @param + * + * @return The node instance that was created and added + */ +- (SPTreeNode *)addFavoriteNodeWithData:(NSDictionary *)data asChildOfNode:(SPTreeNode *)parent +{ + SPTreeNode *node = [SPTreeNode treeNodeWithRepresentedObject:[SPFavoriteNode favoriteNodeWithDictionary:data]]; + + [self _addNode:node asChildOfNode:parent]; + return [node autorelease]; +} + +/** + * Removes the supplied favorite node by asking the root node to remove it from it's children (i.e. the + * entire tree is searched. + * + * @param The node to be removed + */ +- (void)removeFavoriteNode:(SPTreeNode *)node +{ + [favoritesTree removeObjectFromChildren:node]; + + // Save data to disk + [self reloadFavoritesWithSave:YES]; +} + +#pragma mark - +#pragma mark Private API + +/** + * Attempts to load the users connection favorites from ~/Library/Application Support/Sequel Pro/Data/Favorites.plist + * If the 'Data' directory doesn't already exist it will be created, as well as an empty favorites plist. + */ +- (void)_loadFavorites +{ + pthread_mutex_lock(&favoritesLock); + + NSError *error = nil; NSFileManager *fileManager = [NSFileManager defaultManager]; + if (favoritesData) [favoritesData release], favoritesData = nil; + NSString *dataPath = [fileManager applicationSupportDirectoryForSubDirectory:SPDataSupportFolder error:&error]; if (error) { NSLog(@"Error retrieving data directory path: %@", [error localizedDescription]); + + pthread_mutex_unlock(&favoritesLock); + return; } NSString *favoritesFile = [dataPath stringByAppendingPathComponent:SPFavoritesDataFile]; - NSString *favoritesBackupFile = [dataPath stringByAppendingPathComponent:[@"~" stringByAppendingString:SPFavoritesDataFile]]; - // If the favorites data file already exists, attempt to move it to keep as a backup + // If the favorites data file already exists use it, otherwise create an empty one if ([fileManager fileExistsAtPath:favoritesFile]) { - [fileManager moveItemAtPath:favoritesFile toPath:favoritesBackupFile error:&error]; + favoritesData = [[NSDictionary alloc] initWithContentsOfFile:favoritesFile]; } - - if (error) { - NSLog(@"Unable to backup (move) existing favorites data file during save. Deleting instead: %@", [error localizedDescription]); + else { + NSDictionary *newFavorites = [NSMutableDictionary dictionaryWithObject:[NSMutableDictionary dictionaryWithObjectsAndKeys:NSLocalizedString(@"Favorites", @"favorites label"), SPFavoritesGroupNameKey, [NSArray array], SPFavoriteChildrenKey, nil] forKey:SPFavoritesRootKey]; - error = nil; + NSError *error = nil; + NSString *errorString = nil; - // We can't move it so try and delete it - if (![fileManager removeItemAtPath:favoritesFile error:&error] && error) { - NSLog(@"Unable to delete existing favorites data file during save. Something is wrong, permissions perhaps: %@", [error localizedDescription]); - return; - } - } - else { - NSData *plistData = [NSPropertyListSerialization dataFromPropertyList:favorites + NSData *plistData = [NSPropertyListSerialization dataFromPropertyList:newFavorites format:NSPropertyListXMLFormat_v1_0 errorDescription:&errorString]; - if (plistData) { [plistData writeToFile:favoritesFile options:NSAtomicWrite error:&error]; if (error) { - NSLog(@"Error writing favorites data. Restoring backup if available: %@", [error localizedDescription]); - - // Restore the original data file - [fileManager moveItemAtPath:favoritesBackupFile toPath:favoritesFile error:NULL]; - } - else { - // Remove the original backup - [fileManager removeItemAtPath:favoritesBackupFile error:NULL]; + NSLog(@"Error writing default favorites data: %@", [error localizedDescription]); } } else if (errorString) { - NSLog(@"Error converting favorites data to plist format: %@", errorString); + NSLog(@"Error converting default favorites data to plist format: %@", errorString); [errorString release]; + + pthread_mutex_unlock(&favoritesLock); + + return; } + + favoritesData = newFavorites; } + + pthread_mutex_unlock(&favoritesLock); } /** - * Reloads the favorites data from disk with the option to save before doing so. - * - * @param save Indicates whether the current favorites data in memory should be saved to disk before being - * reloaded. Specifying NO effectively discards any changes since the last save operation. + * Constructs the favorites tree by initialising an instance of SPFavoriteNode for every favorite and group. */ -- (void)reloadFavoritesWithSave:(BOOL)save +- (void)_constructFavoritesTree { - if (save) [self saveFavorites]; + pthread_mutex_lock(&favoritesLock); + + if (!favoritesData) { + pthread_mutex_unlock(&favoritesLock); + return; + } + + NSDictionary *root = [favoritesData objectForKey:SPFavoritesRootKey]; + + SPGroupNode *rootGroupNode = [[SPGroupNode alloc] init]; + SPGroupNode *favoritesGroupNode = [[SPGroupNode alloc] initWithName:[[root objectForKey:SPFavoritesGroupNameKey] uppercaseString]]; + + SPTreeNode *rootNode = [[SPTreeNode alloc] initWithRepresentedObject:rootGroupNode]; + SPTreeNode *favoritesNode = [[SPTreeNode alloc] initWithRepresentedObject:favoritesGroupNode]; + + [rootNode setIsGroup:YES]; + [favoritesNode setIsGroup:YES]; + + for (NSDictionary *favorite in [root objectForKey:SPFavoriteChildrenKey]) + { + SPTreeNode *node = [self _constructBranchForNodeData:favorite]; + + [[favoritesNode mutableChildNodes] addObject:node]; + + [node release]; + } + + [[rootNode mutableChildNodes] addObject:favoritesNode]; + + [rootGroupNode release]; + [favoritesGroupNode release]; + [favoritesNode release]; + + favoritesTree = rootNode; - if (favorites) [self _loadFavorites]; + pthread_mutex_unlock(&favoritesLock); } -#pragma mark - -#pragma mark Private API +/** + * Constructs the tree branch for the supplied favorites data. Note that depending on the contents of the + * branch (i.e. does it contain any groups and their depth) this method will recursively call itself. + * + * @param nodeData The favorites data dictionary + * + * @return The root node of the branch + */ +- (SPTreeNode *)_constructBranchForNodeData:(NSDictionary *)nodeData +{ + id node = nil; + SPTreeNode *treeNode = nil; + + if ([nodeData objectForKey:SPFavoritesGroupNameKey] && [nodeData objectForKey:SPFavoriteChildrenKey]) { + + node = [[SPGroupNode alloc] initWithName:[nodeData objectForKey:SPFavoritesGroupNameKey]]; + + treeNode = [[SPTreeNode alloc] initWithRepresentedObject:node]; + + [treeNode setIsGroup:YES]; + + for (NSDictionary *favorite in [nodeData objectForKey:SPFavoriteChildrenKey]) + { + SPTreeNode *innerNode = [self _constructBranchForNodeData:favorite]; + + [innerNode setIsGroup:YES]; + + [[treeNode mutableChildNodes] addObject:innerNode]; + + [innerNode release]; + } + } + else { + node = [[SPFavoriteNode alloc] initWithDictionary:nodeData]; + + treeNode = [[SPTreeNode alloc] initWithRepresentedObject:node]; + } + + return treeNode; +} /** - * Attempts to load the users connection favorites from ~/Library/Application Support/Sequel Pro/Data/Favorites.plist - * If the 'Data' directory doesn't already exist it will be created, as well as an empty favorites plist. + * Saves the supplied favorites data to disk on a background thread. + * + * @param data The raw plist data (serialized NSDictionary) to be saved */ -- (void)_loadFavorites +- (void)_saveFavoritesDataInBackground:(NSDictionary *)data { + NSAutoreleasePool *pool = [[NSAutoreleasePool alloc] init]; + + pthread_mutex_lock(&writeLock); + + if (!favoritesTree) { + pthread_mutex_unlock(&writeLock); + return; + } + NSError *error = nil; - NSFileManager *fileManager = [NSFileManager defaultManager]; + NSString *errorString = nil; - if (favorites) [favorites release], favorites = nil; + NSFileManager *fileManager = [NSFileManager defaultManager]; NSString *dataPath = [fileManager applicationSupportDirectoryForSubDirectory:SPDataSupportFolder error:&error]; if (error) { NSLog(@"Error retrieving data directory path: %@", [error localizedDescription]); + + pthread_mutex_unlock(&writeLock); return; } NSString *favoritesFile = [dataPath stringByAppendingPathComponent:SPFavoritesDataFile]; + NSString *favoritesBackupFile = [dataPath stringByAppendingPathComponent:[@"~" stringByAppendingString:SPFavoritesDataFile]]; - // If the favorites data file already exists use it, otherwise create an empty one + // If the favorites data file already exists, attempt to move it to keep as a backup if ([fileManager fileExistsAtPath:favoritesFile]) { - favorites = [[NSDictionary alloc] initWithContentsOfFile:favoritesFile]; + [fileManager moveItemAtPath:favoritesFile toPath:favoritesBackupFile error:&error]; } - else { - NSDictionary *newFavorites = [NSMutableDictionary dictionaryWithObject:[NSMutableDictionary dictionaryWithObjectsAndKeys:NSLocalizedString(@"Favorites", @"favorites label"), SPFavoritesGroupNameKey, [NSArray array], SPFavoriteChildrenKey, nil] forKey:SPFavoritesRootKey]; + + if (error) { + NSLog(@"Unable to backup (move) existing favorites data file during save. Deleting instead: %@", [error localizedDescription]); - NSError *error = nil; - NSString *errorString = nil; + error = nil; - NSData *plistData = [NSPropertyListSerialization dataFromPropertyList:newFavorites + // We can't move it so try and delete it + if (![fileManager removeItemAtPath:favoritesFile error:&error] && error) { + NSLog(@"Unable to delete existing favorites data file during save. Something is wrong, permissions perhaps: %@", [error localizedDescription]); + + pthread_mutex_unlock(&writeLock); + return; + } + } + else { + NSDictionary *dictionary = [NSDictionary dictionaryWithObject:data forKey:SPFavoritesRootKey]; + + // Convert the current favorites tree to a dictionary representation to create the plist data + NSData *plistData = [NSPropertyListSerialization dataFromPropertyList:dictionary format:NSPropertyListXMLFormat_v1_0 errorDescription:&errorString]; + if (plistData) { [plistData writeToFile:favoritesFile options:NSAtomicWrite error:&error]; if (error) { - NSLog(@"Error writing default favorites data: %@", [error localizedDescription]); + NSLog(@"Error writing favorites data. Restoring backup if available: %@", [error localizedDescription]); + + // Restore the original data file + [fileManager moveItemAtPath:favoritesBackupFile toPath:favoritesFile error:NULL]; + } + else { + // Remove the original backup + [fileManager removeItemAtPath:favoritesBackupFile error:NULL]; } } else if (errorString) { - NSLog(@"Error converting default favorites data to plist format: %@", errorString); + NSLog(@"Error converting favorites data to plist format: %@", errorString); [errorString release]; - return; + + [fileManager removeItemAtPath:favoritesBackupFile error:NULL]; } - - favorites = newFavorites; } + + pthread_mutex_unlock(&writeLock); + + [pool release]; +} + +/** + * Adds the supplied node to the children of the supplied parent and saves the tree to disk. + * + * @param node The node to be added + * @param asChild + */ +- (void)_addNode:(SPTreeNode *)node asChildOfNode:(SPTreeNode *)parent +{ + if (parent) { + [[parent mutableChildNodes] addObject:node]; + } + else { + [[[[favoritesTree mutableChildNodes] objectAtIndex:0] mutableChildNodes] addObject:node]; + } + + [self saveFavorites]; } #pragma mark - @@ -215,7 +437,11 @@ static SPFavoritesController *sharedFavoritesController = nil; */ - (void)dealloc { - if (favorites) [favorites release], favorites = nil; + if (favoritesTree) [favoritesTree release], favoritesTree = nil; + if (favoritesData) [favoritesData release], favoritesData = nil; + + pthread_mutex_destroy(&writeLock); + pthread_mutex_destroy(&favoritesLock); [super dealloc]; } diff --git a/Source/SPFavoritesOutlineView.m b/Source/SPFavoritesOutlineView.m index 6930c281..4a47b3db 100644 --- a/Source/SPFavoritesOutlineView.m +++ b/Source/SPFavoritesOutlineView.m @@ -52,6 +52,19 @@ return [self menu]; } +- (void)keyDown:(NSEvent *)event +{ + // Enter or Return initiates a connection to the selected favorite, which is the same as double-clicking + // one, so call the same selector. + if (([self numberOfSelectedRows] == 1) && (([event keyCode] == 36) || ([event keyCode] == 76))) { + [[self delegate] performSelector:[self doubleAction]]; + + return; + } + + [super keyDown:event]; +} + /** * To prevent right-clicking in a column's 'group' heading, ask the delegate if we support selecting it * as this normally doesn't apply to left-clicks. If we do support selecting this row, simply pass on the event. diff --git a/Source/SPFavoritesPreferencePane.h b/Source/SPFavoritesPreferencePane.h deleted file mode 100644 index 9d77d4c4..00000000 --- a/Source/SPFavoritesPreferencePane.h +++ /dev/null @@ -1,98 +0,0 @@ -// -// $Id$ -// -// SPFavoritesPreferencePane.h -// sequel-pro -// -// Created by Stuart Connolly (stuconnolly.com) on October 31, 2010 -// Copyright (c) 2010 Stuart Connolly. All rights reserved. -// -// This program is free software; you can redistribute it and/or modify -// it under the terms of the GNU General Public License as published by -// the Free Software Foundation; either version 2 of the License, or -// (at your option) any later version. -// -// This program is distributed in the hope that it will be useful, -// but WITHOUT ANY WARRANTY; without even the implied warranty of -// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -// GNU General Public License for more details. -// -// You should have received a copy of the GNU General Public License -// along with this program; if not, write to the Free Software -// Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA -// -// More info at <http://code.google.com/p/sequel-pro/> - -#import "SPPreferencePane.h" - -@class SPKeychain, BWAnchoredButtonBar; - -/** - * @class SPFavoritesPreferencePane SPFavoritesPreferencePane.h - * - * @author Stuart Connolly http://stuconnolly.com/ - * - * Favorites preference pane controller. - */ -@interface SPFavoritesPreferencePane : SPPreferencePane <SPPreferencePaneProtocol> -{ - IBOutlet NSTableView *favoritesTableView; - IBOutlet NSArrayController *favoritesController; - - IBOutlet NSTabView *favoritesTabView; - - IBOutlet NSSecureTextField *standardPasswordField; - IBOutlet NSSecureTextField *socketPasswordField; - IBOutlet NSSecureTextField *sshSQLPasswordField; - IBOutlet NSSecureTextField *sshPasswordField; - - IBOutlet NSTextField *favoriteNameTextField; - IBOutlet NSTextField *favoriteUserTextField; - IBOutlet NSTextField *favoriteHostTextField; - IBOutlet NSTextField *favoriteUserTextFieldSocket; - IBOutlet NSTextField *favoriteUserTextFieldSSH; - IBOutlet NSTextField *favoriteHostTextFieldSSH; - - IBOutlet NSButton *sshSSHKeyButton; - IBOutlet NSButton *standardSSLKeyFileButton; - IBOutlet NSButton *standardSSLCertificateButton; - IBOutlet NSButton *standardSSLCACertButton; - IBOutlet NSButton *socketSSLKeyFileButton; - IBOutlet NSButton *socketSSLCertificateButton; - IBOutlet NSButton *socketSSLCACertButton; - - IBOutlet NSView *sshKeyLocationHelp; - IBOutlet NSView *sslKeyFileLocationHelp; - IBOutlet NSView *sslCertificateLocationHelp; - IBOutlet NSView *sslCACertLocationHelp; - - IBOutlet NSTextFieldCell *tableCell; - - IBOutlet NSMenuItem *favoritesSortByMenuItem; - - IBOutlet BWAnchoredButtonBar *splitViewButtonBar; - - SPKeychain *keychain; - - NSInteger favoriteType; - NSDictionary *currentFavorite; - BOOL favoriteNameFieldWasTouched; - - // Sorting - BOOL reverseFavoritesSort; - SPFavoritesSortItem previousSortItem, currentSortItem; -} - -- (IBAction)addFavorite:(id)sender; -- (IBAction)removeFavorite:(id)sender; -- (IBAction)duplicateFavorite:(id)sender; -- (IBAction)makeSelectedFavoriteDefault:(id)sender; -- (IBAction)sortFavorites:(id)sender; -- (IBAction)reverseFavoritesSortOrder:(id)sender; -- (IBAction)chooseKeyLocation:(id)sender; -- (IBAction)favoriteTypeDidChange:(id)sender; -- (IBAction)chooseKeyLocation:(id)sender; - -- (void)selectFavorites:(NSArray *)favorites; - -@end diff --git a/Source/SPFavoritesPreferencePane.m b/Source/SPFavoritesPreferencePane.m deleted file mode 100644 index 6b328d47..00000000 --- a/Source/SPFavoritesPreferencePane.m +++ /dev/null @@ -1,902 +0,0 @@ -// -// $Id$ -// -// SPFavoritesPreferencePane.m -// sequel-pro -// -// Created by Stuart Connolly (stuconnolly.com) on October 31, 2010 -// Copyright (c) 2010 Stuart Connolly. All rights reserved. -// -// This program is free software; you can redistribute it and/or modify -// it under the terms of the GNU General Public License as published by -// the Free Software Foundation; either version 2 of the License, or -// (at your option) any later version. -// -// This program is distributed in the hope that it will be useful, -// but WITHOUT ANY WARRANTY; without even the implied warranty of -// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -// GNU General Public License for more details. -// -// You should have received a copy of the GNU General Public License -// along with this program; if not, write to the Free Software -// Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA -// -// More info at <http://code.google.com/p/sequel-pro/> - -#import "SPFavoritesPreferencePane.h" -#import "SPFavoriteTextFieldCell.h" -#import "SPPreferenceController.h" -#import "SPKeychain.h" - -@interface SPFavoritesPreferencePane (PrivateAPI) - -- (void)_sortFavorites; -- (void)_updateFavoritePasswordsFromField:(NSControl *)passwordControl; - -@end - -@implementation SPFavoritesPreferencePane - -#pragma mark - -#pragma mark Intialisation - -/** - * Init. - */ -- (id)init -{ - if ((self = [super init])) { - - keychain = [[SPKeychain alloc] init]; - - favoriteType = 0; - reverseFavoritesSort = NO; - favoriteNameFieldWasTouched = YES; - - previousSortItem = SPFavoritesSortNameItem; - } - - return self; -} - -/** - * Initialise the UI, specifically the favourites table view and sort the favourites if required. - */ -- (void)awakeFromNib -{ - // Set sort items - currentSortItem = [prefs integerForKey:SPFavoritesSortedBy]; - reverseFavoritesSort = [prefs boolForKey:SPFavoritesSortedInReverse]; - - // Replace column's NSTextFieldCell with custom SWProfileTextFieldCell - [[[favoritesTableView tableColumns] objectAtIndex:0] setDataCell:tableCell]; - - [favoritesTableView registerForDraggedTypes:[NSArray arrayWithObject:SPFavoritesPasteboardDragType]]; - - [favoritesTableView selectRowIndexes:[NSIndexSet indexSetWithIndex:0] byExtendingSelection:NO]; - [favoritesTableView reloadData]; - - [tableCell setImage:[NSImage imageNamed:@"database"]]; - - // Set the button bar delegate - [splitViewButtonBar setSplitViewDelegate:self]; - - // Hide the tabs on the favorites tab view - left visible in IB for easy use - [favoritesTabView setTabViewType:NSNoTabsNoBorder]; - - // Sort favorites if a sort type has been selected - if (currentSortItem > -1) [self _sortFavorites]; -} - -#pragma mark - -#pragma mark IBAction methods - -/** - * Adds a new connection favorite. - */ -- (IBAction)addFavorite:(id)sender -{ - NSNumber *favoriteid = [NSNumber numberWithInteger:[[NSString stringWithFormat:@"%f", [[NSDate date] timeIntervalSince1970]] hash]]; - - // Create default favorite - NSMutableDictionary *favorite = [NSMutableDictionary dictionaryWithObjects:[NSArray arrayWithObjects:NSLocalizedString(@"New Favorite", @"new favorite name"), [NSNumber numberWithInteger:0], @"", @"", @"", @"", [NSNumber numberWithInt:NSOffState], [NSNumber numberWithInt:NSOffState], [NSNumber numberWithInt:NSOffState], [NSNumber numberWithInt:NSOffState], @"", @"", @"", [NSNumber numberWithInt:NSOffState], @"", @"", favoriteid, nil] - forKeys:[NSArray arrayWithObjects:@"name", @"type", @"host", @"socket", @"user", @"port", @"useSSL", @"sslKeyFileLocationEnabled", @"sslCertificateFileLocationEnabled", @"sslCACertFileLocationEnabled", @"database", @"sshHost", @"sshUser", @"sshKeyLocationEnabled", @"sshKeyLocation", @"sshPort", @"id", nil]]; - - [favoritesController addObject:favorite]; - [favoritesController setSelectedObjects:[NSArray arrayWithObject:favorite]]; - - [favoritesTableView reloadData]; - [favoritesTableView scrollRowToVisible:[favoritesTableView selectedRow]]; - - [[(SPPreferenceController *)[[[self view] window] delegate] generalPreferencePane] updateDefaultFavoritePopup]; - - favoriteNameFieldWasTouched = NO; - - [[[self view] window] makeFirstResponder:favoriteHostTextField]; -} - -/** - * Removes the selected connection favorite. - */ -- (IBAction)removeFavorite:(id)sender -{ - if ([favoritesTableView numberOfSelectedRows] == 1) { - NSAlert *alert = [NSAlert alertWithMessageText:[NSString stringWithFormat:NSLocalizedString(@"Delete favorite '%@'?", @"delete database message"), [favoritesController valueForKeyPath:@"selection.name"]] - defaultButton:NSLocalizedString(@"Delete", @"delete button") - alternateButton:NSLocalizedString(@"Cancel", @"cancel button") - otherButton:nil - informativeTextWithFormat:[NSString stringWithFormat:NSLocalizedString(@"Are you sure you want to delete the favorite '%@'? This operation cannot be undone.", @"delete database informative message"), [favoritesController valueForKeyPath:@"selection.name"]]]; - - NSArray *buttons = [alert buttons]; - - // Change the alert's cancel button to have the key equivalent of return - [[buttons objectAtIndex:0] setKeyEquivalent:@"d"]; - [[buttons objectAtIndex:0] setKeyEquivalentModifierMask:NSCommandKeyMask]; - [[buttons objectAtIndex:1] setKeyEquivalent:@"\r"]; - - [alert setAlertStyle:NSCriticalAlertStyle]; - - [alert beginSheetModalForWindow:[[self view] window] modalDelegate:self didEndSelector:@selector(sheetDidEnd:returnCode:contextInfo:) contextInfo:@"removeFavorite"]; - } -} - -/** - * Duplicates the selected connection favorite. - */ -- (IBAction)duplicateFavorite:(id)sender -{ - if ([favoritesTableView numberOfSelectedRows] == 1) { - - NSMutableDictionary *favorite = [NSMutableDictionary dictionaryWithDictionary:[[favoritesController arrangedObjects] objectAtIndex:[favoritesTableView selectedRow]]]; - NSNumber *favoriteid = [NSNumber numberWithInteger:[[NSString stringWithFormat:@"%f", [[NSDate date] timeIntervalSince1970]] hash]]; - NSInteger duplicatedFavoriteType = [[favorite objectForKey:@"type"] integerValue]; - - // Select the keychain passwords for duplication - NSString *keychainName = [keychain nameForFavoriteName:[favorite objectForKey:@"name"] id:[favorite objectForKey:@"id"]]; - NSString *keychainAccount = [keychain accountForUser:[favorite objectForKey:@"user"] host:((duplicatedFavoriteType == SPSocketConnection)?@"localhost":[favorite objectForKey:@"host"]) database:[favorite objectForKey:@"database"]]; - NSString *password = [keychain getPasswordForName:keychainName account:keychainAccount]; - NSString *keychainSSHName = [keychain nameForSSHForFavoriteName:[favorite objectForKey:@"name"] id:[favorite objectForKey:@"id"]]; - NSString *keychainSSHAccount = [keychain accountForSSHUser:[favorite objectForKey:@"sshUser"] sshHost:[favorite objectForKey:@"sshHost"]]; - NSString *sshPassword = [keychain getPasswordForName:keychainSSHName account:keychainSSHAccount]; - - // Update the unique ID - [favorite setObject:favoriteid forKey:@"id"]; - - // Alter the name for clarity - [favorite setObject:[NSString stringWithFormat:NSLocalizedString(@"%@ Copy", @"Initial favourite name after duplicating a previous favourite"), [favorite objectForKey:@"name"]] forKey:@"name"]; - - // Create new keychain items if appropriate - if (password && [password length]) { - keychainName = [keychain nameForFavoriteName:[favorite objectForKey:@"name"] id:[favorite objectForKey:@"id"]]; - [keychain addPassword:password forName:keychainName account:keychainAccount]; - } - - if (sshPassword && [sshPassword length]) { - keychainSSHName = [keychain nameForSSHForFavoriteName:[favorite objectForKey:@"name"] id:[favorite objectForKey:@"id"]]; - [keychain addPassword:sshPassword forName:keychainSSHName account:keychainSSHAccount]; - } - - password = nil, sshPassword = nil; - - [favoritesController addObject:favorite]; - [favoritesController setSelectedObjects:[NSArray arrayWithObject:favorite]]; - - [favoritesTableView reloadData]; - [favoritesTableView scrollRowToVisible:[favoritesTableView selectedRow]]; - - [[(SPPreferenceController *)[[[self view] window] delegate] generalPreferencePane] updateDefaultFavoritePopup]; - - [[[self view] window] makeFirstResponder:favoriteNameTextField]; - } -} - -/** - * Sorts the favorites table view based on the selected sort by item - */ -- (IBAction)sortFavorites:(id)sender -{ - previousSortItem = currentSortItem; - currentSortItem = [[sender menu] indexOfItem:sender]; - - [prefs setInteger:currentSortItem forKey:SPFavoritesSortedBy]; - - // Perform sorting - [self _sortFavorites]; - - if (previousSortItem > -1) [[[sender menu] itemAtIndex:previousSortItem] setState:NSOffState]; - - [[[sender menu] itemAtIndex:currentSortItem] setState:NSOnState]; -} - -/** - * Reverses the favorites table view sorting based on the selected criteria - */ -- (IBAction)reverseFavoritesSortOrder:(id)sender -{ - reverseFavoritesSort = (![sender state]); - - [prefs setBool:reverseFavoritesSort forKey:SPFavoritesSortedInReverse]; - - // Perform re-sorting - [self _sortFavorites]; - - [sender setState:reverseFavoritesSort]; -} - -/** - * Makes the selected favorite the default. - */ -- (IBAction)makeSelectedFavoriteDefault:(id)sender -{ - // Minus 2 from index to account for the 'Last Used' and separator items - [prefs setInteger:[favoritesTableView selectedRow] forKey:SPDefaultFavorite]; - - [favoritesTableView reloadData]; - - [[(SPPreferenceController *)[[[self view] window] delegate] generalPreferencePane] updateDefaultFavoritePopup]; -} - -/** - * Update the favorite host when the type changes. - */ -- (IBAction)favoriteTypeDidChange:(id)sender -{ - // If not socket and host is localhost, clear. - if (([sender indexOfSelectedItem] != 1) && [[favoritesController valueForKeyPath:@"selection.host"] isEqualToString:@"localhost"]) - { - [favoritesController setValue:@"" forKeyPath:@"selection.host"]; - } - - favoriteType = [sender indexOfSelectedItem]; - - // Update the name for a new added favorite if not touched by the user - if(!favoriteNameFieldWasTouched) { - [favoriteNameTextField setStringValue:[NSString stringWithFormat:@"%@@%@", - ([favoritesController valueForKeyPath:@"selection.user"]) ? [favoritesController valueForKeyPath:@"selection.user"] : @"", - (([sender indexOfSelectedItem] == 1) ? @"localhost" : - (([favoritesController valueForKeyPath:@"selection.host"]) ? [favoritesController valueForKeyPath:@"selection.host"] : @"")) - ]]; - - [favoritesController setValue:[favoriteNameTextField stringValue] forKeyPath:@"selection.name"]; - } - - // Request a password refresh to keep keychain references in synch with the favorites - [self _updateFavoritePasswordsFromField:nil]; -} - -/** - * Opens the SSH/SSL key selection window, ready to select a key file. - */ -- (IBAction)chooseKeyLocation:(id)sender -{ - NSString *directoryPath = nil; - NSString *filePath = nil; - NSArray *permittedFileTypes = nil; - NSOpenPanel *openPanel = [NSOpenPanel openPanel]; - - // Switch details by sender. - // First, SSH keys: - if (sender == sshSSHKeyButton) { - - // If the custom key location is currently disabled - after the button - // action - leave it disabled and return without showing the sheet. - if (![favoritesController valueForKeyPath:@"selection.sshKeyLocationEnabled"]) { - return; - } - - // Otherwise open a panel at the last or default location - NSString *sshKeyLocation = [favoritesController valueForKeyPath:@"selection.sshKeyLocation"]; - if (sshKeyLocation && [sshKeyLocation length]) { - filePath = [sshKeyLocation lastPathComponent]; - directoryPath = [sshKeyLocation stringByDeletingLastPathComponent]; - } - - permittedFileTypes = [NSArray arrayWithObjects:@"pem", @"", nil]; - - [openPanel setAccessoryView:sshKeyLocationHelp]; - - // SSL key file location: - } - else if (sender == standardSSLKeyFileButton || sender == socketSSLKeyFileButton) { - if ([sender state] == NSOffState) { - [favoritesController setValue:nil forKeyPath:@"selection.sslKeyFileLocation"]; - return; - } - - permittedFileTypes = [NSArray arrayWithObjects:@"pem", @"key", @"", nil]; - [openPanel setAccessoryView:sslKeyFileLocationHelp]; - - // SSL certificate file location: - } - else if (sender == standardSSLCertificateButton || sender == socketSSLCertificateButton) { - if ([sender state] == NSOffState) { - [favoritesController setValue:nil forKeyPath:@"selection.sslCertificateFileLocation"]; - return; - } - - permittedFileTypes = [NSArray arrayWithObjects:@"pem", @"cert", @"", nil]; - [openPanel setAccessoryView:sslCertificateLocationHelp]; - - // SSL CA certificate file location: - } - else if (sender == standardSSLCACertButton || sender == socketSSLCACertButton) { - if ([sender state] == NSOffState) { - [favoritesController setValue:nil forKeyPath:@"selection.sslCACertFileLocation"]; - return; - } - - permittedFileTypes = [NSArray arrayWithObjects:@"pem", @"cert", @"", nil]; - [openPanel setAccessoryView:sslCACertLocationHelp]; - } - - [openPanel beginSheetForDirectory:directoryPath - file:filePath - types:permittedFileTypes - modalForWindow:[[self view] window] - modalDelegate:self - didEndSelector:@selector(chooseKeyLocationSheetDidEnd:returnCode:contextInfo:) - contextInfo:sender]; -} - -#pragma mark - -#pragma mark Public API - -/** - * Selects the specified favorite(s) in the favorites list. - */ -- (void)selectFavorites:(NSArray *)favorites -{ - [favoritesController setSelectedObjects:favorites]; - [favoritesTableView scrollRowToVisible:[favoritesController selectionIndex]]; -} - -#pragma mark - -#pragma mark TableView datasource methods - -- (NSInteger)numberOfRowsInTableView:(NSTableView *)tableView -{ - return [[favoritesController arrangedObjects] count]; -} - -- (id)tableView:(NSTableView *)tableView objectValueForTableColumn:(NSTableColumn *)tableColumn row:(NSInteger)rowIndex -{ - return [[[favoritesController arrangedObjects] objectAtIndex:rowIndex] objectForKey:[tableColumn identifier]]; -} - -#pragma mark - -#pragma mark TableView drag & drop delegate methods - -- (BOOL)tableView:(NSTableView *)tableView writeRowsWithIndexes:(NSIndexSet *)rows toPasteboard:(NSPasteboard*)pboard -{ - if ([rows count] == 1) { - [pboard declareTypes:[NSArray arrayWithObject:SPFavoritesPasteboardDragType] owner:nil]; - [pboard setString:[[NSNumber numberWithInteger:[rows firstIndex]] stringValue] forType:SPFavoritesPasteboardDragType]; - - return YES; - } - else { - return NO; - } -} - -- (NSDragOperation)tableView:(NSTableView *)tableView validateDrop:(id <NSDraggingInfo>)info proposedRow:(NSInteger)row proposedDropOperation:(NSTableViewDropOperation)operation -{ - NSInteger originalRow; - NSArray *pboardTypes = [[info draggingPasteboard] types]; - - if (([pboardTypes count] > 1) && (row != -1)) { - if (([pboardTypes containsObject:SPFavoritesPasteboardDragType]) && (operation == NSTableViewDropAbove)) { - originalRow = [[[info draggingPasteboard] stringForType:SPFavoritesPasteboardDragType] integerValue]; - - if ((row != originalRow) && (row != (originalRow + 1))) { - return NSDragOperationMove; - } - } - } - - return NSDragOperationNone; -} - -- (BOOL)tableView:(NSTableView *)tableView acceptDrop:(id <NSDraggingInfo>)info row:(NSInteger)row dropOperation:(NSTableViewDropOperation)operation -{ - NSInteger originalRow; - NSInteger destinationRow; - NSInteger lastFavoriteIndexCached; - NSMutableDictionary *draggedRow; - - // Disable all automatic sorting - currentSortItem = -1; - reverseFavoritesSort = NO; - - [prefs setInteger:currentSortItem forKey:SPFavoritesSortedBy]; - [prefs setBool:NO forKey:SPFavoritesSortedInReverse]; - - // Remove sort descriptors - [favoritesController setSortDescriptors:[NSArray array]]; - - // Uncheck sort by menu items - for (NSMenuItem *menuItem in [[favoritesSortByMenuItem submenu] itemArray]) - { - [menuItem setState:NSOffState]; - } - - originalRow = [[[info draggingPasteboard] stringForType:SPFavoritesPasteboardDragType] integerValue]; - destinationRow = row; - - if (destinationRow > originalRow) { - destinationRow--; - } - - draggedRow = [NSMutableDictionary dictionaryWithDictionary:[[favoritesController arrangedObjects] objectAtIndex:originalRow]]; - - // Before deleting this favorite, we need to save the current index. - // because removeObjectAtArrangedObjectIndex will set prefs LastFavoriteIndex to 0 - lastFavoriteIndexCached = [prefs integerForKey:SPLastFavoriteIndex]; - - [favoritesController removeObjectAtArrangedObjectIndex:originalRow]; - [favoritesController insertObject:draggedRow atArrangedObjectIndex:destinationRow]; - - [favoritesTableView reloadData]; - [favoritesTableView selectRowIndexes:[NSIndexSet indexSetWithIndex:destinationRow] byExtendingSelection:NO]; - - // Update default favorite to take on new value - if (lastFavoriteIndexCached == originalRow) { - [prefs setInteger:destinationRow forKey:SPLastFavoriteIndex]; - } - - // Update default favorite to take on new value - if ([prefs integerForKey:SPDefaultFavorite] == originalRow) { - [prefs setInteger:destinationRow forKey:SPDefaultFavorite]; - } - - [[(SPPreferenceController *)[[[self view] window] delegate] generalPreferencePane] updateDefaultFavoritePopup]; - - return YES; -} - -#pragma mark - -#pragma mark TableView delegate methods - -- (void)tableView:(NSTableView *)tableView willDisplayCell:(id)cell forTableColumn:(NSTableColumn *)tableColumn row:(NSInteger)index -{ - if ([cell isKindOfClass:[SPFavoriteTextFieldCell class]]) { - [cell setFavoriteName:[[[favoritesController arrangedObjects] objectAtIndex:index] objectForKey:@"name"]]; - - if ([[[[favoritesController arrangedObjects] objectAtIndex:index] objectForKey:@"type"] integerValue] == SPSocketConnection) { - [cell setFavoriteHost:@"localhost"]; - } - else { - [cell setFavoriteHost:[[[favoritesController arrangedObjects] objectAtIndex:index] objectForKey:@"host"]]; - } - } -} - -- (void)tableViewSelectionDidChange:(NSNotification *)notification -{ - if ([[favoritesTableView selectedRowIndexes] count] > 0) { - [favoritesController setSelectionIndexes:[favoritesTableView selectedRowIndexes]]; - } - - // If no selection is present, blank the password fields (which can't use bindings) - if ([[favoritesTableView selectedRowIndexes] count] == 0) { - [standardPasswordField setStringValue:@""]; - [socketPasswordField setStringValue:@""]; - [sshSQLPasswordField setStringValue:@""]; - [sshPasswordField setStringValue:@""]; - - return; - } - - // Keep a copy of the favorite as it currently stands - if (currentFavorite) [currentFavorite release]; - - currentFavorite = [[[favoritesController selectedObjects] objectAtIndex:0] copy]; - - // Retrieve and set the password. - NSString *keychainName = [keychain nameForFavoriteName:[currentFavorite objectForKey:@"name"] id:[currentFavorite objectForKey:@"id"]]; - NSString *keychainAccount = [keychain accountForUser:[currentFavorite objectForKey:@"user"] host:(([[currentFavorite objectForKey:@"type"] integerValue] == SPSocketConnection)?@"localhost":[currentFavorite objectForKey:@"host"]) database:[currentFavorite objectForKey:@"database"]]; - NSString *passwordValue = [keychain getPasswordForName:keychainName account:keychainAccount]; - - [standardPasswordField setStringValue:passwordValue]; - [socketPasswordField setStringValue:passwordValue]; - [sshSQLPasswordField setStringValue:passwordValue]; - - // Retrieve the SSH keychain password if appropriate. - NSString *keychainSSHName = [keychain nameForSSHForFavoriteName:[currentFavorite objectForKey:@"name"] id:[currentFavorite objectForKey:@"id"]]; - NSString *keychainSSHAccount = [keychain accountForSSHUser:[currentFavorite objectForKey:@"sshUser"] sshHost:[currentFavorite objectForKey:@"sshHost"]]; - - [sshPasswordField setStringValue:[keychain getPasswordForName:keychainSSHName account:keychainSSHAccount]]; - - favoriteNameFieldWasTouched = YES; -} - -#pragma mark - -#pragma mark TextField delegate methods and type change action - -/** - * Trap editing end notifications and use them to update the keychain password - * appropriately when name, host, user, password or database changes. - */ -- (BOOL)control:(NSControl *)control textShouldEndEditing:(NSText *)fieldEditor -{ - // Request a password refresh to keep keychain references in synch with favorites - [self _updateFavoritePasswordsFromField:control]; - - // Proceed with editing - return YES; -} - -/** - * Trap and control the 'name' field of the selected favorite. If the user pressed - * 'Add Favorite' the 'name' field is set to "New Favorite". If the user do not - * change the 'name' field or delete that field it will be set to user@host automatically. - */ -- (void)controlTextDidChange:(NSNotification *)notification -{ - id field = [notification object]; - - BOOL nameFieldIsEmpty = ([[favoritesController valueForKeyPath:@"selection.name"] isEqualToString:@""] || - [[favoriteNameTextField stringValue] isEqualToString:@""]); - - switch (favoriteType) - { - case 0: - if (nameFieldIsEmpty || (!favoriteNameFieldWasTouched && (field == favoriteUserTextField || field == favoriteHostTextField))) { - [favoriteNameTextField setStringValue:[NSString stringWithFormat:@"%@@%@", [favoriteUserTextField stringValue], [favoriteHostTextField stringValue]]]; - [favoritesController setValue:[favoriteNameTextField stringValue] forKeyPath:@"selection.name"]; - [prefs synchronize]; - - // if name field is empty enable user@host update - if (nameFieldIsEmpty) favoriteNameFieldWasTouched = NO; - } - break; - case 1: - if (nameFieldIsEmpty || (!favoriteNameFieldWasTouched && field == favoriteUserTextFieldSocket)) { - [favoriteNameTextField setStringValue:[NSString stringWithFormat:@"%@@localhost", [favoriteUserTextFieldSocket stringValue]]]; - [favoritesController setValue:[favoriteNameTextField stringValue] forKeyPath:@"selection.name"]; - [prefs synchronize]; - - // if name field is empty enable user@host update - if (nameFieldIsEmpty) favoriteNameFieldWasTouched = NO; - } - break; - case 2: - if (nameFieldIsEmpty || (!favoriteNameFieldWasTouched && (field == favoriteUserTextFieldSSH || field == favoriteHostTextFieldSSH))) { - [favoriteNameTextField setStringValue:[NSString stringWithFormat:@"%@@%@", [favoriteUserTextFieldSSH stringValue], [favoriteHostTextFieldSSH stringValue]]]; - [favoritesController setValue:[favoriteNameTextField stringValue] forKeyPath:@"selection.name"]; - [prefs synchronize]; - - // if name field is empty enable user@host update - if (nameFieldIsEmpty) favoriteNameFieldWasTouched = NO; - } - break; - default: - break; - } - - if (field == favoriteNameTextField) favoriteNameFieldWasTouched = YES; -} - -#pragma mark - -#pragma mark SplitView delegate methods - -- (CGFloat)splitView:(NSSplitView *)sender constrainMaxCoordinate:(CGFloat)proposedMax ofSubviewAt:(NSInteger)offset -{ - return (proposedMax - 220); -} - -- (CGFloat)splitView:(NSSplitView *)sender constrainMinCoordinate:(CGFloat)proposedMin ofSubviewAt:(NSInteger)offset -{ - return (proposedMin + 94); -} - -#pragma mark - -#pragma mark Other - -/** - * Menu item validation; - */ -- (BOOL)validateMenuItem:(NSMenuItem *)menuItem -{ - SEL action = [menuItem action]; - - if ((action == @selector(removeFavorite:)) || (action == @selector(duplicateFavorite:))) { - return ([favoritesTableView numberOfSelectedRows] > 0); - } - - if (action == @selector(makeSelectedFavoriteDefault:)) { - return ([favoritesTableView numberOfSelectedRows] == 1); - } - - if ((action == @selector(sortFavorites:)) || (action == @selector(reverseFavoritesSortOrder:))) { - - // Loop all the items in the sort by menu only checking the currently selected one - for (NSMenuItem *item in [[menuItem menu] itemArray]) - { - [item setState:([[menuItem menu] indexOfItem:item] == currentSortItem)]; - } - - // Check or uncheck the reverse sort item - if (action == @selector(reverseFavoritesSortOrder:)) { - [menuItem setState:reverseFavoritesSort]; - } - - return [[[[[self view] window] toolbar] selectedItemIdentifier] isEqualToString:SPPreferenceToolbarFavorites]; - } - - return YES; -} - -/** - * Called after closing the SSH/SSL key selection sheet. - */ -- (void)chooseKeyLocationSheetDidEnd:(NSOpenPanel *)openPanel returnCode:(NSInteger)returnCode contextInfo:(void *)contextInfo -{ - NSString *abbreviatedFileName = [[openPanel filename] stringByAbbreviatingWithTildeInPath]; - - // SSH key file selection - if (contextInfo == sshSSHKeyButton) { - if (returnCode == NSCancelButton) { - [favoritesController setValue:[NSNumber numberWithInt:NSOffState] forKeyPath:@"selection.sshKeyLocationEnabled"]; - return; - } - - [favoritesController setValue:abbreviatedFileName forKeyPath:@"selection.sshKeyLocation"]; - [self setSshKeyLocation:abbreviatedFileName]; - - // SSL key file selection - } - else if (contextInfo == standardSSLKeyFileButton || contextInfo == socketSSLKeyFileButton) { - if (returnCode == NSCancelButton) { - [favoritesController setValue:[NSNumber numberWithInt:NSOffState] forKeyPath:@"selection.sslKeyFileLocationEnabled"]; - [favoritesController setValue:nil forKeyPath:@"selection.sslKeyFileLocation"]; - return; - } - - [favoritesController setValue:abbreviatedFileName forKeyPath:@"selection.sslKeyFileLocation"]; - - // SSL certificate file selection - } - else if (contextInfo == standardSSLCertificateButton || contextInfo == socketSSLCertificateButton) { - if (returnCode == NSCancelButton) { - [favoritesController setValue:[NSNumber numberWithInt:NSOffState] forKeyPath:@"selection.sslCertificateFileLocationEnabled"]; - [favoritesController setValue:nil forKeyPath:@"selection.sslCertificateFileLocation"]; - return; - } - - [favoritesController setValue:abbreviatedFileName forKeyPath:@"selection.sslCertificateFileLocation"]; - - // SSL CA certificate file selection - } - else if (contextInfo == standardSSLCACertButton || contextInfo == socketSSLCACertButton) { - if (returnCode == NSCancelButton) { - [favoritesController setValue:[NSNumber numberWithInt:NSOffState] forKeyPath:@"selection.sslCACertFileLocationEnabled"]; - [favoritesController setValue:nil forKeyPath:@"selection.sslCACertFileLocation"]; - return; - } - - [favoritesController setValue:abbreviatedFileName forKeyPath:@"selection.sslCACertFileLocation"]; - } -} - -- (void)sheetDidEnd:(id)sheet returnCode:(NSInteger)returnCode contextInfo:(NSString *)contextInfo -{ - // Order out current sheet to suppress overlapping of sheets - if ([sheet respondsToSelector:@selector(orderOut:)]) { - [sheet orderOut:nil]; - } - else if ([sheet respondsToSelector:@selector(window)]) { - [[sheet window] orderOut:nil]; - } - - // Remove the current database - if ([contextInfo isEqualToString:@"removeFavorite"]) { - if (returnCode == NSAlertDefaultReturn) { - - // Get selected favorite's details - NSString *name = [favoritesController valueForKeyPath:@"selection.name"]; - NSString *user = [favoritesController valueForKeyPath:@"selection.user"]; - NSString *host = [favoritesController valueForKeyPath:@"selection.host"]; - NSString *database = [favoritesController valueForKeyPath:@"selection.database"]; - NSString *sshUser = [favoritesController valueForKeyPath:@"selection.sshUser"]; - NSString *sshHost = [favoritesController valueForKeyPath:@"selection.sshHost"]; - NSString *favoriteid = [favoritesController valueForKeyPath:@"selection.id"]; - NSInteger type = [[favoritesController valueForKeyPath:@"selection.type"] integerValue]; - - // Remove passwords from the Keychain - [keychain deletePasswordForName:[keychain nameForFavoriteName:name id:favoriteid] - account:[keychain accountForUser:user host:((type == SPSocketConnection)?@"localhost":host) database:database]]; - [keychain deletePasswordForName:[keychain nameForSSHForFavoriteName:name id:favoriteid] - account:[keychain accountForSSHUser:sshUser sshHost:sshHost]]; - - // Reset last used favorite - if ([favoritesTableView selectedRow] == [prefs integerForKey:SPLastFavoriteIndex]) { - [prefs setInteger:0 forKey:SPLastFavoriteIndex]; - } - - // Reset default favorite - if ([favoritesTableView selectedRow] == [prefs integerForKey:SPDefaultFavorite]) { - [prefs setInteger:[prefs integerForKey:SPLastFavoriteIndex] forKey:SPDefaultFavorite]; - } - - [favoritesController removeObjectAtArrangedObjectIndex:[favoritesTableView selectedRow]]; - - [favoritesTableView reloadData]; - - [[(SPPreferenceController *)[[[self view] window] delegate] generalPreferencePane] updateDefaultFavoritePopup]; - } - } -} - -#pragma mark - -#pragma mark Preference pane protocol methods - -- (NSView *)preferencePaneView -{ - return [self view]; -} - -- (NSImage *)preferencePaneIcon -{ - return [NSImage imageNamed:@"toolbar-preferences-favorites"]; -} - -- (NSString *)preferencePaneName -{ - return NSLocalizedString(@"Favorites", @"favorites label"); -} - -- (NSString *)preferencePaneIdentifier -{ - return SPPreferenceToolbarFavorites; -} - -- (NSString *)preferencePaneToolTip -{ - return NSLocalizedString(@"Favorite Preferences", @"favorites preference pane tooltip"); -} - -- (BOOL)preferencePaneAllowsResizing -{ - return YES; -} - -#pragma mark - -#pragma mark Private API - -/** - * Sorts the connection favorites based on the selected criteria. - */ -- (void)_sortFavorites -{ - NSString *sortKey = SPFavoriteNameKey; - - switch (currentSortItem) - { - case SPFavoritesSortNameItem: - sortKey = SPFavoriteNameKey; - break; - case SPFavoritesSortHostItem: - sortKey = SPFavoriteHostKey; - break; - case SPFavoritesSortTypeItem: - sortKey = SPFavoriteTypeKey; - break; - } - - NSSortDescriptor *sortDescriptor = nil; - - if (currentSortItem == SPFavoritesSortTypeItem) { - sortDescriptor = [[[NSSortDescriptor alloc] initWithKey:sortKey ascending:(!reverseFavoritesSort)] autorelease]; - } - else { - sortDescriptor = [[[NSSortDescriptor alloc] initWithKey:sortKey ascending:(!reverseFavoritesSort) selector:@selector(caseInsensitiveCompare:)] autorelease]; - } - - [favoritesController setSortDescriptors:[NSArray arrayWithObject:sortDescriptor]]; - - [favoritesTableView reloadData]; - - [[(SPPreferenceController *)[[[self view] window] delegate] generalPreferencePane] updateDefaultFavoritePopup]; -} - -/** - * Check all fields used in the keychain names against the old values for that - * favorite, and update the keychain names to match if necessary. - * If an (optional) recognised password field is supplied, that field is assumed - * to have changed and is used to supply the new value. - */ -- (void)_updateFavoritePasswordsFromField:(NSControl *)passwordControl -{ - if (!currentFavorite) return; - - NSString *passwordValue; - NSString *oldKeychainName, *newKeychainName; - NSString *oldKeychainAccount, *newKeychainAccount; - NSString *oldHostnameForPassword = ([[currentFavorite objectForKey:@"type"] integerValue] == SPSocketConnection) ? @"localhost" : [currentFavorite objectForKey:@"host"]; - NSString *newHostnameForPassword = ([[favoritesController valueForKeyPath:@"selection.type"] integerValue] == SPSocketConnection) ? @"localhost" : [favoritesController valueForKeyPath:@"selection.host"]; - - // SQL passwords are indexed by name, host, user and database. If any of these - // have changed, or a standard password field has, alter the keychain item to match. - if (![[currentFavorite objectForKey:@"name"] isEqualToString:[favoritesController valueForKeyPath:@"selection.name"]] - || ![oldHostnameForPassword isEqualToString:newHostnameForPassword] - || ![[currentFavorite objectForKey:@"user"] isEqualToString:[favoritesController valueForKeyPath:@"selection.user"]] - || ![[currentFavorite objectForKey:@"database"] isEqualToString:[favoritesController valueForKeyPath:@"selection.database"]] - || passwordControl == standardPasswordField || passwordControl == socketPasswordField || passwordControl == sshSQLPasswordField) - { - - // Determine the correct password field to read the password from, defaulting to standard - if (passwordControl == socketPasswordField) { - passwordValue = [socketPasswordField stringValue]; - } - else if (passwordControl == sshSQLPasswordField) { - passwordValue = [sshSQLPasswordField stringValue]; - } - else { - passwordValue = [standardPasswordField stringValue]; - } - - // Get the old keychain name and account strings - oldKeychainName = [keychain nameForFavoriteName:[currentFavorite objectForKey:@"name"] id:[favoritesController valueForKeyPath:@"selection.id"]]; - oldKeychainAccount = [keychain accountForUser:[currentFavorite objectForKey:@"user"] host:oldHostnameForPassword database:[currentFavorite objectForKey:@"database"]]; - - // Delete the old keychain item - [keychain deletePasswordForName:oldKeychainName account:oldKeychainAccount]; - - // Set up the new keychain name and account strings - newKeychainName = [keychain nameForFavoriteName:[favoritesController valueForKeyPath:@"selection.name"] id:[favoritesController valueForKeyPath:@"selection.id"]]; - newKeychainAccount = [keychain accountForUser:[favoritesController valueForKeyPath:@"selection.user"] host:newHostnameForPassword database:[favoritesController valueForKeyPath:@"selection.database"]]; - - // Add the new keychain item if the password field has a value - if ([passwordValue length]) - [keychain addPassword:passwordValue forName:newKeychainName account:newKeychainAccount]; - - // Synch password changes - [standardPasswordField setStringValue:passwordValue]; - [socketPasswordField setStringValue:passwordValue]; - [sshSQLPasswordField setStringValue:passwordValue]; - - passwordValue = @""; - } - - // If SSH account/password details have changed, update the keychain to match - if (![[currentFavorite objectForKey:@"name"] isEqualToString:[favoritesController valueForKeyPath:@"selection.name"]] - || ![[currentFavorite objectForKey:@"sshHost"] isEqualToString:[favoritesController valueForKeyPath:@"selection.sshHost"]] - || ![[currentFavorite objectForKey:@"sshUser"] isEqualToString:[favoritesController valueForKeyPath:@"selection.sshUser"]] - || passwordControl == sshPasswordField) { - - // Get the old keychain name and account strings - oldKeychainName = [keychain nameForSSHForFavoriteName:[currentFavorite objectForKey:@"name"] id:[favoritesController valueForKeyPath:@"selection.id"]]; - oldKeychainAccount = [keychain accountForSSHUser:[currentFavorite objectForKey:@"sshUser"] sshHost:[currentFavorite objectForKey:@"sshHost"]]; - - // Delete the old keychain item - [keychain deletePasswordForName:oldKeychainName account:oldKeychainAccount]; - - // Set up the new keychain name and account strings - newKeychainName = [keychain nameForSSHForFavoriteName:[favoritesController valueForKeyPath:@"selection.name"] id:[favoritesController valueForKeyPath:@"selection.id"]]; - newKeychainAccount = [keychain accountForSSHUser:[favoritesController valueForKeyPath:@"selection.sshUser"] sshHost:[favoritesController valueForKeyPath:@"selection.sshHost"]]; - - // Add the new keychain item if the password field has a value - if ([[sshPasswordField stringValue] length]) - [keychain addPassword:[sshPasswordField stringValue] forName:newKeychainName account:newKeychainAccount]; - } - - // Update the current favorite - if (currentFavorite) [currentFavorite release], currentFavorite = nil; - - if ([[favoritesTableView selectedRowIndexes] count] > 0) - currentFavorite = [[[favoritesController selectedObjects] objectAtIndex:0] copy]; -} - -#pragma mark - - -- (void)dealloc -{ - [keychain release], keychain = nil; - - if (currentFavorite) [currentFavorite release], currentFavorite = nil; - - [super dealloc]; -} - -@end diff --git a/Source/SPFlippedView.h b/Source/SPFlippedView.h new file mode 100644 index 00000000..0270daf8 --- /dev/null +++ b/Source/SPFlippedView.h @@ -0,0 +1,28 @@ +// +// $Id$ +// +// SPFlippedView.h +// sequel-pro +// +// Created by Rowan Beentje on 28/06/2009. +// Copyright 2009 Arboreal. All rights reserved. +// +// This program is free software; you can redistribute it and/or modify +// it under the terms of the GNU General Public License as published by +// the Free Software Foundation; either version 2 of the License, or +// (at your option) any later version. +// +// This program is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +// GNU General Public License for more details. +// +// You should have received a copy of the GNU General Public License +// along with this program; if not, write to the Free Software +// Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA +// +// More info at <http://code.google.com/p/sequel-pro/> + +@interface SPFlippedView : NSView + +@end diff --git a/Source/SPFlippedView.m b/Source/SPFlippedView.m new file mode 100644 index 00000000..b5334488 --- /dev/null +++ b/Source/SPFlippedView.m @@ -0,0 +1,38 @@ +// +// $Id$ +// +// SPFlippedView.m +// sequel-pro +// +// Created by Rowan Beentje on 28/06/2009. +// Copyright 2009 Arboreal. All rights reserved. +// +// This program is free software; you can redistribute it and/or modify +// it under the terms of the GNU General Public License as published by +// the Free Software Foundation; either version 2 of the License, or +// (at your option) any later version. +// +// This program is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +// GNU General Public License for more details. +// +// You should have received a copy of the GNU General Public License +// along with this program; if not, write to the Free Software +// Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA +// +// More info at <http://code.google.com/p/sequel-pro/> + +#import "SPFlippedView.h" + +@implementation SPFlippedView + +/** + * Is flipped to simplify drawing. + */ +- (BOOL)isFlipped +{ + return YES; +} + +@end diff --git a/Source/SPGeneralPreferencePane.h b/Source/SPGeneralPreferencePane.h index 76343a83..ab7ef949 100644 --- a/Source/SPGeneralPreferencePane.h +++ b/Source/SPGeneralPreferencePane.h @@ -42,6 +42,5 @@ - (IBAction)updateDefaultFavorite:(id)sender; - (void)updateDefaultFavoritePopup; -- (void)resetDefaultFavoritePopupSelection; @end diff --git a/Source/SPGeneralPreferencePane.m b/Source/SPGeneralPreferencePane.m index b87d6ab8..36cbed9f 100644 --- a/Source/SPGeneralPreferencePane.m +++ b/Source/SPGeneralPreferencePane.m @@ -36,9 +36,8 @@ - (IBAction)updateDefaultFavorite:(id)sender { [prefs setBool:([defaultFavoritePopup indexOfSelectedItem] == 0) forKey:SPSelectLastFavoriteUsed]; - - // Minus 2 from index to account for the "Last Used" and separator items - [prefs setInteger:([defaultFavoritePopup indexOfSelectedItem] - 2) forKey:SPDefaultFavorite]; + + [prefs setInteger:[[sender selectedItem] tag] forKey:SPDefaultFavorite]; } #pragma mark - @@ -56,36 +55,24 @@ [[defaultFavoritePopup menu] addItem:[NSMenuItem separatorItem]]; // Add all favorites to the menu - for (NSString *favorite in [[favoritesController arrangedObjects] valueForKeyPath:@"name"]) + for (NSDictionary *favorite in [favoritesController arrangedObjects]) { - NSMenuItem *favoriteMenuItem = [[NSMenuItem alloc] initWithTitle:favorite action:NULL keyEquivalent:@""]; + NSMenuItem *favoriteMenuItem = [[NSMenuItem alloc] initWithTitle:[favorite objectForKey:SPFavoriteNameKey] action:NULL keyEquivalent:@""]; + + [favoriteMenuItem setTag:[[favorite objectForKey:SPFavoriteIDKey] integerValue]]; [[defaultFavoritePopup menu] addItem:favoriteMenuItem]; [favoriteMenuItem release]; } - // Add item to switch to edit favorites pane - [[defaultFavoritePopup menu] addItem:[NSMenuItem separatorItem]]; - - NSMenuItem *editMenuItem = [[NSMenuItem alloc] initWithTitle:NSLocalizedString(@"Edit Favorites…", @"edit favorites menu item") action:@selector(displayFavoritePreferences:) keyEquivalent:@""]; - - [editMenuItem setTarget:[[[self view] window] delegate]]; - - [[defaultFavoritePopup menu] addItem:editMenuItem]; - - [editMenuItem release]; - // Select the default favorite from prefs - [defaultFavoritePopup selectItemAtIndex:(![prefs boolForKey:SPSelectLastFavoriteUsed]) ? ([prefs integerForKey:SPDefaultFavorite] + 2) : 0]; -} - -/** - * Resets the default favorite popup button selection based on the user's preferences. - */ -- (void)resetDefaultFavoritePopupSelection -{ - [defaultFavoritePopup selectItemAtIndex:(![prefs boolForKey:SPSelectLastFavoriteUsed]) ? ([prefs integerForKey:SPDefaultFavorite] + 2) : 0]; + if (![prefs boolForKey:SPSelectLastFavoriteUsed]) { + [defaultFavoritePopup selectItemWithTag:[prefs integerForKey:SPDefaultFavorite]]; + } + else { + [defaultFavoritePopup selectItemAtIndex:0]; + } } #pragma mark - diff --git a/Source/SPGroupNode.h b/Source/SPGroupNode.h new file mode 100644 index 00000000..e5dad641 --- /dev/null +++ b/Source/SPGroupNode.h @@ -0,0 +1,47 @@ +// +// $Id$ +// +// SPGroupNode.h +// sequel-pro +// +// Created by Stuart Connolly (stuconnolly.com) on November 21, 2010 +// Copyright (c) 2010 Stuart Connolly. All rights reserved. +// +// This program is free software; you can redistribute it and/or modify +// it under the terms of the GNU General Public License as published by +// the Free Software Foundation; either version 2 of the License, or +// (at your option) any later version. +// +// This program is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +// GNU General Public License for more details. +// +// You should have received a copy of the GNU General Public License +// along with this program; if not, write to the Free Software +// Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA +// +// More info at <http://code.google.com/p/sequel-pro/> + +/** + * @class SPGroupNode SPGroupNode.h + * + * @author Stuart Connolly http://stuconnolly.com/ + * + * Tree node that represents a group. + */ +@interface SPGroupNode : NSObject <NSCopying> +{ + NSString *nodeName; +} + +/** + * @property nodeName The group node's name + */ +@property (readwrite, retain) NSString *nodeName; + +- (id)initWithName:(NSString *)name; + ++ (SPGroupNode *)groupNodeWithName:(NSString *)name; + +@end diff --git a/Source/SPGroupNode.m b/Source/SPGroupNode.m new file mode 100644 index 00000000..6687b29e --- /dev/null +++ b/Source/SPGroupNode.m @@ -0,0 +1,85 @@ +// +// $Id$ +// +// SPGroupNode.m +// sequel-pro +// +// Created by Stuart Connolly (stuconnolly.com) on November 21, 2010 +// Copyright (c) 2010 Stuart Connolly. All rights reserved. +// +// This program is free software; you can redistribute it and/or modify +// it under the terms of the GNU General Public License as published by +// the Free Software Foundation; either version 2 of the License, or +// (at your option) any later version. +// +// This program is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +// GNU General Public License for more details. +// +// You should have received a copy of the GNU General Public License +// along with this program; if not, write to the Free Software +// Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA +// +// More info at <http://code.google.com/p/sequel-pro/> + +#import "SPGroupNode.h" + +@implementation SPGroupNode + +@synthesize nodeName; + +#pragma mark - +#pragma mark Initialisation + +- (id)init +{ + if ((self = [super init])) { + [self setNodeName:nil]; + } + + return self; +} + +- (id)initWithName:(NSString *)name +{ + if ((self = [self init])) { + [self setNodeName:name]; + } + + return self; +} + ++ (SPGroupNode *)groupNodeWithName:(NSString *)name +{ + return [[[self alloc] initWithName:name] autorelease]; +} + +#pragma mark - +#pragma mark Copying protocol methods + +- (id)copyWithZone:(NSZone *)zone +{ + SPGroupNode *node = [[[self class] allocWithZone:zone] init]; + + [node setNodeName:[self nodeName]]; + + return node; +} + +#pragma mark - +#pragma mark Other + +- (NSString *)description +{ + return [NSString stringWithFormat:@"<%@: %p ('%@')>", [self className], self, [self nodeName]]; +} + +#pragma mark - + +- (void)dealloc +{ + if (nodeName) [nodeName release], nodeName = nil; +} + +@end diff --git a/Source/SPPreferenceController.h b/Source/SPPreferenceController.h index 575881af..7b0e0cc3 100644 --- a/Source/SPPreferenceController.h +++ b/Source/SPPreferenceController.h @@ -27,7 +27,6 @@ @class SPGeneralPreferencePane, SPTablesPreferencePane, - SPFavoritesPreferencePane, SPNotificationsPreferencePane, SPEditorPreferencePane, SPAutoUpdatePreferencePane, @@ -45,7 +44,6 @@ // Preference pane controllers IBOutlet SPGeneralPreferencePane *generalPreferencePane; IBOutlet SPTablesPreferencePane *tablesPreferencePane; - IBOutlet SPFavoritesPreferencePane *favoritesPreferencePane; IBOutlet SPNotificationsPreferencePane *notificationsPreferencePane; IBOutlet SPEditorPreferencePane *editorPreferencePane; IBOutlet SPAutoUpdatePreferencePane *autoUpdatePreferencePane; @@ -69,7 +67,6 @@ @property (readonly) SPGeneralPreferencePane *generalPreferencePane; @property (readonly) SPTablesPreferencePane *tablesPreferencePane; -@property (readonly) SPFavoritesPreferencePane *favoritesPreferencePane; @property (readonly) SPNotificationsPreferencePane *notificationsPreferencePane; @property (readonly) SPEditorPreferencePane *editorPreferencePane; @property (readonly) SPAutoUpdatePreferencePane *autoUpdatePreferencePane; diff --git a/Source/SPPreferenceController.m b/Source/SPPreferenceController.m index 8a9eb530..7592319a 100644 --- a/Source/SPPreferenceController.m +++ b/Source/SPPreferenceController.m @@ -39,7 +39,6 @@ @synthesize generalPreferencePane; @synthesize tablesPreferencePane; -@synthesize favoritesPreferencePane; @synthesize notificationsPreferencePane; @synthesize editorPreferencePane; @synthesize autoUpdatePreferencePane; @@ -75,7 +74,6 @@ generalPreferencePane, tablesPreferencePane, notificationsPreferencePane, - favoritesPreferencePane, editorPreferencePane, autoUpdatePreferencePane, networkPreferencePane, @@ -125,27 +123,6 @@ [self _resizeWindowForContentView:[tablesPreferencePane preferencePaneView]]; } -/** - * Displays the favorite preferences pane. - */ -- (IBAction)displayFavoritePreferences:(id)sender -{ - // To make the Favorites pane resizable give the window a minimum size and display the resize indicator. - // Notice that we still make all other panes non-resizable by removing the dsiplay of the indicator and - // resetting the minimum size to zero. - [[self window] setMinSize:NSMakeSize(500, 381)]; - [[self window] setShowsResizeIndicator:[favoritesPreferencePane preferencePaneAllowsResizing]]; - - [toolbar setSelectedItemIdentifier:[favoritesPreferencePane preferencePaneIdentifier]]; - - [self _resizeWindowForContentView:[favoritesPreferencePane preferencePaneView]]; - - // Set the default favorite popup back to preference - if ([sender isKindOfClass:[NSMenuItem class]]) { - [generalPreferencePane resetDefaultFavoritePopupSelection]; - } -} - /** * Displays the editor preferences pane. */ @@ -223,14 +200,6 @@ [tablesItem setTarget:self]; [tablesItem setAction:@selector(displayTablePreferences:)]; - // Favorite preferences - favoritesItem = [[NSToolbarItem alloc] initWithItemIdentifier:[favoritesPreferencePane preferencePaneIdentifier]]; - - [favoritesItem setLabel:[favoritesPreferencePane preferencePaneName]]; - [favoritesItem setImage:[favoritesPreferencePane preferencePaneIcon]]; - [favoritesItem setTarget:self]; - [favoritesItem setAction:@selector(displayFavoritePreferences:)]; - // Notification preferences notificationsItem = [[NSToolbarItem alloc] initWithItemIdentifier:[notificationsPreferencePane preferencePaneIdentifier]]; diff --git a/Source/SPPreferenceControllerDelegate.m b/Source/SPPreferenceControllerDelegate.m index 56bb807a..5b531066 100644 --- a/Source/SPPreferenceControllerDelegate.m +++ b/Source/SPPreferenceControllerDelegate.m @@ -65,9 +65,6 @@ else if ([itemIdentifier isEqualToString:SPPreferenceToolbarTables]) { return tablesItem; } - else if ([itemIdentifier isEqualToString:SPPreferenceToolbarFavorites]) { - return favoritesItem; - } else if ([itemIdentifier isEqualToString:SPPreferenceToolbarNotifications]) { return notificationsItem; } @@ -92,7 +89,6 @@ return [NSArray arrayWithObjects: SPPreferenceToolbarGeneral, SPPreferenceToolbarTables, - SPPreferenceToolbarFavorites, SPPreferenceToolbarNotifications, SPPreferenceToolbarEditor, SPPreferenceToolbarShortcuts, @@ -106,7 +102,6 @@ return [NSArray arrayWithObjects: SPPreferenceToolbarGeneral, SPPreferenceToolbarTables, - SPPreferenceToolbarFavorites, SPPreferenceToolbarNotifications, SPPreferenceToolbarEditor, SPPreferenceToolbarShortcuts, @@ -120,7 +115,6 @@ return [NSArray arrayWithObjects: SPPreferenceToolbarGeneral, SPPreferenceToolbarTables, - SPPreferenceToolbarFavorites, SPPreferenceToolbarNotifications, SPPreferenceToolbarEditor, SPPreferenceToolbarShortcuts, diff --git a/Source/SPPreferencesUpgrade.m b/Source/SPPreferencesUpgrade.m index 7b1c31cf..a6a5ef4f 100644 --- a/Source/SPPreferencesUpgrade.m +++ b/Source/SPPreferencesUpgrade.m @@ -121,7 +121,7 @@ void SPApplyRevisionChanges(void) @"showError", SPShowNoAffectedRowsError, @"connectionTimeout", SPConnectionTimeoutValue, @"keepAliveInterval", SPKeepAliveInterval, - @"lastFavoriteIndex", SPLastFavoriteIndex, + @"lastFavoriteIndex", SPLastFavoriteID, nil]; keyEnumerator = [keysToUpgrade keyEnumerator]; @@ -298,7 +298,7 @@ void SPApplyRevisionChanges(void) } /** - * Attempts to migrate the user's connection favorites from their preference file to the new Favaorites + * Attempts to migrate the user's connection favorites from their preference file to the new favorites * plist in the application's support 'Data' directory. */ void SPMigrateConnectionFavoritesData(void) @@ -307,6 +307,26 @@ void SPMigrateConnectionFavoritesData(void) NSFileManager *fileManager = [NSFileManager defaultManager]; NSUserDefaults *prefs = [NSUserDefaults standardUserDefaults]; + NSMutableArray *favorites = [[NSMutableArray alloc] initWithArray:[prefs objectForKey:SPFavorites]]; + + // Change the last used favorite and default favorite's indexes to be ID based + if (![prefs objectForKey:SPLastFavoriteID]) { + + NSInteger lastFavoriteIndex = [prefs integerForKey:@"LastFavoriteIndex"]; + NSInteger defaultFavoriteIndex = [prefs integerForKey:SPDefaultFavorite]; + + if ((lastFavoriteIndex >= 0) && (lastFavoriteIndex <= [favorites count])) { + [prefs setInteger:[[[favorites objectAtIndex:lastFavoriteIndex] objectForKey:SPFavoriteIDKey] integerValue] forKey:SPLastFavoriteID]; + } + + if ((defaultFavoriteIndex >= 0) && (defaultFavoriteIndex <= [favorites count])) { + [prefs setInteger:[[[favorites objectAtIndex:defaultFavoriteIndex] objectForKey:SPFavoriteIDKey] integerValue] forKey:SPDefaultFavorite]; + } + + // TOOD: Only uncomment when migration is complete + //[prefs removeObjectForKey:@"LastFavoriteIndex"]; + } + NSString *dataPath = [fileManager applicationSupportDirectoryForSubDirectory:SPDataSupportFolder error:&error]; if (error) { @@ -319,7 +339,7 @@ void SPMigrateConnectionFavoritesData(void) // Only proceed if the new favorites plist doesn't already exist if (![fileManager fileExistsAtPath:favoritesFile]) { - NSDictionary *newFavorites = [NSDictionary dictionaryWithObject:[NSDictionary dictionaryWithObjectsAndKeys:NSLocalizedString(@"Favorites", @"favorites label"), SPFavoritesGroupNameKey, [prefs objectForKey:SPFavorites], SPFavoriteChildrenKey, nil] forKey:SPFavoritesRootKey]; + NSDictionary *newFavorites = [NSDictionary dictionaryWithObject:[NSDictionary dictionaryWithObjectsAndKeys:NSLocalizedString(@"Favorites", @"favorites label"), SPFavoritesGroupNameKey, favorites, SPFavoriteChildrenKey, nil] forKey:SPFavoritesRootKey]; error = nil; NSString *errorString = nil; @@ -334,7 +354,7 @@ void SPMigrateConnectionFavoritesData(void) NSLog(@"Error migrating favorites data: %@", [error localizedDescription]); } else { - // Only uncomment when migration is complete + // TODO: Only uncomment when migration is complete //[prefs removeObjectForKey:SPFavorites]; } } @@ -345,6 +365,8 @@ void SPMigrateConnectionFavoritesData(void) return; } } + + [favorites release]; } @end diff --git a/Source/SPProcessListController.m b/Source/SPProcessListController.m index 82075eac..d6b5c186 100644 --- a/Source/SPProcessListController.m +++ b/Source/SPProcessListController.m @@ -27,6 +27,9 @@ #import "SPDatabaseDocument.h" #import "SPAlertSheets.h" +// Constants +static const NSString *SPKillProcessQueryMode = @"SPKillProcessQueryMode"; +static const NSString *SPKillProcessConnectionMode = @"SPKillProcessConnectionMode"; static const NSString *SPTableViewIDColumnIdentifier = @"Id"; @interface SPProcessListController (PrivateAPI) diff --git a/Source/SPTreeNode.h b/Source/SPTreeNode.h new file mode 100644 index 00000000..f93157ea --- /dev/null +++ b/Source/SPTreeNode.h @@ -0,0 +1,56 @@ +// +// $Id$ +// +// SPTreeNode.h +// sequel-pro +// +// Created by Stuart Connolly (stuconnolly.com) on November 23, 2010 +// Copyright (c) 2010 Stuart Connolly. All rights reserved. +// +// This program is free software; you can redistribute it and/or modify +// it under the terms of the GNU General Public License as published by +// the Free Software Foundation; either version 2 of the License, or +// (at your option) any later version. +// +// This program is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +// GNU General Public License for more details. +// +// You should have received a copy of the GNU General Public License +// along with this program; if not, write to the Free Software +// Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA +// +// More info at <http://code.google.com/p/sequel-pro/> + +/** + * @class SPTreeNode SPTreeNode.h + * + * @author Stuart Connolly http://stuconnolly.com/ + * + * NSTreeNode subclass which adds some convenience methods. + */ +@interface SPTreeNode : NSTreeNode +{ + BOOL isGroup; +} + +/** + * @property isGroup Indicates whether or not the node is a group. + */ +@property (readwrite, assign) BOOL isGroup; + +- (void)removeObjectFromChildren:(id)object; + +- (NSArray *)descendants; +- (NSArray *)allChildLeafs; +- (NSArray *)groupChildren; + +- (SPTreeNode *)parentFromArray:(NSArray *)array; + +- (BOOL)isDescendantOfOrOneOfNodes:(NSArray *)nodes; +- (BOOL)isDescendantOfNodes:(NSArray *)nodes; + +- (NSDictionary *)dictionaryRepresentation; + +@end diff --git a/Source/SPTreeNode.m b/Source/SPTreeNode.m new file mode 100644 index 00000000..507939c4 --- /dev/null +++ b/Source/SPTreeNode.m @@ -0,0 +1,252 @@ +// +// $Id$ +// +// SPTreeNode.m +// sequel-pro +// +// Created by Stuart Connolly (stuconnolly.com) on November 23, 2010 +// Copyright (c) 2010 Stuart Connolly. All rights reserved. +// +// This program is free software; you can redistribute it and/or modify +// it under the terms of the GNU General Public License as published by +// the Free Software Foundation; either version 2 of the License, or +// (at your option) any later version. +// +// This program is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +// GNU General Public License for more details. +// +// You should have received a copy of the GNU General Public License +// along with this program; if not, write to the Free Software +// Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA +// +// More info at <http://code.google.com/p/sequel-pro/> + +#import "SPTreeNode.h" +#import "SPFavoriteNode.h" +#import "SPGroupNode.h" + +@implementation SPTreeNode + +@synthesize isGroup; + +#pragma mark - +#pragma mark Initialisation + ++ (id)treeNodeWithRepresentedObject:(id)object +{ + return [[[SPTreeNode alloc] initWithRepresentedObject:object] autorelease]; +} + +- (id)initWithRepresentedObject:(id)object +{ + if ((self = [super initWithRepresentedObject:object])) { + [self setIsGroup:NO]; + } + + return self; +} + +#pragma mark - +#pragma mark Public API + +/** + * Recursive method which searches children and children of all sub-nodes + * to remove the supplied object. + * + * @param object The object to remove + */ +- (void)removeObjectFromChildren:(id)object +{ + for (SPTreeNode *node in [self childNodes]) + { + if (node == object) { + [[self childNodes] removeObjectIdenticalTo:object]; + return; + } + + if (![node isLeaf]) { + [node removeObjectFromChildren:object]; + } + } +} + +/** + * Generates an array of all descendants. + * + * @return The array of decendant nodes. + */ +- (NSArray *)descendants +{ + NSMutableArray *descendants = [NSMutableArray array]; + + for (SPTreeNode *node in [self childNodes]) + { + [descendants addObject:node]; + + if (![node isLeaf]) { + [descendants addObjectsFromArray:[node descendants]]; + } + } + + return descendants; +} + +/** + * Generates an array of all leafs in children and children of all sub-nodes. + * + * @return The array of child nodes. + */ +- (NSArray *)allChildLeafs +{ + NSMutableArray *childLeafs = [NSMutableArray array]; + + for (SPTreeNode *node in [self childNodes]) + { + if ([node isLeaf]) { + [childLeafs addObject:node]; + } + else { + [childLeafs addObjectsFromArray:[node allChildLeafs]]; + } + } + + return childLeafs; +} + +/** + * Returns only the children that are group nodes. + * + * @return The array of child group nodes. + */ +- (NSArray *)groupChildren +{ + NSMutableArray *groupChildren = [NSMutableArray array]; + + for (SPTreeNode *node in [self childNodes]) + { + if (![node isLeaf]) { + [groupChildren addObject:node]; + } + } + + return groupChildren; +} + +/** + * Finds the receiver's parent from the supplied array of nodes. + * + * @param array The array of nodes + * + * @return The parent of this instance of nil if not found + */ +- (SPTreeNode *)parentFromArray:(NSArray *)array +{ + SPTreeNode *result = nil; + + for (SPTreeNode *node in array) + { + if (node == self) break; + + if ([[node childNodes] indexOfObjectIdenticalTo:self] != NSNotFound) { + result = node; + break; + } + + if (![node isLeaf]) { + SPTreeNode *innerNode = [self parentFromArray:[node childNodes]]; + + if (innerNode) { + result = innerNode; + break; + } + } + } + + return result; +} + +/** + * Returns YES if self is contained anywhere inside the children or children of + * sub-nodes of the nodes contained inside the supplied array. + * + * @param nodes + * + * @return + */ +- (BOOL)isDescendantOfOrOneOfNodes:(NSArray *)nodes +{ + for (SPTreeNode *node in nodes) + { + if (node == self) return YES; + + // Check all the sub-nodes + if (![node isLeaf]) { + if ([self isDescendantOfOrOneOfNodes:[node childNodes]]) { + return YES; + } + } + } + + return NO; +} + +/** + * Returns YES if any node in the array passed in is an ancestor of ours. + * + * @param nodes + * + * @return + */ +- (BOOL)isDescendantOfNodes:(NSArray *)nodes +{ + for (SPTreeNode *node in nodes) + { + // Check all the sub-nodes + if (![node isLeaf]) { + if ([self isDescendantOfOrOneOfNodes:[node childNodes]]) { + return YES; + } + } + } + + return NO; +} + +/** + * Constructs a dictionary representation of the favorite. + * + * @return The dictionary representation. + */ +- (NSDictionary *)dictionaryRepresentation +{ + NSMutableDictionary *dictionary = nil; + + id object = [self representedObject]; + + if ([object isKindOfClass:[SPFavoriteNode class]]) { + + dictionary = [NSDictionary dictionaryWithDictionary:[object nodeFavorite]]; + } + else if ([object isKindOfClass:[SPGroupNode class]]) { + + NSMutableArray *children = [NSMutableArray array]; + + for (SPTreeNode *node in [self childNodes]) + { + [children addObject:[node dictionaryRepresentation]]; + } + + dictionary = [NSMutableDictionary dictionary]; + + NSString *name = (![self parentNode]) ? NSLocalizedString(@"Favorites", @"favorites label") : [object nodeName]; + + [dictionary setObject:(name) ? name : @"" forKey:SPFavoritesGroupNameKey]; + [dictionary setObject:children forKey:SPFavoriteChildrenKey]; + } + + return dictionary; +} + +@end |