Rework relation addition and name lookups following testing and research:

 - Remove the background lookup of table constraint names for the current database.  This prevented connection use while the query was running, and the query cannot be optimised and severely taxes servers with many databases.  Revert to checking names against names in the current database
 - Repurpose the activity spinner for adding relation query execution
 - When an error is encountered adding a relation, re-open the sheet with the submitted values after displaying the error
 - Add use of 'SHOW InnoDB STATUS' command and text extraction to show more explicit errors for the most common constraint errors

1 files changed, 1 insertions, 3 deletions

diff --git a/Source/SPTableRelations.h b/Source/SPTableRelations.h
index a600ebf0..5a8b9c40 100644
--- a/Source/SPTableRelations.h
+++ b/Source/SPTableRelations.h
@@ -58,8 +58,6 @@
 	NSUserDefaults *prefs;
 	NSMutableArray *relationData;
 	NSMutableArray *takenConstraintNames;
-	
-	BOOL isRetrievingRelationNames;
 }
 
 @property (readonly) NSMutableArray *relationData;
@@ -68,6 +66,7 @@
 // IB action methods
 - (IBAction)addRelation:(id)sender;
 - (IBAction)removeRelation:(id)sender;
+- (IBAction)openRelationSheet:(id)sender;
 - (IBAction)closeRelationSheet:(id)sender;
 - (IBAction)confirmAddRelation:(id)sender;
 - (IBAction)selectTableColumn:(id)sender;
@@ -81,7 +80,6 @@
 - (void)endDocumentTaskForTab:(NSNotification *)aNotification;
 
 // Other
-- (void)loadUsedRelationNames;
 - (NSArray *)relationDataForPrinting;
 - (void)alertDidEnd:(NSAlert *)alert returnCode:(NSInteger)returnCode contextInfo:(NSString *)contextInfo;