Various improvements to server capability/version checking, including:

- Add a new ServerSupport class, for which an instance is created upon each new connection and is then subsequently accessible via SPDatabaseDocument.
- Replace the majority of manual version checking with calls to properties in the above new class.
- Improve the user manager's compatibility with MySQL 3 and 4 servers. Fixes issue #811

Other changes include:

- Disable the encoding popup button when adding a new table or database to servers running pre MySQL 4.1 as it only contains one option, 'Default'.
- Fix various potential memory leaks discovered during static analysis.
- General tidy up and comments.

1 files changed, 5 insertions, 7 deletions

diff --git a/Source/SPTableData.m b/Source/SPTableData.m
index fc410044..d3e01471 100644
--- a/Source/SPTableData.m
+++ b/Source/SPTableData.m
@@ -32,6 +32,7 @@
 #import "SPConstants.h"
 #import "SPAlertSheets.h"
 #import "RegexKitLite.h"
+#import "SPServerSupport.h"
 
 @implementation SPTableData
 
@@ -147,19 +148,16 @@
  */
 - (NSArray *) triggers
 {
-
 	// Return if CREATE SYNTAX is being parsed
-	if(isWorking) return [NSArray array];
+	if (isWorking) return [NSArray array];
 	
 
 	// If triggers is nil, the triggers need to be loaded - if a table is selected on MySQL >= 5.0.2
 	if (!triggers) {
-		if ([tableListInstance tableType] == SPTableTypeTable
-			&& [mySQLConnection serverMajorVersion]		>= 5
-			&& [mySQLConnection serverMinorVersion]		>= 0)
-		{
+		if (([tableListInstance tableType] == SPTableTypeTable) && [[tableDocumentInstance serverSupport] supportsTriggers]) {
 			[self updateTriggersForCurrentTable];
-		} else {
+		} 
+		else {
 			return [NSArray array];
 		}
 	}