Various improvements to server capability/version checking, including:

- Add a new ServerSupport class, for which an instance is created upon each new connection and is then subsequently accessible via SPDatabaseDocument.
- Replace the majority of manual version checking with calls to properties in the above new class.
- Improve the user manager's compatibility with MySQL 3 and 4 servers. Fixes issue #811

Other changes include:

- Disable the encoding popup button when adding a new table or database to servers running pre MySQL 4.1 as it only contains one option, 'Default'.
- Fix various potential memory leaks discovered during static analysis.
- General tidy up and comments.

1 files changed, 2 insertions, 6 deletions

diff --git a/Source/SPTableCopy.m b/Source/SPTableCopy.m
index be486cf2..d390243c 100644
--- a/Source/SPTableCopy.m
+++ b/Source/SPTableCopy.m
@@ -53,13 +53,9 @@
 
 		[connection queryString:createTableStatement];		
 	
-		if ([connection queryErrored]) {
-			[createTableStatement release];
-			
-			return NO;
-		}
+		[createTableStatement release];
 		
-		return YES;
+		return [connection queryErrored];
 	}
 	
 	[createTableStatement release];