diff options
| author | stuconnolly <stuart02@gmail.com> | 2010-10-07 18:56:33 +0000 |
|---|---|---|
| committer | stuconnolly <stuart02@gmail.com> | 2010-10-07 18:56:33 +0000 |
| commit | 44a5f9e552b3d5e1f9ef1c6d11f34e893d67e85b (patch) | |
| tree | c833ba970d8cae5f756a31bc274e365c0a44b3bf /Source/SPSQLExporter.m | |
| parent | 95d2e4acc393e91aa70ed4c71daa1f776454a936 (diff) | |
| download | sequelpro-44a5f9e552b3d5e1f9ef1c6d11f34e893d67e85b.tar.gz sequelpro-44a5f9e552b3d5e1f9ef1c6d11f34e893d67e85b.tar.bz2 sequelpro-44a5f9e552b3d5e1f9ef1c6d11f34e893d67e85b.zip | |
Various improvements to server capability/version checking, including:
- Add a new ServerSupport class, for which an instance is created upon each new connection and is then subsequently accessible via SPDatabaseDocument.
- Replace the majority of manual version checking with calls to properties in the above new class.
- Improve the user manager's compatibility with MySQL 3 and 4 servers. Fixes issue #811
Other changes include:
- Disable the encoding popup button when adding a new table or database to servers running pre MySQL 4.1 as it only contains one option, 'Default'.
- Fix various potential memory leaks discovered during static analysis.
- General tidy up and comments.
Diffstat (limited to 'Source/SPSQLExporter.m')
| -rw-r--r-- | Source/SPSQLExporter.m | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/Source/SPSQLExporter.m b/Source/SPSQLExporter.m index 323c01b3..becccab2 100644 --- a/Source/SPSQLExporter.m +++ b/Source/SPSQLExporter.m @@ -499,6 +499,8 @@ { // Check for cancellation flag if ([self isCancelled]) { + [errors release]; + [sqlString release]; [pool release]; return; } @@ -565,6 +567,8 @@ { // Check for cancellation flag if ([self isCancelled]) { + [errors release]; + [sqlString release]; [pool release]; return; } @@ -595,6 +599,8 @@ { // Check for cancellation flag if ([self isCancelled]) { + [errors release]; + [sqlString release]; [pool release]; return; } @@ -609,6 +615,8 @@ // Check for cancellation flag if ([self isCancelled]) { [proceduresList release]; + [errors release]; + [sqlString release]; [pool release]; return; } |