diff options
| author | stuconnolly <stuart02@gmail.com> | 2010-10-07 18:56:33 +0000 |
|---|---|---|
| committer | stuconnolly <stuart02@gmail.com> | 2010-10-07 18:56:33 +0000 |
| commit | 44a5f9e552b3d5e1f9ef1c6d11f34e893d67e85b (patch) | |
| tree | c833ba970d8cae5f756a31bc274e365c0a44b3bf /Source/SPIndexesController.m | |
| parent | 95d2e4acc393e91aa70ed4c71daa1f776454a936 (diff) | |
| download | sequelpro-44a5f9e552b3d5e1f9ef1c6d11f34e893d67e85b.tar.gz sequelpro-44a5f9e552b3d5e1f9ef1c6d11f34e893d67e85b.tar.bz2 sequelpro-44a5f9e552b3d5e1f9ef1c6d11f34e893d67e85b.zip | |
Various improvements to server capability/version checking, including:
- Add a new ServerSupport class, for which an instance is created upon each new connection and is then subsequently accessible via SPDatabaseDocument.
- Replace the majority of manual version checking with calls to properties in the above new class.
- Improve the user manager's compatibility with MySQL 3 and 4 servers. Fixes issue #811
Other changes include:
- Disable the encoding popup button when adding a new table or database to servers running pre MySQL 4.1 as it only contains one option, 'Default'.
- Fix various potential memory leaks discovered during static analysis.
- General tidy up and comments.
Diffstat (limited to 'Source/SPIndexesController.m')
| -rw-r--r-- | Source/SPIndexesController.m | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/Source/SPIndexesController.m b/Source/SPIndexesController.m index 21e1a66c..bd7d9253 100644 --- a/Source/SPIndexesController.m +++ b/Source/SPIndexesController.m @@ -26,6 +26,7 @@ #import "SPIndexesController.h" #import "SPConstants.h" #import "SPAlertSheets.h" +#import "SPServerSupport.h" // Constants NSString *SPNewIndexIndexName = @"IndexName"; @@ -164,7 +165,7 @@ NSString *SPNewIndexKeyBlockSize = @"IndexKeyBlockSize"; // The ability to specify an index's key block size was added in MySQL 5.1.10 so disable the textfield // if it's not supported. - [indexKeyBlockSizeTextField setEnabled:(([connection serverMajorVersion] >= 5) && ([connection serverMinorVersion] >= 1) && ([connection serverReleaseVersion] >= 10))]; + [indexKeyBlockSizeTextField setEnabled:[[dbDocument serverSupport] supportsIndexKeyBlockSize]]; // Begin the sheet [NSApp beginSheet:[self window] |