diff options
| author | rowanbeentje <rowan@beent.je> | 2010-08-01 19:32:27 +0000 |
|---|---|---|
| committer | rowanbeentje <rowan@beent.je> | 2010-08-01 19:32:27 +0000 |
| commit | 43a9629aecaf21c37348c81a88f249fc8afe04dd (patch) | |
| tree | 745d60716a9e748dfdaa436ea51c72fcb0851f26 /Source/SPFieldMapperController.m | |
| parent | c2f2a6d1d126e8cb658b745bf5a534ca7307476d (diff) | |
| download | sequelpro-43a9629aecaf21c37348c81a88f249fc8afe04dd.tar.gz sequelpro-43a9629aecaf21c37348c81a88f249fc8afe04dd.tar.bz2 sequelpro-43a9629aecaf21c37348c81a88f249fc8afe04dd.zip | |
Merge in a range of bugfixes from trunk:
r2201, r2470 (Table trigger improvements, and fixes for MySQL <3.23.5x)
r2211, r2214, r2232, r2245, r2247, r2265, r2266, r2267, r2280 (User manager fixes)
r2213 (Incorrect count display)
r2215, r2270, r2283, r2285, r2471 (Thread-safety fixes)
r2216 (Task progress indicator fixes)
r2217 (CSV import field mapping fix)
r2218, r2219 (Custom queries fixes)
r2222 (Fix issues when opening files)
r2223 (Fixes problems copying binary data as tab-delimited strings)
r2224 (Fixes 10.5 not appending correct extension on export)
r2225, r2324 (Fixes to background database structure querying, extend structure querying to MySQL 3 & 4)
r2227 (Fixes to table saving on right-clicking)
r2228 (Memory use fixes)
r2272, r2279, r2286, r2398, r2399, r2420 (Favourites sorting)
r2275 (Improved handling of corrupt tables, disabled storage engines etc)
r2278 (Custom query autocomplete tab snippets not working under 10.5)
r2297 (Fix structure editing errors)
r2307 (Make return key behaviour in structure view consistent with content view)
r2335 (Fix crashes when cancelling/stopping queries on MySQL 3 & 4)
r2345 (Import from clipboard improvements)
r2362 (Improve robustness when closing windows quickly)
r2384 (Respect "Reload after editing" preference when editing custom query results)
r2385 (Prevent custom query uppercasing of reserved keywords which are quoted)
r2396 (Improve reordering of TIMESTAMP fields)
r2411, r2444, r2446 (Improve Xcode 3.2.3 project compatibility)
r2438 (Fix exceptions printing extended table info)
r2441 (Fix resizing table information after initial collapsed state)
r2445 (Improve default socket search paths)
r2463 (Fix custom query capturing up/down arrow when autocomplete finds no matches)
r2479, r2482 (Replace Core Animation with custom code to fix hangs)
r2486 (Improve data storage exceptions)
Diffstat (limited to 'Source/SPFieldMapperController.m')
| -rw-r--r-- | Source/SPFieldMapperController.m | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/Source/SPFieldMapperController.m b/Source/SPFieldMapperController.m index ae935b44..cf997dd0 100644 --- a/Source/SPFieldMapperController.m +++ b/Source/SPFieldMapperController.m @@ -155,6 +155,7 @@ if (fieldMappingGlobalValues) [fieldMappingGlobalValues release]; if (fieldMappingGlobalValuesSQLMarked) [fieldMappingGlobalValuesSQLMarked release]; if (fieldMappingTableDefaultValues) [fieldMappingTableDefaultValues release]; + if (primaryKeyField) [primaryKeyField release]; [super dealloc]; } @@ -351,7 +352,8 @@ [fieldMappingTableDefaultValues addObject:@"0"]; } targetTableHasPrimaryKey = YES; - primaryKeyField = [tableDetails objectForKey:@"primarykeyfield"]; + if (primaryKeyField) [primaryKeyField release]; + primaryKeyField = [[tableDetails objectForKey:@"primarykeyfield"] retain]; } else { if([column objectForKey:@"unique"]) { [type appendFormat:@",%@",@"UNIQUE"]; @@ -776,7 +778,7 @@ - (void)sheetDidEnd:(NSWindow *)sheet returnCode:(NSInteger)returnCode contextInfo:(void *)contextInfo { - [sheet orderOut:self]; + if ([sheet respondsToSelector:@selector(orderOut:)]) [sheet orderOut:nil]; if (sheet == globalValuesSheet) [self updateFieldMappingButtonCell]; } |