diff options
author | rowanbeentje <rowan@beent.je> | 2010-03-14 15:57:46 +0000 |
---|---|---|
committer | rowanbeentje <rowan@beent.je> | 2010-03-14 15:57:46 +0000 |
commit | bd4ef6874d0037ee85f25e6aeb9c4c5e4c361baa (patch) | |
tree | 98dcc63f2cae911f2ae9f7f1fc2af3290dd5a265 /Source/SPFavoriteTextFieldCell.m | |
parent | 094c2779974ba765fc42af063d094e2dc136f225 (diff) | |
download | sequelpro-bd4ef6874d0037ee85f25e6aeb9c4c5e4c361baa.tar.gz sequelpro-bd4ef6874d0037ee85f25e6aeb9c4c5e4c361baa.tar.bz2 sequelpro-bd4ef6874d0037ee85f25e6aeb9c4c5e4c361baa.zip |
- Review copyWithZone: implementations and standardise on best practice recommendations
Diffstat (limited to 'Source/SPFavoriteTextFieldCell.m')
-rw-r--r-- | Source/SPFavoriteTextFieldCell.m | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/Source/SPFavoriteTextFieldCell.m b/Source/SPFavoriteTextFieldCell.m index 446e8161..1ef39348 100644 --- a/Source/SPFavoriteTextFieldCell.m +++ b/Source/SPFavoriteTextFieldCell.m @@ -46,6 +46,8 @@ if ((self = [super init])) { mainStringColor = [NSColor blackColor]; subStringColor = [NSColor grayColor]; + favoriteName = nil; + favoriteHost = nil; } return self; @@ -59,10 +61,10 @@ SPFavoriteTextFieldCell *cell = (SPFavoriteTextFieldCell *)[super copyWithZone:zone]; cell->favoriteName = nil; - cell->favoriteName = [favoriteName retain]; + if (favoriteName) cell->favoriteName = [favoriteName copyWithZone:zone]; cell->favoriteHost = nil; - cell->favoriteHost = [favoriteHost retain]; + if (favoriteHost) cell->favoriteHost = [favoriteHost copyWithZone:zone]; return cell; } |