diff options
| author | rowanbeentje <rowan@beent.je> | 2010-06-07 13:44:45 +0000 |
|---|---|---|
| committer | rowanbeentje <rowan@beent.je> | 2010-06-07 13:44:45 +0000 |
| commit | 4c7cbdf882ad1e1bb1a5a11dc59dc53b90bee686 (patch) | |
| tree | ffa901519ec9b970a76f6437feb39de65e04498a /Source/SPExportController.m | |
| parent | 42781adb6cfa7f01f3763aade1b5043995930756 (diff) | |
| download | sequelpro-4c7cbdf882ad1e1bb1a5a11dc59dc53b90bee686.tar.gz sequelpro-4c7cbdf882ad1e1bb1a5a11dc59dc53b90bee686.tar.bz2 sequelpro-4c7cbdf882ad1e1bb1a5a11dc59dc53b90bee686.zip | |
A number of exporter improvements:
- Improve interface validation on the SQL view, including fixing no-content toggling
- Fix the export of views to correctly construct placeholder tables and fix view syntax export (this addresses Issue #707)
- Fix logic controlling Stored Procedure and Function export - fix hangs and allow correct export
- Handle permission errors when retrieving Stored Pro/Function syntax
- Improve export of linebreaks in CSV quoted cells for improved Excel compatibility
- SQL export now retrieves table syntax as it progresses through the tables - more accurate progress bar and removes initial pause when exporting lots of tables
- Alter filename construction to use centralised filename string: fixes end export Growl notification
- Improve dump comments
Diffstat (limited to 'Source/SPExportController.m')
| -rw-r--r-- | Source/SPExportController.m | 13 |
1 files changed, 6 insertions, 7 deletions
diff --git a/Source/SPExportController.m b/Source/SPExportController.m index 6da5b544..ca4f1ac8 100644 --- a/Source/SPExportController.m +++ b/Source/SPExportController.m @@ -67,7 +67,7 @@ exportTableCount = 0; currentTableExportIndex = 0; - exportFilename = @""; + exportFilename = [[NSMutableString alloc] init]; exportTypeLabel = @""; createCustomFilename = NO; @@ -520,9 +520,7 @@ */ - (IBAction)toggleSQLIncludeContent:(id)sender { - [sender setTag:[sender state]]; - - [self selectDeselectAllTables:sender]; + [[exportTableList tableColumnWithIdentifier:@"content"] setHidden:(![sender state])]; [self _toggleExportButtonOnBackgroundThread]; } @@ -640,6 +638,7 @@ [tables release], tables = nil; [exporters release], exporters = nil; [operationQueue release], operationQueue = nil; + [exportFilename release], exportFilename = nil; if (sqlPreviousConnectionEncoding) [sqlPreviousConnectionEncoding release], sqlPreviousConnectionEncoding = nil; @@ -678,9 +677,9 @@ } } else if (isSQL) { - BOOL structureEnabled = [uiStateDict objectForKey:@"SQLExportStructureEnabled"]; - BOOL contentEnabled = [uiStateDict objectForKey:@"SQLExportContentEnabled"]; - BOOL dropEnabled = [uiStateDict objectForKey:@"SQLExportDropEnabled"]; + BOOL structureEnabled = [[uiStateDict objectForKey:@"SQLExportStructureEnabled"] integerValue]; + BOOL contentEnabled = [[uiStateDict objectForKey:@"SQLExportContentEnabled"] integerValue]; + BOOL dropEnabled = [[uiStateDict objectForKey:@"SQLExportDropEnabled"] integerValue]; // Disable if all are unchecked if ((!contentEnabled) && (!structureEnabled) && (!dropEnabled)) { |