diff options
| author | Max <post@wickenrode.com> | 2014-11-11 02:47:32 +0100 |
|---|---|---|
| committer | Max <post@wickenrode.com> | 2014-11-11 02:47:32 +0100 |
| commit | 69ca4afe9ba4c9c710b69e4d22d32d22a007c8a9 (patch) | |
| tree | c8beabbf65afbaa3afa6dff27e4a9151a2015909 /Source/SPDatabaseDocument.h | |
| parent | 6d48720a8279e7e97e9a225aab34c0688abd8e00 (diff) | |
| download | sequelpro-69ca4afe9ba4c9c710b69e4d22d32d22a007c8a9.tar.gz sequelpro-69ca4afe9ba4c9c710b69e4d22d32d22a007c8a9.tar.bz2 sequelpro-69ca4afe9ba4c9c710b69e4d22d32d22a007c8a9.zip | |
Attempt to fix #1961
Namely this commit changes two things:
1) In the past the user manager window technically was closed after it was released (SPUserManager.m:491):
[NSApp endSheet:[self window] returnCode:0]; //-> calls delegate, which calls release
[[self window] orderOut:self];
This call order has now been swapped.
2) Because the delegate is invoked directly by NSApp, the release was called before other UI elements had finished their cleanup from orderOut:. The delegate callback is now put on the runloop to give other stuff priority.
Requesting QA on this commit.
Diffstat (limited to 'Source/SPDatabaseDocument.h')
| -rw-r--r-- | Source/SPDatabaseDocument.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/Source/SPDatabaseDocument.h b/Source/SPDatabaseDocument.h index a67619e8..0cd485b9 100644 --- a/Source/SPDatabaseDocument.h +++ b/Source/SPDatabaseDocument.h @@ -427,7 +427,6 @@ - (void)saveConnectionPanelDidEnd:(NSSavePanel *)panel returnCode:(NSInteger)returnCode contextInfo:(void *)contextInfo; - (BOOL)saveDocumentWithFilePath:(NSString *)fileName inBackground:(BOOL)saveInBackground onlyPreferences:(BOOL)saveOnlyPreferences contextInfo:(NSDictionary*)contextInfo; -- (void)userManagerSheetDidEnd:(NSWindow *)sheet returnCode:(int)returnCode contextInfo:(void*)context; - (void)setIsSavedInBundle:(BOOL)savedInBundle; - (void)setFileURL:(NSURL *)fileURL; - (void)connect; |