Various improvements to server capability/version checking, including:

- Add a new ServerSupport class, for which an instance is created upon each new connection and is then subsequently accessible via SPDatabaseDocument.
- Replace the majority of manual version checking with calls to properties in the above new class.
- Improve the user manager's compatibility with MySQL 3 and 4 servers. Fixes issue #811

Other changes include:

- Disable the encoding popup button when adding a new table or database to servers running pre MySQL 4.1 as it only contains one option, 'Default'.
- Fix various potential memory leaks discovered during static analysis.
- General tidy up and comments.

1 files changed, 19 insertions, 4 deletions

diff --git a/Source/SPDatabaseData.h b/Source/SPDatabaseData.h
index f0b79b45..de98ff9d 100644
--- a/Source/SPDatabaseData.h
+++ b/Source/SPDatabaseData.h
@@ -34,14 +34,20 @@ typedef struct
 	const char *description;
 } SPDatabaseCharSets;
 
+@class SPServerSupport;
+
+/**
+ * @class SPDatabaseData SPDatabaseData.h
+ *
+ * @author Stuart Connolly http://stuconnolly.com/
+ *
+ * This class provides various convenience methods for obtaining data associated with the current database, 
+ * if available. This includes available encodings, collations, etc.
+ */
 @interface SPDatabaseData : NSObject 
 {
 	NSString *characterSetEncoding;
 	
-	NSInteger serverMajorVersion;
-	NSInteger serverMinorVersion;
-	NSInteger serverReleaseVersion;
-	
 	NSMutableArray *collations;
 	NSMutableArray *characterSetCollations;
 	NSMutableArray *storageEngines;
@@ -49,10 +55,19 @@ typedef struct
 	NSMutableDictionary *cachedCollationsByEncoding;
 	
 	MCPConnection *connection;
+	SPServerSupport *serverSupport;	
 }
 
+/**
+ * @property connection The current database connection
+ */
 @property (readwrite, assign) MCPConnection *connection;
 
+/**
+ * @property serverSupport The connection's associated SPServerSupport instance
+ */
+@property (readwrite, assign) SPServerSupport *serverSupport;
+
 - (void)resetAllData;
 
 - (NSArray *)getDatabaseCollations;