- Fix issues where removing favorites could cause crashes in other tabs/windows where the favorite was selected (Issue #1351)

 - Keep multiple windows and tabs in sync when editing favorites
 - Fix a new KVO observation not being removed on object teardown

1 files changed, 7 insertions, 0 deletions

diff --git a/Source/SPConnectionController.m b/Source/SPConnectionController.m
index 68d7bb16..6de0c9c3 100644
--- a/Source/SPConnectionController.m
+++ b/Source/SPConnectionController.m
@@ -971,6 +971,10 @@ static NSComparisonResult _compareFavoritesUsingKey(id favorite1, id favorite2,
 		[favoritesController saveFavorites];
 		
 		[self _reloadFavoritesViewData];
+
+		if ([keyPath isEqualToString:SPFavoriteNameKey]) {
+			[[NSNotificationCenter defaultCenter] postNotificationName:SPConnectionFavoritesChangedNotification object:self];
+		}
 	}
 }
 
@@ -1126,6 +1130,8 @@ static NSComparisonResult _compareFavoritesUsingKey(id favorite1, id favorite2,
 	[favoritesController saveFavorites];
 	 
 	[self _reloadFavoritesViewData];
+
+	[[NSNotificationCenter defaultCenter] postNotificationName:SPConnectionFavoritesChangedNotification object:self];
 }
 
 /**
@@ -1524,6 +1530,7 @@ static NSComparisonResult _compareFavoritesUsingKey(id favorite1, id favorite2,
 	[NSObject cancelPreviousPerformRequestsWithTarget:self];
 	
 	// Unregister observers
+	[self removeObserver:self forKeyPath:SPFavoriteTypeKey];
 	[self removeObserver:self forKeyPath:SPFavoriteNameKey];
 	[self removeObserver:self forKeyPath:SPFavoriteHostKey];
 	[self removeObserver:self forKeyPath:SPFavoriteUserKey];