• Bundle Command support

- added shell var SP_ICON_FILE
- a bundle command which outputs its result as HTML window will write the data in the same window, ie it won't be create each time a new window; the window will be identified by the bundle's uuid
- fixed issue while saving a short-cut in keybinding.dict format, now it ignores possible diacritics - maybe bug in ShortcutRecorder for method [aRecorder keyCharsIgnoringModifiers] since in the objectValue it's set correctly

1 files changed, 8 insertions, 3 deletions

diff --git a/Source/SPBundleEditorController.m b/Source/SPBundleEditorController.m
index 0a34e61b..bddc7a22 100644
--- a/Source/SPBundleEditorController.m
+++ b/Source/SPBundleEditorController.m
@@ -899,7 +899,13 @@
 
 	// Transform KeyCombo struct to KeyBinding.dict format for NSMenuItems
 	NSMutableString *keyEq = [NSMutableString string];
-	NSString *theChar = [[aRecorder keyCharsIgnoringModifiers] lowercaseString];
+
+	NSString *theChar = @"";
+
+	if([aRecorder objectValue])
+		theChar =[[[aRecorder objectValue] objectForKey:@"characters"] lowercaseString];
+	else
+		theChar =[[aRecorder keyCharsIgnoringModifiers] lowercaseString];
 	[keyEq setString:@""];
 	if(newKeyCombo.code > -1) {
 		if(newKeyCombo.flags & NSControlKeyMask)
@@ -1120,9 +1126,8 @@
 				isValid = NO;
 			}
 
-	
 			// If not valid reset name to the old one
-			if(!isValid) {
+			if(!isValid && oldBundleName) {
 				[[self _currentSelectedObject] setObject:oldBundleName forKey:kBundleNameKey];
 			}