diff options
| author | rowanbeentje <rowan@beent.je> | 2009-06-12 00:59:58 +0000 |
|---|---|---|
| committer | rowanbeentje <rowan@beent.je> | 2009-06-12 00:59:58 +0000 |
| commit | fa8a025d389f3915caf2d20fd0afed9936e6c55b (patch) | |
| tree | bdb235f65752472353e4c46b5269b3955684c627 /Source/CMMCPConnection.h | |
| parent | fbdd43314fb401f3c563fab3a37e24799d31ef56 (diff) | |
| download | sequelpro-fa8a025d389f3915caf2d20fd0afed9936e6c55b.tar.gz sequelpro-fa8a025d389f3915caf2d20fd0afed9936e6c55b.tar.bz2 sequelpro-fa8a025d389f3915caf2d20fd0afed9936e6c55b.zip | |
Fixes connection timeouts during queries of over three seconds, and speeds up queries further (1.5x faster for short socket queries).
Doing further research, it turns out that mysql_query should effectively lock the connection, and mysql_ping should not be performed while a query is active as mysql is specifically not thread-safe in this one regard. This fixes #293. However, it means that we will suffer from http://bugs.mysql.com/bug.php?id=9678 again; if we don't complete the framework integration before 0.9.6, we should roll back this patch and r831 to allow all connections to behave properly and avoid hangs.
Diffstat (limited to 'Source/CMMCPConnection.h')
| -rw-r--r-- | Source/CMMCPConnection.h | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/Source/CMMCPConnection.h b/Source/CMMCPConnection.h index 2f2552e4..7c892ead 100644 --- a/Source/CMMCPConnection.h +++ b/Source/CMMCPConnection.h @@ -61,10 +61,6 @@ NSString *serverVersionString; - NSStringEncoding workerStringEncoding; - int workerQueryResultCode; - BOOL workerQueryComplete; - NSTimer *keepAliveTimer; NSDate *lastKeepAliveSuccess; } @@ -86,7 +82,6 @@ - (BOOL) selectDB:(NSString *) dbName; - (CMMCPResult *) queryString:(NSString *) query; - (CMMCPResult *) queryString:(NSString *) query usingEncoding:(NSStringEncoding) encoding; -- (void) workerPerformQuery:(NSString *)theQuery; - (float) lastQueryExecutionTime; - (MCPResult *) listDBsLike:(NSString *) dbsName; - (BOOL) checkConnection; |