diff options
| author | Bibiko <bibiko@eva.mpg.de> | 2010-01-09 14:23:53 +0000 |
|---|---|---|
| committer | Bibiko <bibiko@eva.mpg.de> | 2010-01-09 14:23:53 +0000 |
| commit | 604efb07d3cbbc46e93148c2bebb9ae95dd1de5f (patch) | |
| tree | 01716ce13fc0ce0c3a98e68bf5643d70299a8568 | |
| parent | 9004533ba1d84d670a77cbfc9eae401b66e9dd0e (diff) | |
| download | sequelpro-604efb07d3cbbc46e93148c2bebb9ae95dd1de5f.tar.gz sequelpro-604efb07d3cbbc46e93148c2bebb9ae95dd1de5f.tar.bz2 sequelpro-604efb07d3cbbc46e93148c2bebb9ae95dd1de5f.zip | |
removed/refactored three instances of calling a method of untyped (id) objects
| -rw-r--r-- | Source/SPContentFilterManager.m | 8 | ||||
| -rw-r--r-- | Source/SPFieldEditorController.m | 2 | ||||
| -rw-r--r-- | Source/SPQueryFavoriteManager.m | 10 |
3 files changed, 12 insertions, 8 deletions
diff --git a/Source/SPContentFilterManager.m b/Source/SPContentFilterManager.m index 5ef8695c..e1d7e389 100644 --- a/Source/SPContentFilterManager.m +++ b/Source/SPContentFilterManager.m @@ -424,9 +424,11 @@ - (void)tableView:(NSTableView *)aTableView setObjectValue:(id)anObject forTableColumn:(NSTableColumn *)aTableColumn row:(NSInteger)rowIndex { - if([[aTableColumn identifier] isEqualToString:@"MenuLabel"] && [anObject length]) { - [[contentFilters objectAtIndex:rowIndex] setObject:[anObject description] forKey:@"MenuLabel"]; - [contentFilterNameTextField setStringValue:[anObject description]]; + if([[aTableColumn identifier] isEqualToString:@"MenuLabel"]) { + if([anObject isKindOfClass:[NSString class]] && [(NSString *)anObject length]) { + [[contentFilters objectAtIndex:rowIndex] setObject:anObject forKey:@"MenuLabel"]; + [contentFilterNameTextField setStringValue:anObject]; + } } [contentFilterTableView reloadData]; diff --git a/Source/SPFieldEditorController.m b/Source/SPFieldEditorController.m index fa7a8edd..7b52bbf8 100644 --- a/Source/SPFieldEditorController.m +++ b/Source/SPFieldEditorController.m @@ -411,7 +411,7 @@ break; case 2: // hex - load on demand [[self window] makeFirstResponder:hexTextView]; - if([sheetEditData length] && [[hexTextView string] isEqualToString:@""]) { + if([[hexTextView string] isEqualToString:@""]) { [editSheetProgressBar startAnimation:self]; if([sheetEditData isKindOfClass:[NSData class]]) { [hexTextView setString:[sheetEditData dataToFormattedHexString]]; diff --git a/Source/SPQueryFavoriteManager.m b/Source/SPQueryFavoriteManager.m index 11a5ec13..ef458c87 100644 --- a/Source/SPQueryFavoriteManager.m +++ b/Source/SPQueryFavoriteManager.m @@ -426,10 +426,12 @@ - (void)tableView:(NSTableView *)aTableView setObjectValue:(id)anObject forTableColumn:(NSTableColumn *)aTableColumn row:(NSInteger)rowIndex { - if([[aTableColumn identifier] isEqualToString:@"name"] && [anObject length]) { - [[favorites objectAtIndex:rowIndex] setObject:[anObject description] forKey:@"name"]; - // [[favorites objectAtIndex:rowIndex] setObject:[favoriteQueryTextView string] forKey:@"query"]; - [favoriteNameTextField setStringValue:[anObject description]]; + if([[aTableColumn identifier] isEqualToString:@"name"]) { + if([anObject isKindOfClass:[NSString class]] && [(NSString *)anObject length]) { + [[favorites objectAtIndex:rowIndex] setObject:anObject forKey:@"name"]; + // [[favorites objectAtIndex:rowIndex] setObject:[favoriteQueryTextView string] forKey:@"query"]; + [favoriteNameTextField setStringValue:anObject]; + } } [favoritesTableView reloadData]; |