From ea093d46363a01833e8b64dd538990227bea19d2 Mon Sep 17 00:00:00 2001 From: Seth Mos Date: Tue, 16 Jan 2007 12:27:25 +0000 Subject: Fix allow interface check against proper $config settings. Was this theoretical proof of concept code? --- packages/squid/squid.inc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'packages') diff --git a/packages/squid/squid.inc b/packages/squid/squid.inc index 9dccb9b1..5b9b9156 100644 --- a/packages/squid/squid.inc +++ b/packages/squid/squid.inc @@ -634,6 +634,7 @@ function squid_resync_auth() { global $config, $valid_acls; $settings = $config['installedpackages']['squidauth']['config'][0]; + $settingsconfig = $config['installedpackages']['squid']['config'][0]; $conf = ''; // Deny the banned guys before allowing the good guys @@ -675,10 +676,9 @@ function squid_resync_auth() { $transparent_proxy = ($config['installedpackages']['squid']['config'][0]['transparent_proxy'] == 'on'); $auth_method = (($settings['auth_method'] && !$transparent_proxy) ? $settings['auth_method'] : 'none'); - // Allow the remaining ACLs if no authentication is set if ($auth_method == 'none') { - if ($settings['allow_interface'] == 'on') { + if ($settingsconfig['allow_interface'] == 'on') { $allowed = array('localnet', 'allowed_subnets'); $allowed = array_filter($allowed, 'squid_is_valid_acl'); foreach ($allowed as $acl) -- cgit v1.2.3