From d164882b708cbcd4231f1d66ea7c07ee6f1aa5fd Mon Sep 17 00:00:00 2001 From: Marcello Coutinho Date: Wed, 9 May 2012 17:08:59 -0300 Subject: imspector-dev - include rpc xml code and fix restart process --- config/imspector-dev/imspector.inc | 166 ++++++++++++++++++++---- config/imspector-dev/imspector.xml | 2 +- config/imspector-dev/imspector_replacements.xml | 2 +- 3 files changed, 141 insertions(+), 29 deletions(-) (limited to 'config/imspector-dev') diff --git a/config/imspector-dev/imspector.inc b/config/imspector-dev/imspector.inc index d1a65b20..6f1cf92c 100644 --- a/config/imspector-dev/imspector.inc +++ b/config/imspector-dev/imspector.inc @@ -32,6 +32,7 @@ require_once("config.inc"); require_once("functions.inc"); + require_once("service-utils.inc"); /* IMSpector */ @@ -39,7 +40,6 @@ define('IMSPECTOR_ETC', '/usr/local/etc/imspector'); define('IMSPECTOR_CONFIG', IMSPECTOR_ETC . '/imspector.conf'); - function imspector_notice ($msg) { syslog(LOG_NOTICE, "imspector: {$msg}"); } function imspector_warn ($msg) { syslog(LOG_WARNING, "imspector: {$msg}"); } function ims_text_area_decode($text){ @@ -51,12 +51,6 @@ mwexec(IMSPECTOR_RCFILE.' '.$action); } - function imspector_running () { - if((int)exec('pgrep imspector | wc -l') > 0) - return true; - return false; - } - function write_imspector_config($file, $text) { $conf = fopen($file, 'w'); if(!$conf) { @@ -177,11 +171,12 @@ write_config(); /*continue sync process*/ + log_error("Imspector: Saving changes."); config_lock(); /* remove existing rules */ - exec('/sbin/pfctl -a imspector -Fr'); - exec('/sbin/pfctl -a imspector -Fn'); + exec('/sbin/pfctl -a imspector -Fr > /dev/null'); + exec('/sbin/pfctl -a imspector -Fn > /dev/null'); $ifaces_active = ''; @@ -217,8 +212,11 @@ imspector_warn("Could not resolve real interface for {$iface}"); } } - + + + /*reload rules*/ if($pf_rules) { + log_error("Imspector: Reloading rules."); exec("echo \"{$pf_rules}\" | /sbin/pfctl -a imspector -f -"); conf_mount_rw(); @@ -348,7 +346,7 @@ /* generate rc file start and stop */ $stop = <<setCredentials($username, $password); + if($g['debug']) + $cli->setDebug(1); + /* send our XMLRPC message and timeout after 250 seconds */ + $resp = $cli->send($msg, "250"); + if(!$resp) { + $error = "A communications error occurred while attempting imspector XMLRPC sync with {$url}:{$port}."; + log_error($error); + file_notice("sync_settings", $error, "imspector Settings Sync", ""); + } elseif($resp->faultCode()) { + $cli->setDebug(1); + $resp = $cli->send($msg, "250"); + $error = "An error code was received while attempting imspector XMLRPC sync with {$url}:{$port} - Code " . $resp->faultCode() . ": " . $resp->faultString(); + log_error($error); + file_notice("sync_settings", $error, "imspector Settings Sync", ""); + } else { + log_error("imspector XMLRPC sync successfully completed with {$url}:{$port}."); + } + + /* tell imspector to reload our settings on the destionation sync host. */ + $method = 'pfsense.exec_php'; + $execcmd = "require_once('/usr/local/pkg/imspector.inc');\n"; + $execcmd .= "sync_package_imspector();"; + /* assemble xmlrpc payload */ + $params = array( + XML_RPC_encode($password), + XML_RPC_encode($execcmd) + ); + + log_error("imspector XMLRPC reload data {$url}:{$port}."); + $msg = new XML_RPC_Message($method, $params); + $cli = new XML_RPC_Client('/xmlrpc.php', $url, $port); + $cli->setCredentials($username, $password); + $resp = $cli->send($msg, "250"); + if(!$resp) { + $error = "A communications error occurred while attempting imspector XMLRPC sync with {$url}:{$port} (pfsense.exec_php)."; + log_error($error); + file_notice("sync_settings", $error, "imspector Settings Sync", ""); + } elseif($resp->faultCode()) { + $cli->setDebug(1); + $resp = $cli->send($msg, "250"); + $error = "An error code was received while attempting imspector XMLRPC sync with {$url}:{$port} - Code " . $resp->faultCode() . ": " . $resp->faultString(); + log_error($error); + file_notice("sync_settings", $error, "imspector Settings Sync", ""); + } else { + log_error("imspector XMLRPC reload data success with {$url}:{$port} (pfsense.exec_php)."); + } + +} ?> \ No newline at end of file diff --git a/config/imspector-dev/imspector.xml b/config/imspector-dev/imspector.xml index 7e62ee8e..4d12a3d2 100644 --- a/config/imspector-dev/imspector.xml +++ b/config/imspector-dev/imspector.xml @@ -46,7 +46,6 @@ 20111108 Services: IMSpector Save - /services_imspector_logs.php /usr/local/pkg/imspector.inc IMSpector @@ -58,6 +57,7 @@ imspector imspector.sh imspector + diff --git a/config/imspector-dev/imspector_replacements.xml b/config/imspector-dev/imspector_replacements.xml index 6b211708..e0ff4a06 100644 --- a/config/imspector-dev/imspector_replacements.xml +++ b/config/imspector-dev/imspector_replacements.xml @@ -46,7 +46,6 @@ 20111108 Services: IMSpector Save - /services_imspector_logs.php /usr/local/pkg/imspector.inc IMSpector @@ -191,4 +190,5 @@ deinstall_package_imspector(); imspector_generate_rules + \ No newline at end of file -- cgit v1.2.3