From 887ab7ce4ee31cf924e28f3c85783b5cf8352cc1 Mon Sep 17 00:00:00 2001
From: Marc Tamlyn <marc.tamlyn@gmail.com>
Date: Fri, 27 Jul 2012 11:31:48 +0100
Subject: Remove deprecated methods/views.

---
 wkhtmltopdf/views.py | 39 ---------------------------------------
 1 file changed, 39 deletions(-)

(limited to 'wkhtmltopdf/views.py')

diff --git a/wkhtmltopdf/views.py b/wkhtmltopdf/views.py
index fff98c8..20002bd 100644
--- a/wkhtmltopdf/views.py
+++ b/wkhtmltopdf/views.py
@@ -2,7 +2,6 @@ from __future__ import absolute_import
 
 from re import compile
 from tempfile import NamedTemporaryFile
-import warnings
 
 from django.conf import settings
 from django.http import HttpResponse
@@ -38,13 +37,6 @@ class PDFResponse(HttpResponse):
             del self['Content-Disposition']
 
 
-class PdfResponse(PDFResponse):
-    def __init__(self, content, filename):
-        warnings.warn('PdfResponse is deprecated in favour of PDFResponse. It will be removed in version 1.',
-                      PendingDeprecationWarning, 2)
-        super(PdfResponse, self).__init__(content, filename=filename)
-
-
 class PDFTemplateResponse(TemplateResponse, PDFResponse):
     """Renders a Template into a PDF using wkhtmltopdf"""
 
@@ -229,11 +221,6 @@ class PDFTemplateView(TemplateView):
     def get_cmd_options(self):
         return self.cmd_options
 
-    def get_pdf_kwargs(self):
-        warnings.warn('PDFTemplateView.get_pdf_kwargs() is deprecated in favour of get_cmd_options(). It will be removed in version 1.',
-                      PendingDeprecationWarning, 2)
-        return self.get_cmd_options()
-
     def render_to_response(self, context, **response_kwargs):
         """
         Returns a PDF response with a template rendered with the given context.
@@ -261,29 +248,3 @@ class PDFTemplateView(TemplateView):
                 context=context,
                 **response_kwargs
             )
-
-
-class PdfTemplateView(PDFTemplateView): #TODO: Remove this in v1.0
-    orientation = 'portrait'
-    margin_bottom = 0
-    margin_left = 0
-    margin_right = 0
-    margin_top = 0
-
-    def __init__(self, *args, **kwargs):
-        warnings.warn('PdfTemplateView is deprecated in favour of PDFTemplateView. It will be removed in version 1.',
-                      PendingDeprecationWarning, 2)
-        super(PdfTemplateView, self).__init__(*args, **kwargs)
-
-    def get_cmd_options(self):
-        return self.get_pdf_kwargs()
-
-    def get_pdf_kwargs(self):
-        kwargs = {
-            'margin_bottom': self.margin_bottom,
-            'margin_left': self.margin_left,
-            'margin_right': self.margin_right,
-            'margin_top': self.margin_top,
-            'orientation': self.orientation,
-        }
-        return kwargs
-- 
cgit v1.2.3


From e4a84d5f2e1282ed62d19ce7c52ca57eabb54598 Mon Sep 17 00:00:00 2001
From: Marc Tamlyn <marc.tamlyn@gmail.com>
Date: Fri, 27 Jul 2012 11:36:02 +0100
Subject: Don't override builtins by importing.

---
 wkhtmltopdf/views.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

(limited to 'wkhtmltopdf/views.py')

diff --git a/wkhtmltopdf/views.py b/wkhtmltopdf/views.py
index 20002bd..6668474 100644
--- a/wkhtmltopdf/views.py
+++ b/wkhtmltopdf/views.py
@@ -1,7 +1,7 @@
 from __future__ import absolute_import
 
-from re import compile
 from tempfile import NamedTemporaryFile
+import re
 
 from django.conf import settings
 from django.http import HttpResponse
@@ -160,7 +160,7 @@ class PDFTemplateResponse(TemplateResponse, PDFResponse):
         if self.override_settings is not None:
             overrides.update(self.override_settings)
 
-        has_scheme = compile(r'^[^:/]+://')
+        has_scheme = re.compile(r'^[^:/]+://')
 
         # If MEDIA_URL doesn't have a scheme, we transform it into a
         # file:// URL based on MEDIA_ROOT.
-- 
cgit v1.2.3


From dc9f1fb46f587f2b8dbbfc440a72944b183c0fcd Mon Sep 17 00:00:00 2001
From: Marc Tamlyn <marc.tamlyn@gmail.com>
Date: Fri, 27 Jul 2012 16:33:39 +0100
Subject: .html default suffix for render_to_temporary_file

It's expected by wkhtmltopdf that the files should end in .html, so it
may as well be the default.
---
 wkhtmltopdf/views.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'wkhtmltopdf/views.py')

diff --git a/wkhtmltopdf/views.py b/wkhtmltopdf/views.py
index 6668474..f7e2feb 100644
--- a/wkhtmltopdf/views.py
+++ b/wkhtmltopdf/views.py
@@ -66,7 +66,7 @@ class PDFTemplateResponse(TemplateResponse, PDFResponse):
         self.override_settings = override_settings
 
     def render_to_temporary_file(self, template_name, mode='w+b', bufsize=-1,
-                                 suffix='', prefix='tmp', dir=None,
+                                 suffix='.html', prefix='tmp', dir=None,
                                  delete=True):
         template = self.resolve_template(template_name)
 
-- 
cgit v1.2.3